RE: [PATCH 3/3] ASoC: da7218: Improve a size determination in da7218_i2c_probe()

[Adam Thomson]

On 23 November 2017 20:08, SF Markus Elfring wrote:

> From: Markus Elfring 
> Date: Thu, 23 Nov 2017 20:50:44 +0100
> 
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 

Acked-by: Adam Thomson 

> ---
>  sound/soc/codecs/da7218.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c
> index 93a0cb741751..0c1933a98995 100644
> --- a/sound/soc/codecs/da7218.c
> +++ b/sound/soc/codecs/da7218.c
> @@ -3269,8 +3269,7 @@ static int da7218_i2c_probe(struct i2c_client *i2c,
>   struct da7218_priv *da7218;
>   int ret;
> 
> - da7218 = devm_kzalloc(>dev, sizeof(struct da7218_priv),
> -   GFP_KERNEL);
> + da7218 = devm_kzalloc(>dev, sizeof(*da7218), GFP_KERNEL);
>   if (!da7218)
>   return -ENOMEM;
> 
> --
> 2.15.0

RE: [PATCH 3/3] ASoC: da7218: Improve a size determination in da7218_i2c_probe()

[Adam Thomson]

On 23 November 2017 20:08, SF Markus Elfring wrote:

> From: Markus Elfring 
> Date: Thu, 23 Nov 2017 20:50:44 +0100
> 
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 

Acked-by: Adam Thomson 

> ---
>  sound/soc/codecs/da7218.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c
> index 93a0cb741751..0c1933a98995 100644
> --- a/sound/soc/codecs/da7218.c
> +++ b/sound/soc/codecs/da7218.c
> @@ -3269,8 +3269,7 @@ static int da7218_i2c_probe(struct i2c_client *i2c,
>   struct da7218_priv *da7218;
>   int ret;
> 
> - da7218 = devm_kzalloc(>dev, sizeof(struct da7218_priv),
> -   GFP_KERNEL);
> + da7218 = devm_kzalloc(>dev, sizeof(*da7218), GFP_KERNEL);
>   if (!da7218)
>   return -ENOMEM;
> 
> --
> 2.15.0