RE: [PATCH 8/9] mtd: Allow mtd block device drivers to have a custom ioctl function
To make a modules, we have to export "get_mtd_blktrans_gendisk". "get_mtd_blktrans_gendisk" is used at mtdswap. > > +struct gendisk *get_mtd_blktrans_gendisk(struct > mtd_blktrans_dev *dev) > +{ > + return dev->blkcore_priv; > +} > + @@ -469,6 +480,7 @@ EXPORT_SYMBOL_GPL(register_mtd_blktrans); EXPORT_SYMBOL_GPL(deregister_mtd_blktrans); EXPORT_SYMBOL_GPL(add_mtd_blktrans_dev); EXPORT_SYMBOL_GPL(del_mtd_blktrans_dev); +EXPORT_SYMBOL_GPL(get_mtd_blktrans_gendisk); MODULE_AUTHOR("David Woodhouse <[EMAIL PROTECTED]>"); MODULE_LICENSE("GPL"); Thank you, Kyungmin Park - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 8/9] mtd: Allow mtd block device drivers to have a custom ioctl function
On Friday 02 March 2007 16:55:02 Richard Purdie wrote: > Allow mtd block drivers to customise their ioctl functions. Also > allow the drivers to obtain the gendisk struct since ioctl > functions can need this. Are you sure that this is a good idea? I'd rather not open up this method of letting the individual drivers to bad things. > This also moves the mtd ioctl functions from locked to unlocked. > As far as I can see, nothing in the mtd code has locking problems. This part looks fine to me. Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 8/9] mtd: Allow mtd block device drivers to have a custom ioctl function
On Friday 02 March 2007 16:55:02 Richard Purdie wrote: Allow mtd block drivers to customise their ioctl functions. Also allow the drivers to obtain the gendisk struct since ioctl functions can need this. Are you sure that this is a good idea? I'd rather not open up this method of letting the individual drivers to bad things. This also moves the mtd ioctl functions from locked to unlocked. As far as I can see, nothing in the mtd code has locking problems. This part looks fine to me. Arnd - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 8/9] mtd: Allow mtd block device drivers to have a custom ioctl function
To make a modules, we have to export get_mtd_blktrans_gendisk. get_mtd_blktrans_gendisk is used at mtdswap. +struct gendisk *get_mtd_blktrans_gendisk(struct mtd_blktrans_dev *dev) +{ + return dev-blkcore_priv; +} + @@ -469,6 +480,7 @@ EXPORT_SYMBOL_GPL(register_mtd_blktrans); EXPORT_SYMBOL_GPL(deregister_mtd_blktrans); EXPORT_SYMBOL_GPL(add_mtd_blktrans_dev); EXPORT_SYMBOL_GPL(del_mtd_blktrans_dev); +EXPORT_SYMBOL_GPL(get_mtd_blktrans_gendisk); MODULE_AUTHOR(David Woodhouse [EMAIL PROTECTED]); MODULE_LICENSE(GPL); Thank you, Kyungmin Park - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/