RE: [PATCH RESEND 11/12] xfstests: fsx: Add fallocate insert range operation
>
> On Tue, Feb 17, 2015 at 12:47:58AM +0900, Namjae Jeon wrote:
> > From: Namjae Jeon
> >
> > This commit adds fallocate FALLOC_FL_INSERT_RANGE support for fsx.
> >
> > Signed-off-by: Namjae Jeon
> > Signed-off-by: Ashish Sangwan
> > Reviewed-by: Brian Foster
> > ---
> > ltp/fsx.c | 124
> > -
> > 1 file changed, 114 insertions(+), 10 deletions(-)
> .
> > @@ -339,6 +341,14 @@ logdump(void)
> > lp->args[0] + lp->args[1])
> > prt("\t**");
> > break;
> > + case OP_INSERT_RANGE:
> > + prt("INSERT 0x%x thru 0x%x\t(0x%x bytes)",
> > + lp->args[0], lp->args[0] + lp->args[1] - 1,
> > + lp->args[1]);
> > + if (badoff >= lp->args[0] && badoff <
> > +lp->args[0] + lp->args[1])
> > + prt("\t**");
>
Hi Dave,
> Probably should output "*" so we can distinguish it from
> collapse operations easily.
Right. I will change it.
>
> > @@ -1307,6 +1403,9 @@ usage(void)
> > #ifdef FALLOC_FL_COLLAPSE_RANGE
> > " -C: Do not use collapse range calls\n"
> > #endif
> > +#ifdef FALLOC_FL_INSERT_RANGE
> > +" -i: Do not use insert range calls\n"
> > +#endif
>
> I'd make that "-I" rather than "-i" so it matches with the "-C" of
> collapse range.
Okay.
Thanks for your review!
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> da...@fromorbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RESEND 11/12] xfstests: fsx: Add fallocate insert range operation
On Tue, Feb 17, 2015 at 12:47:58AM +0900, Namjae Jeon wrote:
> From: Namjae Jeon
>
> This commit adds fallocate FALLOC_FL_INSERT_RANGE support for fsx.
>
> Signed-off-by: Namjae Jeon
> Signed-off-by: Ashish Sangwan
> Reviewed-by: Brian Foster
> ---
> ltp/fsx.c | 124
> -
> 1 file changed, 114 insertions(+), 10 deletions(-)
.
> @@ -339,6 +341,14 @@ logdump(void)
>lp->args[0] + lp->args[1])
> prt("\t**");
> break;
> + case OP_INSERT_RANGE:
> + prt("INSERT 0x%x thru 0x%x\t(0x%x bytes)",
> + lp->args[0], lp->args[0] + lp->args[1] - 1,
> + lp->args[1]);
> + if (badoff >= lp->args[0] && badoff <
> + lp->args[0] + lp->args[1])
> + prt("\t**");
Probably should output "*" so we can distinguish it from
collapse operations easily.
> @@ -1307,6 +1403,9 @@ usage(void)
> #ifdef FALLOC_FL_COLLAPSE_RANGE
> "-C: Do not use collapse range calls\n"
> #endif
> +#ifdef FALLOC_FL_INSERT_RANGE
> +"-i: Do not use insert range calls\n"
> +#endif
I'd make that "-I" rather than "-i" so it matches with the "-C" of
collapse range.
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
