RE: [PATCH V2] soc: imx-scu: Add SoC UID(unique identifier) support
Hi, Marco
> > > + hdr->ver = IMX_SC_RPC_VERSION;
> > > + hdr->svc = IMX_SC_RPC_SVC_MISC;
> > > + hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID;
> > > + hdr->size = 1;
> > > +
> > > + /*
> > > + * SCU FW API always returns an error even the
> > > + * function is successfully executed, so skip
> > > + * returned value check.
> > > + */
> > > + imx_scu_call_rpc(soc_ipc_handle, , true);
> >
> > Please can you add a TODO: or FIXME: tag and also provide the firmware
> > version containing the bug? I know that developers are very busy and
> > follow- up fixes never reach mainline ;)
>
> As I replied in previous mail, I will send out a V3 with below comment:
>
> + /*
> +* SCU FW API does NOT have returned value for
> +* this function, so skip returned value check.
> +*/
> + imx_scu_call_rpc(soc_ipc_handle, , true);
>
> Thanks,
> Anson.
Sorry, after further thought, regarding for SCU API without response, we should
pass the "false" as imx_scu_call_rpc()'s 3rd parameter, so I will remove the
comment
and use below in V3:
+ ret = imx_scu_call_rpc(soc_ipc_handle, , false);
+ if (ret) {
+ pr_err("%s: get soc uid failed, ret %d\n", __func__, ret);
+ return ret;
+ }
Thanks,
Anson
RE: [PATCH V2] soc: imx-scu: Add SoC UID(unique identifier) support
Hi, Marco > > + hdr->ver = IMX_SC_RPC_VERSION; > > + hdr->svc = IMX_SC_RPC_SVC_MISC; > > + hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID; > > + hdr->size = 1; > > + > > + /* > > +* SCU FW API always returns an error even the > > +* function is successfully executed, so skip > > +* returned value check. > > +*/ > > + imx_scu_call_rpc(soc_ipc_handle, , true); > > Please can you add a TODO: or FIXME: tag and also provide the firmware > version containing the bug? I know that developers are very busy and follow- > up fixes never reach mainline ;) As I replied in previous mail, I will send out a V3 with below comment: + /* +* SCU FW API does NOT have returned value for +* this function, so skip returned value check. +*/ + imx_scu_call_rpc(soc_ipc_handle, , true); Thanks, Anson. > > Regards, > Marco
Re: [PATCH V2] soc: imx-scu: Add SoC UID(unique identifier) support
Hi Anson,
On 19-06-28 11:25, anson.hu...@nxp.com wrote:
> From: Anson Huang
>
> Add i.MX SCU SoC's UID(unique identifier) support, user
> can read it from sysfs:
>
> root@imx8qxpmek:~# cat /sys/devices/soc0/soc_uid
> 7B64280B57AC1898
>
> Signed-off-by: Anson Huang
> ---
> Changes since V1:
> - Improve the comment of skipping SCFW API return value check for
> getting UID.
> ---
> drivers/soc/imx/soc-imx-scu.c | 39 +++
> 1 file changed, 39 insertions(+)
>
> diff --git a/drivers/soc/imx/soc-imx-scu.c b/drivers/soc/imx/soc-imx-scu.c
> index 676f612..3eacb54 100644
> --- a/drivers/soc/imx/soc-imx-scu.c
> +++ b/drivers/soc/imx/soc-imx-scu.c
> @@ -27,6 +27,40 @@ struct imx_sc_msg_misc_get_soc_id {
> } data;
> } __packed;
>
> +struct imx_sc_msg_misc_get_soc_uid {
> + struct imx_sc_rpc_msg hdr;
> + u32 uid_low;
> + u32 uid_high;
> +} __packed;
> +
> +static ssize_t soc_uid_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct imx_sc_msg_misc_get_soc_uid msg;
> + struct imx_sc_rpc_msg *hdr =
> + u64 soc_uid;
> +
> + hdr->ver = IMX_SC_RPC_VERSION;
> + hdr->svc = IMX_SC_RPC_SVC_MISC;
> + hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID;
> + hdr->size = 1;
> +
> + /*
> + * SCU FW API always returns an error even the
> + * function is successfully executed, so skip
> + * returned value check.
> + */
> + imx_scu_call_rpc(soc_ipc_handle, , true);
Please can you add a TODO: or FIXME: tag and also provide the firmware
version containing the bug? I know that developers are very busy and
follow-up fixes never reach mainline ;)
Regards,
Marco
> +
> + soc_uid = msg.uid_high;
> + soc_uid <<= 32;
> + soc_uid |= msg.uid_low;
> +
> + return sprintf(buf, "%016llX\n", soc_uid);
> +}
> +
> +static DEVICE_ATTR_RO(soc_uid);
> +
> static int imx_scu_soc_id(void)
> {
> struct imx_sc_msg_misc_get_soc_id msg;
> @@ -102,6 +136,11 @@ static int imx_scu_soc_probe(struct platform_device
> *pdev)
> goto free_revision;
> }
>
> + ret = device_create_file(soc_device_to_device(soc_dev),
> + _attr_soc_uid);
> + if (ret)
> + goto free_revision;
> +
> return 0;
>
> free_revision:
> --
> 2.7.4
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
Re: [PATCH V2] soc: imx-scu: Add SoC UID(unique identifier) support
On Fri, Jun 28, 2019 at 6:36 AM wrote: > > From: Anson Huang > > Add i.MX SCU SoC's UID(unique identifier) support, user > can read it from sysfs: > > root@imx8qxpmek:~# cat /sys/devices/soc0/soc_uid > 7B64280B57AC1898 > > Signed-off-by: Anson Huang Reviewed-by: Daniel Baluta
