RE: [PATCH V3 net-next 5/8] net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver
Hi Richard, > -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Sunday, June 18, 2017 5:45 PM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil@gmail.com; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V3 net-next 5/8] net: hns3: Add support of TX > Scheduler & Shaper to HNS3 driver > > On Sat, Jun 17, 2017 at 06:24:28PM +0100, Salil Mehta wrote: > > + > > +int hclge_tm_schd_init(struct hclge_dev *hdev); > > +int hclge_tm_setup_tc(struct hclge_dev *hdev); > > The definition of this function DNE. Sorry, I did not get what DNE means? Does Not Exist ? If yes, the I can see the definition of both the functions. Best regards Salil > > > +int hclge_pause_setup_hw(struct hclge_dev *hdev); > > + > > +#endif > > -- > > 2.7.4 > > Thanks, > Richard
Re: [PATCH V3 net-next 5/8] net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver
On Sat, Jul 22, 2017 at 11:38:26PM +, Salil Mehta wrote: > > On Sat, Jun 17, 2017 at 06:24:28PM +0100, Salil Mehta wrote: > > > + > > > +int hclge_tm_schd_init(struct hclge_dev *hdev); > > > +int hclge_tm_setup_tc(struct hclge_dev *hdev); > > > > The definition of this function DNE. > Sorry, I did not get what DNE means? Does Not Exist ? > If yes, the I can see the definition of both the functions. Where in this series is hclge_tm_setup_tc() defined? Nowhere, AFAICT. Thanks, Richard
Re: [PATCH V3 net-next 5/8] net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver
On Sat, Jun 17, 2017 at 06:24:28PM +0100, Salil Mehta wrote: > + > +int hclge_tm_schd_init(struct hclge_dev *hdev); > +int hclge_tm_setup_tc(struct hclge_dev *hdev); The definition of this function DNE. > +int hclge_pause_setup_hw(struct hclge_dev *hdev); > + > +#endif > -- > 2.7.4 Thanks, Richard