Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve dhcp state
On Wed, Sep 05, 2012 at 02:25:28AM +, KY Srinivasan wrote: > > I can certainly resubmit this patch with the change you are suggesting. > > This patch > > adds a new file > > and does not impact any of the other patches that follows this. Would you > > want > > me to resubmit all of the > > remaining patches starting with this one. > > I have resent this patch with the change you have suggested. Since this patch > is a > standalone patch I have not resent the other patches that follow this patch. > Let me > know if you want me to resend the remaining patches. Please resend all of them, I no longer have them in my to-apply queue. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve dhcp state
> -Original Message- > From: devel [mailto:devel-boun...@linuxdriverproject.org] On Behalf Of KY > Srinivasan > Sent: Tuesday, September 04, 2012 8:29 PM > To: Greg KH > Cc: o...@aepfle.de; tho...@redhat.com; linux-kernel@vger.kernel.org; > d...@redhat.com; a...@canonical.com; de...@linuxdriverproject.org; > b...@decadent.org.uk > Subject: RE: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve > dhcp > state > > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, September 04, 2012 8:04 PM > > To: KY Srinivasan > > Cc: o...@aepfle.de; tho...@redhat.com; linux-kernel@vger.kernel.org; > > d...@redhat.com; a...@canonical.com; de...@linuxdriverproject.org; > > b...@decadent.org.uk > > Subject: Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve > > dhcp > > state > > > > On Tue, Sep 04, 2012 at 11:39:12PM +, KY Srinivasan wrote: > > > > > > > > > > -Original Message- > > > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > > > Sent: Tuesday, September 04, 2012 6:59 PM > > > > To: KY Srinivasan > > > > Cc: linux-kernel@vger.kernel.org; de...@linuxdriverproject.org; > > o...@aepfle.de; > > > > a...@canonical.com; b...@decadent.org.uk; tho...@redhat.com; > > > > d...@redhat.com > > > > Subject: Re: [PATCH V4 05/10] Tools: hv: Add an example script to > > > > retrieve > > dhcp > > > > state > > > > > > > > On Tue, Sep 04, 2012 at 02:46:37PM -0700, K. Y. Srinivasan wrote: > > > > > To keep the KVP daemon code free of distro specific details, we > > > > > invoke an > > > > > external script to retrieve the DHCP state. This is an example script > > > > > that > > > > > was used to test the KVP code. This script has to be implemented in a > Distro > > > > > specific fashion. For instance on distros that ship with Network > > > > > Manager > > > > enabled, > > > > > this script can be based on NM APIs. > > > > > > > > > > Signed-off-by: K. Y. Srinivasan > > > > > Reviewed-by: Haiyang Zhang > > > > > --- > > > > > tools/hv/hv_get_dhcp_info.sh | 25 + > > > > > 1 files changed, 25 insertions(+), 0 deletions(-) > > > > > create mode 100755 tools/hv/hv_get_dhcp_info.sh > > > > > > > > > > diff --git a/tools/hv/hv_get_dhcp_info.sh > b/tools/hv/hv_get_dhcp_info.sh > > > > > new file mode 100755 > > > > > index 000..3de4587 > > > > > --- /dev/null > > > > > +++ b/tools/hv/hv_get_dhcp_info.sh > > > > > @@ -0,0 +1,25 @@ > > > > > +#!/bin/bash > > > > > + > > > > > +# This example script retrieves the DHCP state of a given interface. > > > > > +# In the interest of keeping the KVP daemon code free of distro > > > > > specific > > > > > +# information; the kvp daemon code invokes this external script to > gather > > > > > +# DHCP setting for the specific interface. > > > > > +# > > > > > +# Input: Name of the interface > > > > > +# > > > > > +# Output: The script prints the string "Enabled" to stdout to > > > > > indicate > > > > > +#that DHCP is enabled on the interface. > > > > > > > > What happens if DHCP is not enabled on the interface? Shouldn't that > > > > also return something other than "success"? > > > > > > The script is expected to write "Enabled" to stdout to indicate if DHCP is > > enabled; if this > > > is not the case, implicitly we assume DHCP is not enabled (since this is > > > a binary > > state). > > > > It's not really "binary" given that you are expecting "Enabled" or > > nothing, right? "Disabled" would make a bit more sense perhaps? > > In the KVP daemon code, I currently only check for "Enabled" to see if > DHCP is enabled. > > > > > Having a script return "nothing at all" to show the failure of a state > > doesn't seem the wisest thing, does it? > > I can certainly resubmit this patch with the change you are suggesting. This > patch > adds a new file > and does not impact any of the other patches that follows this. Would you want > me to resubmit all of the > remaining patches starting with this one. I have resent this patch with the change you have suggested. Since this patch is a standalone patch I have not resent the other patches that follow this patch. Let me know if you want me to resend the remaining patches. Regards, K. Y > ___ > devel mailing list > de...@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/devel > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve dhcp state
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, September 04, 2012 8:04 PM > To: KY Srinivasan > Cc: o...@aepfle.de; tho...@redhat.com; linux-kernel@vger.kernel.org; > d...@redhat.com; a...@canonical.com; de...@linuxdriverproject.org; > b...@decadent.org.uk > Subject: Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve > dhcp > state > > On Tue, Sep 04, 2012 at 11:39:12PM +, KY Srinivasan wrote: > > > > > > > -Original Message- > > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > > Sent: Tuesday, September 04, 2012 6:59 PM > > > To: KY Srinivasan > > > Cc: linux-kernel@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; > > > a...@canonical.com; b...@decadent.org.uk; tho...@redhat.com; > > > d...@redhat.com > > > Subject: Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve > dhcp > > > state > > > > > > On Tue, Sep 04, 2012 at 02:46:37PM -0700, K. Y. Srinivasan wrote: > > > > To keep the KVP daemon code free of distro specific details, we invoke > > > > an > > > > external script to retrieve the DHCP state. This is an example script > > > > that > > > > was used to test the KVP code. This script has to be implemented in a > > > > Distro > > > > specific fashion. For instance on distros that ship with Network Manager > > > enabled, > > > > this script can be based on NM APIs. > > > > > > > > Signed-off-by: K. Y. Srinivasan > > > > Reviewed-by: Haiyang Zhang > > > > --- > > > > tools/hv/hv_get_dhcp_info.sh | 25 + > > > > 1 files changed, 25 insertions(+), 0 deletions(-) > > > > create mode 100755 tools/hv/hv_get_dhcp_info.sh > > > > > > > > diff --git a/tools/hv/hv_get_dhcp_info.sh b/tools/hv/hv_get_dhcp_info.sh > > > > new file mode 100755 > > > > index 000..3de4587 > > > > --- /dev/null > > > > +++ b/tools/hv/hv_get_dhcp_info.sh > > > > @@ -0,0 +1,25 @@ > > > > +#!/bin/bash > > > > + > > > > +# This example script retrieves the DHCP state of a given interface. > > > > +# In the interest of keeping the KVP daemon code free of distro > > > > specific > > > > +# information; the kvp daemon code invokes this external script to > > > > gather > > > > +# DHCP setting for the specific interface. > > > > +# > > > > +# Input: Name of the interface > > > > +# > > > > +# Output: The script prints the string "Enabled" to stdout to indicate > > > > +# that DHCP is enabled on the interface. > > > > > > What happens if DHCP is not enabled on the interface? Shouldn't that > > > also return something other than "success"? > > > > The script is expected to write "Enabled" to stdout to indicate if DHCP is > enabled; if this > > is not the case, implicitly we assume DHCP is not enabled (since this is a > > binary > state). > > It's not really "binary" given that you are expecting "Enabled" or > nothing, right? "Disabled" would make a bit more sense perhaps? In the KVP daemon code, I currently only check for "Enabled" to see if DHCP is enabled. > > Having a script return "nothing at all" to show the failure of a state > doesn't seem the wisest thing, does it? I can certainly resubmit this patch with the change you are suggesting. This patch adds a new file and does not impact any of the other patches that follows this. Would you want me to resubmit all of the remaining patches starting with this one. Regards, K. Y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve dhcp state
On Tue, Sep 04, 2012 at 11:39:12PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, September 04, 2012 6:59 PM > > To: KY Srinivasan > > Cc: linux-kernel@vger.kernel.org; de...@linuxdriverproject.org; > > o...@aepfle.de; > > a...@canonical.com; b...@decadent.org.uk; tho...@redhat.com; > > d...@redhat.com > > Subject: Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve > > dhcp > > state > > > > On Tue, Sep 04, 2012 at 02:46:37PM -0700, K. Y. Srinivasan wrote: > > > To keep the KVP daemon code free of distro specific details, we invoke an > > > external script to retrieve the DHCP state. This is an example script that > > > was used to test the KVP code. This script has to be implemented in a > > > Distro > > > specific fashion. For instance on distros that ship with Network Manager > > enabled, > > > this script can be based on NM APIs. > > > > > > Signed-off-by: K. Y. Srinivasan > > > Reviewed-by: Haiyang Zhang > > > --- > > > tools/hv/hv_get_dhcp_info.sh | 25 + > > > 1 files changed, 25 insertions(+), 0 deletions(-) > > > create mode 100755 tools/hv/hv_get_dhcp_info.sh > > > > > > diff --git a/tools/hv/hv_get_dhcp_info.sh b/tools/hv/hv_get_dhcp_info.sh > > > new file mode 100755 > > > index 000..3de4587 > > > --- /dev/null > > > +++ b/tools/hv/hv_get_dhcp_info.sh > > > @@ -0,0 +1,25 @@ > > > +#!/bin/bash > > > + > > > +# This example script retrieves the DHCP state of a given interface. > > > +# In the interest of keeping the KVP daemon code free of distro specific > > > +# information; the kvp daemon code invokes this external script to gather > > > +# DHCP setting for the specific interface. > > > +# > > > +# Input: Name of the interface > > > +# > > > +# Output: The script prints the string "Enabled" to stdout to indicate > > > +#that DHCP is enabled on the interface. > > > > What happens if DHCP is not enabled on the interface? Shouldn't that > > also return something other than "success"? > > The script is expected to write "Enabled" to stdout to indicate if DHCP is > enabled; if this > is not the case, implicitly we assume DHCP is not enabled (since this is a > binary state). It's not really "binary" given that you are expecting "Enabled" or nothing, right? "Disabled" would make a bit more sense perhaps? Having a script return "nothing at all" to show the failure of a state doesn't seem the wisest thing, does it? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve dhcp state
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, September 04, 2012 6:59 PM > To: KY Srinivasan > Cc: linux-kernel@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; > a...@canonical.com; b...@decadent.org.uk; tho...@redhat.com; > d...@redhat.com > Subject: Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve > dhcp > state > > On Tue, Sep 04, 2012 at 02:46:37PM -0700, K. Y. Srinivasan wrote: > > To keep the KVP daemon code free of distro specific details, we invoke an > > external script to retrieve the DHCP state. This is an example script that > > was used to test the KVP code. This script has to be implemented in a Distro > > specific fashion. For instance on distros that ship with Network Manager > enabled, > > this script can be based on NM APIs. > > > > Signed-off-by: K. Y. Srinivasan > > Reviewed-by: Haiyang Zhang > > --- > > tools/hv/hv_get_dhcp_info.sh | 25 + > > 1 files changed, 25 insertions(+), 0 deletions(-) > > create mode 100755 tools/hv/hv_get_dhcp_info.sh > > > > diff --git a/tools/hv/hv_get_dhcp_info.sh b/tools/hv/hv_get_dhcp_info.sh > > new file mode 100755 > > index 000..3de4587 > > --- /dev/null > > +++ b/tools/hv/hv_get_dhcp_info.sh > > @@ -0,0 +1,25 @@ > > +#!/bin/bash > > + > > +# This example script retrieves the DHCP state of a given interface. > > +# In the interest of keeping the KVP daemon code free of distro specific > > +# information; the kvp daemon code invokes this external script to gather > > +# DHCP setting for the specific interface. > > +# > > +# Input: Name of the interface > > +# > > +# Output: The script prints the string "Enabled" to stdout to indicate > > +# that DHCP is enabled on the interface. > > What happens if DHCP is not enabled on the interface? Shouldn't that > also return something other than "success"? The script is expected to write "Enabled" to stdout to indicate if DHCP is enabled; if this is not the case, implicitly we assume DHCP is not enabled (since this is a binary state). Regards, K. Y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve dhcp state
On Tue, Sep 04, 2012 at 02:46:37PM -0700, K. Y. Srinivasan wrote: > To keep the KVP daemon code free of distro specific details, we invoke an > external script to retrieve the DHCP state. This is an example script that > was used to test the KVP code. This script has to be implemented in a Distro > specific fashion. For instance on distros that ship with Network Manager > enabled, > this script can be based on NM APIs. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang > --- > tools/hv/hv_get_dhcp_info.sh | 25 + > 1 files changed, 25 insertions(+), 0 deletions(-) > create mode 100755 tools/hv/hv_get_dhcp_info.sh > > diff --git a/tools/hv/hv_get_dhcp_info.sh b/tools/hv/hv_get_dhcp_info.sh > new file mode 100755 > index 000..3de4587 > --- /dev/null > +++ b/tools/hv/hv_get_dhcp_info.sh > @@ -0,0 +1,25 @@ > +#!/bin/bash > + > +# This example script retrieves the DHCP state of a given interface. > +# In the interest of keeping the KVP daemon code free of distro specific > +# information; the kvp daemon code invokes this external script to gather > +# DHCP setting for the specific interface. > +# > +# Input: Name of the interface > +# > +# Output: The script prints the string "Enabled" to stdout to indicate > +#that DHCP is enabled on the interface. What happens if DHCP is not enabled on the interface? Shouldn't that also return something other than "success"? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
