RE: [PATCH V6 10/10] remoteproc: imx_proc: enable virtio/mailbox

2021-01-14 Thread Peng Fan
> Subject: Re: [PATCH V6 10/10] remoteproc: imx_proc: enable virtio/mailbox
> 
> On Tue, Jan 12, 2021 at 05:39:19PM +0800, peng@nxp.com wrote:
> > From: Peng Fan 
> >
> > Use virtio/mailbox to build connection between Remote Proccessors and
> > Linux. Add work queue to handle incoming messages.
> >
> > Reviewed-by: Richard Zhu 
> > Signed-off-by: Peng Fan 
> > ---
> >  drivers/remoteproc/imx_rproc.c | 115
> > -
> >  1 file changed, 112 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index e62a53ee128e..812b077f1282
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -7,6 +7,7 @@
> >  #include 
> >  #include 
> >  #include 
> > +#include 
> >  #include 
> >  #include 
> >  #include 
> > @@ -15,6 +16,9 @@
> >  #include 
> >  #include 
> >  #include 
> > +#include 
> > +
> > +#include "remoteproc_internal.h"
> >
> >  #define IMX7D_SRC_SCR  0x0C
> >  #define IMX7D_ENABLE_M4BIT(3)
> > @@ -86,6 +90,11 @@ struct imx_rproc {
> > const struct imx_rproc_dcfg *dcfg;
> > struct imx_rproc_memmem[IMX7D_RPROC_MEM_MAX];
> > struct clk  *clk;
> > +   struct mbox_client  cl;
> > +   struct mbox_chan*tx_ch;
> > +   struct mbox_chan*rx_ch;
> > +   struct work_struct  rproc_work;
> > +   struct workqueue_struct *workqueue;
> >  };
> >
> >  static const struct imx_rproc_att imx_rproc_att_imx8mq[] = { @@
> > -366,9 +375,33 @@ static int imx_rproc_parse_fw(struct rproc *rproc,
> const struct firmware *fw)
> > return 0;
> >  }
> >
> > +static void imx_rproc_kick(struct rproc *rproc, int vqid) {
> > +   struct imx_rproc *priv = rproc->priv;
> > +   int err;
> > +   __u32 mmsg;
> > +
> > +   if (!priv->tx_ch) {
> > +   dev_err(priv->dev, "No initialized mbox tx channel\n");
> > +   return;
> > +   }
> > +
> > +   /*
> > +* Send the index of the triggered virtqueue as the mu payload.
> > +* Let remote processor know which virtqueue is used.
> > +*/
> > +   mmsg = vqid << 16;
> > +
> > +   err = mbox_send_message(priv->tx_ch, (void *));
> > +   if (err < 0)
> > +   dev_err(priv->dev, "%s: failed (%d, err:%d)\n",
> > +   __func__, vqid, err);
> > +}
> > +
> >  static const struct rproc_ops imx_rproc_ops = {
> > .start  = imx_rproc_start,
> > .stop   = imx_rproc_stop,
> > +   .kick   = imx_rproc_kick,
> > .da_to_va   = imx_rproc_da_to_va,
> > .load   = rproc_elf_load_segments,
> > .parse_fw   = imx_rproc_parse_fw,
> > @@ -444,6 +477,65 @@ static int imx_rproc_addr_init(struct imx_rproc
> *priv,
> > return 0;
> >  }
> >
> > +static void imx_rproc_vq_work(struct work_struct *work) {
> > +   struct imx_rproc *priv = container_of(work, struct imx_rproc,
> > + rproc_work);
> > +
> > +   rproc_vq_interrupt(priv->rproc, 0);
> > +   rproc_vq_interrupt(priv->rproc, 1);
> > +}
> > +
> > +static void imx_rproc_rx_callback(struct mbox_client *cl, void *msg)
> > +{
> > +   struct rproc *rproc = dev_get_drvdata(cl->dev);
> > +   struct imx_rproc *priv = rproc->priv;
> > +
> > +   queue_work(priv->workqueue, >rproc_work); }
> > +
> > +static int imx_rproc_xtr_mbox_init(struct rproc *rproc) {
> > +   struct imx_rproc *priv = rproc->priv;
> > +   struct device *dev = priv->dev;
> > +   struct mbox_client *cl;
> > +   int ret;
> > +
> > +   if (!of_get_property(dev->of_node, "mbox-names", NULL))
> > +   return 0;
> > +
> > +   cl = >cl;
> > +   cl->dev = dev;
> > +   cl->tx_block = true;
> > +   cl->tx_tout = 100;
> > +   cl->knows_txdone = false;
> > +   cl->rx_callback = imx_rproc_rx_callback;
> > +
> > +   priv->tx_ch = mbox_request_channel_byname(cl, "tx");
> > +   if (IS_ERR(priv->tx_ch)) {
> > +   ret = PTR_ERR(priv->tx_ch);
> > +   return dev_err_probe(cl->dev, PTR_ERR(priv->tx_ch),
> > +

Re: [PATCH V6 10/10] remoteproc: imx_proc: enable virtio/mailbox

2021-01-14 Thread Mathieu Poirier
On Tue, Jan 12, 2021 at 05:39:19PM +0800, peng@nxp.com wrote:
> From: Peng Fan 
> 
> Use virtio/mailbox to build connection between Remote Proccessors
> and Linux. Add work queue to handle incoming messages.
> 
> Reviewed-by: Richard Zhu 
> Signed-off-by: Peng Fan 
> ---
>  drivers/remoteproc/imx_rproc.c | 115 -
>  1 file changed, 112 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index e62a53ee128e..812b077f1282 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -7,6 +7,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  #include 
>  #include 
> @@ -15,6 +16,9 @@
>  #include 
>  #include 
>  #include 
> +#include 
> +
> +#include "remoteproc_internal.h"
>  
>  #define IMX7D_SRC_SCR0x0C
>  #define IMX7D_ENABLE_M4  BIT(3)
> @@ -86,6 +90,11 @@ struct imx_rproc {
>   const struct imx_rproc_dcfg *dcfg;
>   struct imx_rproc_memmem[IMX7D_RPROC_MEM_MAX];
>   struct clk  *clk;
> + struct mbox_client  cl;
> + struct mbox_chan*tx_ch;
> + struct mbox_chan*rx_ch;
> + struct work_struct  rproc_work;
> + struct workqueue_struct *workqueue;
>  };
>  
>  static const struct imx_rproc_att imx_rproc_att_imx8mq[] = {
> @@ -366,9 +375,33 @@ static int imx_rproc_parse_fw(struct rproc *rproc, const 
> struct firmware *fw)
>   return 0;
>  }
>  
> +static void imx_rproc_kick(struct rproc *rproc, int vqid)
> +{
> + struct imx_rproc *priv = rproc->priv;
> + int err;
> + __u32 mmsg;
> +
> + if (!priv->tx_ch) {
> + dev_err(priv->dev, "No initialized mbox tx channel\n");
> + return;
> + }
> +
> + /*
> +  * Send the index of the triggered virtqueue as the mu payload.
> +  * Let remote processor know which virtqueue is used.
> +  */
> + mmsg = vqid << 16;
> +
> + err = mbox_send_message(priv->tx_ch, (void *));
> + if (err < 0)
> + dev_err(priv->dev, "%s: failed (%d, err:%d)\n",
> + __func__, vqid, err);
> +}
> +
>  static const struct rproc_ops imx_rproc_ops = {
>   .start  = imx_rproc_start,
>   .stop   = imx_rproc_stop,
> + .kick   = imx_rproc_kick,
>   .da_to_va   = imx_rproc_da_to_va,
>   .load   = rproc_elf_load_segments,
>   .parse_fw   = imx_rproc_parse_fw,
> @@ -444,6 +477,65 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
>   return 0;
>  }
>  
> +static void imx_rproc_vq_work(struct work_struct *work)
> +{
> + struct imx_rproc *priv = container_of(work, struct imx_rproc,
> +   rproc_work);
> +
> + rproc_vq_interrupt(priv->rproc, 0);
> + rproc_vq_interrupt(priv->rproc, 1);
> +}
> +
> +static void imx_rproc_rx_callback(struct mbox_client *cl, void *msg)
> +{
> + struct rproc *rproc = dev_get_drvdata(cl->dev);
> + struct imx_rproc *priv = rproc->priv;
> +
> + queue_work(priv->workqueue, >rproc_work);
> +}
> +
> +static int imx_rproc_xtr_mbox_init(struct rproc *rproc)
> +{
> + struct imx_rproc *priv = rproc->priv;
> + struct device *dev = priv->dev;
> + struct mbox_client *cl;
> + int ret;
> +
> + if (!of_get_property(dev->of_node, "mbox-names", NULL))
> + return 0;
> +
> + cl = >cl;
> + cl->dev = dev;
> + cl->tx_block = true;
> + cl->tx_tout = 100;
> + cl->knows_txdone = false;
> + cl->rx_callback = imx_rproc_rx_callback;
> +
> + priv->tx_ch = mbox_request_channel_byname(cl, "tx");
> + if (IS_ERR(priv->tx_ch)) {
> + ret = PTR_ERR(priv->tx_ch);
> + return dev_err_probe(cl->dev, PTR_ERR(priv->tx_ch),
> +  "failed to request tx mailbox channel: 
> %d\n", ret);

return dev_err_probe(cl->dev, ret,
 "failed to request tx mailbox channel: 
%d\n", ret);
> + }
> +
> + priv->rx_ch = mbox_request_channel_byname(cl, "rx");
> + if (IS_ERR(priv->rx_ch)) {
> + mbox_free_channel(priv->tx_ch);
> + return dev_err_probe(cl->dev, PTR_ERR(priv->rx_ch),
> +  "failed to request mbox tx chan\n");

ret = PTR_ERR(priv->rx_ch);
return dev_err_probe(cl->dev, ret,
 "failed to request rx mailbox channel: 
%d\n", ret);

> + }
> +
> + return 0;
> +}
> +
> +static void imx_rproc_free_mbox(struct rproc *rproc)
> +{
> + struct imx_rproc *priv = rproc->priv;
> +
> + mbox_free_channel(priv->tx_ch);
> + mbox_free_channel(priv->rx_ch);
> +}
> +
>  static int imx_rproc_probe(struct platform_device *pdev)
>  {
>   struct device *dev = >dev;
> @@ -481,18 +573,28 @@