RE: [PATCH net-next] r8152: fix the wrong return value
David Miller [mailto:da...@davemloft.net] > Sent: Saturday, January 04, 2014 9:38 AM > To: Hayeswang > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-...@vger.kernel.org > Subject: Re: [PATCH net-next] r8152: fix the wrong return value > > From: Hayes Wang > Date: Fri, 3 Jan 2014 11:21:56 +0800 > > > The return value should be the boolean value, not the error code. > > > > Signed-off-by: Hayes Wang > > Spotted-by: Dan Carpenter > > Applied, but I agree with others that it's more canonical to have the > function return either an error code, or zero for success, rather than > a boolean. Thanks. I would find if there is suitable error code. Best Regards, Hayes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH net-next] r8152: fix the wrong return value
David Miller [mailto:da...@davemloft.net] Sent: Saturday, January 04, 2014 9:38 AM To: Hayeswang Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH net-next] r8152: fix the wrong return value From: Hayes Wang hayesw...@realtek.com Date: Fri, 3 Jan 2014 11:21:56 +0800 The return value should be the boolean value, not the error code. Signed-off-by: Hayes Wang hayesw...@realtek.com Spotted-by: Dan Carpenter dan.carpen...@oracle.com Applied, but I agree with others that it's more canonical to have the function return either an error code, or zero for success, rather than a boolean. Thanks. I would find if there is suitable error code. Best Regards, Hayes -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH net-next] r8152: fix the wrong return value
From: Hayes Wang Date: Fri, 3 Jan 2014 11:21:56 +0800 > The return value should be the boolean value, not the error code. > > Signed-off-by: Hayes Wang > Spotted-by: Dan Carpenter Applied, but I agree with others that it's more canonical to have the function return either an error code, or zero for success, rather than a boolean. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH net-next] r8152: fix the wrong return value
From: Hayes Wang hayesw...@realtek.com Date: Fri, 3 Jan 2014 11:21:56 +0800 The return value should be the boolean value, not the error code. Signed-off-by: Hayes Wang hayesw...@realtek.com Spotted-by: Dan Carpenter dan.carpen...@oracle.com Applied, but I agree with others that it's more canonical to have the function return either an error code, or zero for success, rather than a boolean. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH net-next] r8152: fix the wrong return value
On Fri, Jan 03, 2014 at 11:21:56AM +0800, Hayes Wang wrote: > The return value should be the boolean value, not the error code. > > Signed-off-by: Hayes Wang > Spotted-by: Dan Carpenter > --- > drivers/net/usb/r8152.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index e3d878c..13fabbb 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -2708,7 +2708,7 @@ static bool rtl_ops_init(struct r8152 *tp, const struct > usb_device_id *id) > ops->unload = rtl8153_unload; > break; > default: > - ret = -EFAULT; > + ret = false; How about fix the function's return type instead? Returning bool for success/error in Linux kernel is not natural. You gotta check rtl_ops_init() for success and !rtl_ops_init() for error. And you are unable to return the error value. Br, David > break; > } > break; > -- > 1.8.4.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH net-next] r8152: fix the wrong return value
On Fri, Jan 03, 2014 at 11:21:56AM +0800, Hayes Wang wrote: The return value should be the boolean value, not the error code. Signed-off-by: Hayes Wang hayesw...@realtek.com Spotted-by: Dan Carpenter dan.carpen...@oracle.com --- drivers/net/usb/r8152.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index e3d878c..13fabbb 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -2708,7 +2708,7 @@ static bool rtl_ops_init(struct r8152 *tp, const struct usb_device_id *id) ops-unload = rtl8153_unload; break; default: - ret = -EFAULT; + ret = false; How about fix the function's return type instead? Returning bool for success/error in Linux kernel is not natural. You gotta check rtl_ops_init() for success and !rtl_ops_init() for error. And you are unable to return the error value. Br, David break; } break; -- 1.8.4.2 -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
