RE: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool
From: Ilias Apalodimas | Date: Tue, Jul 09, 2019 at 08:23:56 > The patch from Ivan did get merged, can you change the free call to > page_pool_destroy and re-spin? You can add my acked-by Yes, I will re-spin then. Thanks! --- Thanks, Jose Miguel Abreu
Re: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool
Hello, > From: Jose Abreu > Date: Mon, 8 Jul 2019 16:08:07 + > > > From: Ilias Apalodimas | Date: Fri, Jul > > 05, 2019 at 16:24:53 > > > >> Well ideally we'd like to get the change in before the merge window > >> ourselves, > >> since we dont want to remove->re-add the same function in stable kernels. > >> If > >> that doesn't go in i am fine fixing it in the next merge window i guess, > >> since > >> it offers substantial speedups > > > > I think the series is marked as "Changes Requested" in patchwork. What's > > the status of this ? > > That means I expect a respin based upon feedback or similar. If Ilias and > you agreed to put this series in as-is, my apologies and just resend the > series with appropriate ACK and Review tags added. The patch from Ivan did get merged, can you change the free call to page_pool_destroy and re-spin? You can add my acked-by Thanks /Ilias
Re: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool
From: Jose Abreu Date: Mon, 8 Jul 2019 16:08:07 + > From: Ilias Apalodimas | Date: Fri, Jul > 05, 2019 at 16:24:53 > >> Well ideally we'd like to get the change in before the merge window >> ourselves, >> since we dont want to remove->re-add the same function in stable kernels. If >> that doesn't go in i am fine fixing it in the next merge window i guess, >> since >> it offers substantial speedups > > I think the series is marked as "Changes Requested" in patchwork. What's > the status of this ? That means I expect a respin based upon feedback or similar. If Ilias and you agreed to put this series in as-is, my apologies and just resend the series with appropriate ACK and Review tags added. Thanks.
RE: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool
From: Ilias Apalodimas | Date: Fri, Jul 05, 2019 at 16:24:53 > Well ideally we'd like to get the change in before the merge window ourselves, > since we dont want to remove->re-add the same function in stable kernels. If > that doesn't go in i am fine fixing it in the next merge window i guess, since > it offers substantial speedups I think the series is marked as "Changes Requested" in patchwork. What's the status of this ? --- Thanks, Jose Miguel Abreu
Re: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool
Hi Jose, On Fri, Jul 05, 2019 at 03:21:16PM +, Jose Abreu wrote: > From: Ilias Apalodimas > > > I think this look ok for now. One request though, on page_pool_free > > Thanks for the review! > > > A patch currently under review will slightly change that [1] and [2] > > Can you defer this a bit till that one gets merged? > > The only thing you'll have to do is respin this and replace page_pool_free() > > with page_pool_destroy() > > As we are in end of release cycle net-next may close soon so maybe this > can be merged and I can send a follow-up patch later if that's okay by > you and David ? Well ideally we'd like to get the change in before the merge window ourselves, since we dont want to remove->re-add the same function in stable kernels. If that doesn't go in i am fine fixing it in the next merge window i guess, since it offers substantial speedups Thanks /Ilias
RE: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool
From: Ilias Apalodimas > I think this look ok for now. One request though, on page_pool_free Thanks for the review! > A patch currently under review will slightly change that [1] and [2] > Can you defer this a bit till that one gets merged? > The only thing you'll have to do is respin this and replace page_pool_free() > with page_pool_destroy() As we are in end of release cycle net-next may close soon so maybe this can be merged and I can send a follow-up patch later if that's okay by you and David ?
Re: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool
Hi Jose,
I think this look ok for now. One request though, on page_pool_free
On Fri, Jul 05, 2019 at 09:23:00AM +0200, Jose Abreu wrote:
> Mapping and unmapping DMA region is an high bottleneck in stmmac driver,
> specially in the RX path.
>
> This commit introduces support for Page Pool API and uses it in all RX
> queues. With this change, we get more stable troughput and some increase
> of banwidth with iperf:
> - MAC1000 - 950 Mbps
> - XGMAC: 9.22 Gbps
>
> Changes from v2:
> - Uncoditionally call page_pool_free() (Jesper)
> Changes from v1:
> - Use page_pool_get_dma_addr() (Jesper)
> - Add a comment (Jesper)
> - Add page_pool_free() call (Jesper)
> - Reintroduce sync_single_for_device (Arnd / Ilias)
>
> Signed-off-by: Jose Abreu
> Cc: Joao Pinto
> Cc: David S. Miller
> Cc: Giuseppe Cavallaro
> Cc: Alexandre Torgue
> Cc: Ilias Apalodimas
> Cc: Jesper Dangaard Brouer
> Cc: Arnd Bergmann
> ---
> drivers/net/ethernet/stmicro/stmmac/Kconfig | 1 +
> drivers/net/ethernet/stmicro/stmmac/stmmac.h | 10 +-
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 203
> +++---
> 3 files changed, 70 insertions(+), 144 deletions(-)
>
[...]
> @@ -1498,8 +1480,11 @@ static void free_dma_rx_desc_resources(struct
> stmmac_priv *priv)
> sizeof(struct dma_extended_desc),
> rx_q->dma_erx, rx_q->dma_rx_phy);
>
> - kfree(rx_q->rx_skbuff_dma);
> - kfree(rx_q->rx_skbuff);
> + kfree(rx_q->buf_pool);
> + if (rx_q->page_pool) {
> + page_pool_request_shutdown(rx_q->page_pool);
> + page_pool_free(rx_q->page_pool);
A patch currently under review will slightly change that [1] and [2]
Can you defer this a bit till that one gets merged?
The only thing you'll have to do is respin this and replace page_pool_free()
with page_pool_destroy()
[1] https://lore.kernel.org/netdev/20190705094346.13b06da6@carbon/
[2]
https://lore.kernel.org/netdev/156225871578.1603.6630229522953924907.stgit@firesoul/
