RE: [PATCH net-next v5 0/5] net: stmmac: enable EHL SGMI

2019-06-04 Thread Voon, Weifeng
> > This patch-set is to enable Ethernet controller (DW Ethernet QoS and
> > DW Ethernet PCS) with SGMII interface in Elkhart Lake.
> > The DW Ethernet PCS is the Physical Coding Sublayer that is between
> > Ethernet MAC and PHY and uses MDIO Clause-45 as Communication.
> 
> This series look fine to me but unfortunately I don't have my GMAC5.10
> setup available to test for regressions ... The changes look isolated
> though.
> 
> Could you please run the stmmac selftests at least and add the output
> here ?

Sure, the selftests feature is good as I am able to detect that the 
dwmac510_xpcs_ops misses the selftest entry. I will fix and add the
selftests results in the v6 cover letter. 


> 
> Thanks,
> Jose Miguel Abreu


RE: [PATCH net-next v5 0/5] net: stmmac: enable EHL SGMI

2019-06-03 Thread Jose Abreu
From: Voon Weifeng 

> This patch-set is to enable Ethernet controller
> (DW Ethernet QoS and DW Ethernet PCS) with SGMII interface in Elkhart Lake.
> The DW Ethernet PCS is the Physical Coding Sublayer that is between Ethernet
> MAC and PHY and uses MDIO Clause-45 as Communication.

This series look fine to me but unfortunately I don't have my GMAC5.10 
setup available to test for regressions ... The changes look isolated 
though.

Could you please run the stmmac selftests at least and add the output 
here ?

Thanks,
Jose Miguel Abreu