Re: [PATCH v2] ARM: at91/dt: add dts file for sama5d36ek CMP board
On 02/11/16 03:05, Wenyou Yang wrote: The sama5d36ek CMP board is the variant of sama5d3xek board. It is equipped with the low-power DDR2 SDRAM, PMIC ACT8865 and some power rail. Its main purpose is used to measure the power consumption. The difference of the sama5d36ek CMP dts from sama5d36ek dts is listed as below. 1. The USB host nodes are removed, that is, the USB host is disabled. 2. The gpio_keys node is added to wake up from the sleep. 3. The LCD isn't supported due to the pins for LCD are conflicted with gpio_keys. 4. The adc0 node support the pinctrl sleep state to fix the over consumption on VDDANA. As said in errata, "When the USB host ports are used in high speed mode (EHCI), it is not possible to suspend the ports if no device is attached on each port. This leads to increased power consumption even if the system is in a low power mode." That is why the the USB host is disabled. Signed-off-by: Wenyou Yang --- Changes in v2: - Add the pinctrl sleep state for adc0 node to fix the over consumption on VDDANA. - Improve the commit log. arch/arm/boot/dts/sama5d36ek_cmp.dts | 51 +++ arch/arm/boot/dts/sama5d3xcm_cmp.dtsi | 166 + arch/arm/boot/dts/sama5d3xmb_cmp.dtsi | 265 ++ 3 files changed, 482 insertions(+) create mode 100644 arch/arm/boot/dts/sama5d36ek_cmp.dts create mode 100644 arch/arm/boot/dts/sama5d3xcm_cmp.dtsi create mode 100644 arch/arm/boot/dts/sama5d3xmb_cmp.dtsi [...] + /* Conflict with LCD pins */ + gpio_keys { + compatible = "gpio-keys"; + status = "okay"; + + #address-cells = <1>; + #size-cells = <0>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_gpio_keys>; + + pb_user1 { + label = "pb_user1"; + gpios = <&pioE 27 GPIO_ACTIVE_HIGH>; + linux,code = <0x100>; + gpio-key,wakeup; Please replace this with "wakeup-source", I will post patches to fix the new comers in the mainline. It was cleaned last year. -- Regards, Sudeep
Re: [PATCH v2] ARM: at91/dt: add dts file for sama5d36ek CMP board
Le 02/11/2016 à 04:05, Wenyou Yang a écrit : > The sama5d36ek CMP board is the variant of sama5d3xek board. > It is equipped with the low-power DDR2 SDRAM, PMIC ACT8865 and > some power rail. Its main purpose is used to measure the power > consumption. > The difference of the sama5d36ek CMP dts from sama5d36ek dts > is listed as below. > 1. The USB host nodes are removed, that is, the USB host is disabled. > 2. The gpio_keys node is added to wake up from the sleep. > 3. The LCD isn't supported due to the pins for LCD are conflicted > with gpio_keys. > 4. The adc0 node support the pinctrl sleep state to fix the over > consumption on VDDANA. > > As said in errata, "When the USB host ports are used in high speed > mode (EHCI), it is not possible to suspend the ports if no device is > attached on each port. This leads to increased power consumption even > if the system is in a low power mode." That is why the the USB host > is disabled. > > Signed-off-by: Wenyou Yang > --- > > Changes in v2: > - Add the pinctrl sleep state for adc0 node to fix the over >consumption on VDDANA. > - Improve the commit log. > > arch/arm/boot/dts/sama5d36ek_cmp.dts | 51 +++ > arch/arm/boot/dts/sama5d3xcm_cmp.dtsi | 166 + > arch/arm/boot/dts/sama5d3xmb_cmp.dtsi | 265 > ++ > 3 files changed, 482 insertions(+) > create mode 100644 arch/arm/boot/dts/sama5d36ek_cmp.dts > create mode 100644 arch/arm/boot/dts/sama5d3xcm_cmp.dtsi > create mode 100644 arch/arm/boot/dts/sama5d3xmb_cmp.dtsi > > diff --git a/arch/arm/boot/dts/sama5d36ek_cmp.dts > b/arch/arm/boot/dts/sama5d36ek_cmp.dts > new file mode 100644 > index 000..fd6bcd6 > --- /dev/null > +++ b/arch/arm/boot/dts/sama5d36ek_cmp.dts > @@ -0,0 +1,51 @@ > +/* > + * sama5d36ek_cmp.dts - Device Tree file for SAMA5D36-EK CMP board > + * > + * Copyright (C) 2016 Atmel, > + * > + * Licensed under GPLv2 or later. No, in fact we now use a dual license scheme for DT files. Please have a look at the recent board that we posted to take the header from them. > + */ > +/dts-v1/; > +#include "sama5d36.dtsi" > +#include "sama5d3xmb_cmp.dtsi" > + > +/ { > + model = "Atmel SAMA5D36-EK"; > + compatible = "atmel,sama5d36ek", "atmel,sama5d3xmb", > "atmel,sama5d3xcm", "atmel,sama5d36", "atmel,sama5d3", "atmel,sama5"; I don't think the model name nor the compatible string reflect the nature of this new "CMP" board. > + > + ahb { > + apb { > + spi0: spi@f0004000 { > + status = "okay"; > + }; > + > + ssc0: ssc@f0008000 { > + status = "okay"; > + }; > + > + can0: can@f000c000 { > + status = "okay"; > + }; > + > + i2c0: i2c@f0014000 { > + status = "okay"; > + }; > + > + i2c1: i2c@f0018000 { > + status = "okay"; > + }; > + > + macb0: ethernet@f0028000 { > + status = "okay"; > + }; > + > + macb1: ethernet@f802c000 { > + status = "okay"; > + }; > + }; > + }; > + > + sound { > + status = "okay"; > + }; > +}; > diff --git a/arch/arm/boot/dts/sama5d3xcm_cmp.dtsi > b/arch/arm/boot/dts/sama5d3xcm_cmp.dtsi > new file mode 100644 > index 000..77638c3 > --- /dev/null > +++ b/arch/arm/boot/dts/sama5d3xcm_cmp.dtsi > @@ -0,0 +1,166 @@ > +/* > + * sama5d3xcm_cmp.dtsi - Device Tree Include file for SAMA5D36 CMP CPU Module > + * > + * Copyright (C) 2016 Atmel, > + * > + * Licensed under GPLv2 or later. Ditto. > + */ > + > +/ { > + compatible = "atmel,sama5d3xcm", "atmel,sama5d3", "atmel,sama5"; Ditto. > + > + chosen { > + bootargs = "rootfstype=ubifs ubi.mtd=5 root=ubi0:rootfs"; Remove bootargs. > + stdout-path = "serial0:115200n8"; > + }; > + > + memory { > + reg = <0x2000 0x2000>; > + }; > + > + clocks { > + slow_xtal { > + clock-frequency = <32768>; > + }; > + > + main_xtal { > + clock-frequency = <1200>; > + }; > + }; > + > + ahb { > + apb { > + spi0: spi@f0004000 { > + cs-gpios = <&pioD 13 0>, <0>, <0>, <0>; > + }; > + > + macb0: ethernet@f0028000 { > + phy-mode = "rgmii"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet-phy@1 { > + reg = <0x1>; > +
RE: [PATCH v2] ARM: at91/dt: add dts file for sama5d36ek CMP board
> -Original Message- > From: kbuild test robot [mailto:l...@intel.com] > Sent: 2016年11月2日 13:28 > To: Wenyou Yang - A41535 > Cc: kbuild-...@01.org; Nicolas Ferre ; Alexandre > Belloni ; Russell King > ; Rob Herring ; Pawel Moll > ; Mark Rutland ; Ian Campbell > ; Kumar Gala ; linux- > ker...@vger.kernel.org; Wenyou Yang - A41535 > ; devicet...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; Wenyou Yang - A41535 > > Subject: Re: [PATCH v2] ARM: at91/dt: add dts file for sama5d36ek CMP board > > Hi Wenyou, > > [auto build test ERROR on at91/at91-next] [also build test ERROR on v4.9-rc3 > next-20161028] [if your patch is applied to the wrong git tree, please drop > us a > note to help improve the system] > > url:https://github.com/0day-ci/linux/commits/Wenyou-Yang/ARM-at91-dt-add- > dts-file-for-sama5d36ek-CMP-board/20161102-52 > base: https://git.kernel.org/pub/scm/linux/kernel/git/nferre/linux-at91.git > at91- > next > config: arm-at91_dt_defconfig (attached as .config) > compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp- > tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm > > All errors (new ones prefixed by >>): > > >> Error: arch/arm/boot/dts/sama5d3xmb_cmp.dtsi:143.17-18 syntax error >FATAL ERROR: Unable to parse input tree Oh, this patch is based on the patch I sent before. [PATCH] pinctrl: at91: add support for OUTPUT config http://lists.infradead.org/pipermail/linux-arm-kernel/2016-October/464354.html I forgot adding this information. Sorry. Best Regards, Wenyou Yang
Re: [PATCH v2] ARM: at91/dt: add dts file for sama5d36ek CMP board
Hi Wenyou, [auto build test ERROR on at91/at91-next] [also build test ERROR on v4.9-rc3 next-20161028] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Wenyou-Yang/ARM-at91-dt-add-dts-file-for-sama5d36ek-CMP-board/20161102-52 base: https://git.kernel.org/pub/scm/linux/kernel/git/nferre/linux-at91.git at91-next config: arm-at91_dt_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm All errors (new ones prefixed by >>): >> Error: arch/arm/boot/dts/sama5d3xmb_cmp.dtsi:143.17-18 syntax error FATAL ERROR: Unable to parse input tree --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip