RE: [EXT] Re: [PATCH v2] usb: dwc3: enable otg mode for dwc3 usb ip on layerscape

2019-10-14 Thread Yinbo Zhu 


-Original Message-
From: Shawn Guo  
Sent: 2019年10月14日 14:52
To: Yinbo Zhu 
Cc: Leo Li ; Rob Herring ; Mark Rutland 
; Xiaobo Xie ; Jiafei Pan 
; Ran Wang ; 
linux-arm-ker...@lists.infradead.org; devicet...@vger.kernel.org; 
linux-kernel@vger.kernel.org
Subject: [EXT] Re: [PATCH v2] usb: dwc3: enable otg mode for dwc3 usb ip on 
layerscape

Caution: EXT Email

On Tue, Sep 24, 2019 at 11:29:03AM +0800, Yinbo Zhu wrote:
> layerscape otg function should be supported HNP SRP and ADP protocol 
> accroing to rm doc, but dwc3 code not realize it and use id pin to 
> detect who is host or device(0 is host 1 is device) this patch is to 
> enable OTG mode on ls1028ardb ls1088ardb and ls1046ardb in dts
>
> Signed-off-by: Yinbo Zhu 
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 4   
> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 4   
> arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 1 +

> this is an arm64 DTS patch, so the patch prefix should be something like 
> 'arm64 dts: fsl: ...'

> Shawn 
Hi Shawn guo,

This patch I had updated to v3, please check that v3 version.

Regards,
Yinbo Zhu.
>  3 files changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> index 9fb9113..076cac6 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> @@ -171,3 +171,7 @@
>   {
>   status = "okay";
>  };
> +
> + {
> + dr_mode = "otg";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> index 6a6514d..0c742be 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> @@ -122,6 +122,10 @@
>   };
>  };
>
> + {
> + dr_mode = "otg";
> +};
> +
>  #include "fsl-ls1046-post.dtsi"
>
>   {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> index 8e925df..90b1989 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> @@ -95,5 +95,6 @@
>  };
>
>   {
> + dr_mode = "otg";
>   status = "okay";
>  };
> --
> 2.9.5
>

Re: [PATCH v2] usb: dwc3: enable otg mode for dwc3 usb ip on layerscape

2019-10-14 Thread Shawn Guo 
On Tue, Sep 24, 2019 at 11:29:03AM +0800, Yinbo Zhu wrote:
> layerscape otg function should be supported HNP SRP and ADP protocol
> accroing to rm doc, but dwc3 code not realize it and use id pin to
> detect who is host or device(0 is host 1 is device) this patch is to
> enable OTG mode on ls1028ardb ls1088ardb and ls1046ardb in dts
> 
> Signed-off-by: Yinbo Zhu 
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 4 
>  arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 4 
>  arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 1 +

This is an arm64 DTS patch, so the patch prefix should be something
like 'arm64 dts: fsl: ...'

Shawn

>  3 files changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> index 9fb9113..076cac6 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> @@ -171,3 +171,7 @@
>   {
>   status = "okay";
>  };
> +
> + {
> + dr_mode = "otg";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> index 6a6514d..0c742be 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> @@ -122,6 +122,10 @@
>   };
>  };
>  
> + {
> + dr_mode = "otg";
> +};
> +
>  #include "fsl-ls1046-post.dtsi"
>  
>   {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> index 8e925df..90b1989 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> @@ -95,5 +95,6 @@
>  };
>  
>   {
> + dr_mode = "otg";
>   status = "okay";
>  };
> -- 
> 2.9.5
>

RE: [PATCH v2] usb: dwc3: enable otg mode for dwc3 usb ip on layerscape

2019-09-23 Thread Yinbo Zhu 
Hi,

Change in v2:
move the otg property from dtsi to dts.

Regards,
Yinbo Zhu.

-Original Message-
From: Yinbo Zhu  
Sent: 2019年9月24日 11:29
To: Shawn Guo ; Leo Li ; Rob Herring 
; Mark Rutland 
Cc: Yinbo Zhu ; Xiaobo Xie ; Jiafei Pan 
; Ran Wang ; 
linux-arm-ker...@lists.infradead.org; devicet...@vger.kernel.org; 
linux-kernel@vger.kernel.org
Subject: [PATCH v2] usb: dwc3: enable otg mode for dwc3 usb ip on layerscape

layerscape otg function should be supported HNP SRP and ADP protocol accroing 
to rm doc, but dwc3 code not realize it and use id pin to detect who is host or 
device(0 is host 1 is device) this patch is to enable OTG mode on ls1028ardb 
ls1088ardb and ls1046ardb in dts

Signed-off-by: Yinbo Zhu 
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 4   
arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 4   
arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 1 +
 3 files changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts 
b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
index 9fb9113..076cac6 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
@@ -171,3 +171,7 @@
  {
status = "okay";
 };
+
+ {
+   dr_mode = "otg";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts 
b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
index 6a6514d..0c742be 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
@@ -122,6 +122,10 @@
};
 };
 
+ {
+   dr_mode = "otg";
+};
+
 #include "fsl-ls1046-post.dtsi"
 
  {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts 
b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
index 8e925df..90b1989 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
@@ -95,5 +95,6 @@
 };
 
  {
+   dr_mode = "otg";
status = "okay";
 };
--
2.9.5