Re: [PATCH v2 1/5] mfd/rtc: s5m: Fix register updating by adding regmap for RTC

[Lee Jones]

On Thu, 28 Nov 2013, Krzysztof Kozlowski wrote:

> Rename old regmap field of "struct sec_pmic_dev" to "regmap_pmic" and
> add new regmap for RTC.
> 
> On S5M8767A registers were not properly updated and read due to usage of
> the same regmap as the PMIC. This could be observed in various hangs,
> e.g. in infinite loop during waiting for UDR field change.
> 
> On this chip family the RTC has different I2C address than PMIC so
> additional regmap is needed.
> 
> Signed-off-by: Krzysztof Kozlowski 
> Signed-off-by: Kyungmin Park 
> ---
>  drivers/mfd/sec-core.c   |   30 ++
>  drivers/mfd/sec-irq.c|6 +++---
>  drivers/regulator/s5m8767.c  |2 +-
>  drivers/rtc/rtc-s5m.c|2 +-
>  include/linux/mfd/samsung/core.h |3 ++-
>  5 files changed, 29 insertions(+), 14 deletions(-)

The MFD parts look fine to me. I just need the Acks from the other
maintainers before I can apply it:

Acked-by: Lee Jones 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH v2 1/5] mfd/rtc: s5m: Fix register updating by adding regmap for RTC

[Sangbeom Kim]

On Thursday, November 28, 2013 10:51 PM, Mark Brown wrote:
> > On S5M8767A registers were not properly updated and read due to usage
> > of the same regmap as the PMIC. This could be observed in various
> > hangs, e.g. in infinite loop during waiting for UDR field change.
> 
> Reviwed-by: Mark Brown 

Acked-by: Sangbeom Kim 

Thanks,
Sangbeom.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 1/5] mfd/rtc: s5m: Fix register updating by adding regmap for RTC

[Mark Brown]

On Thu, Nov 28, 2013 at 09:09:39AM +0100, Krzysztof Kozlowski wrote:
> Rename old regmap field of "struct sec_pmic_dev" to "regmap_pmic" and
> add new regmap for RTC.
> 
> On S5M8767A registers were not properly updated and read due to usage of
> the same regmap as the PMIC. This could be observed in various hangs,
> e.g. in infinite loop during waiting for UDR field change.

Reviwed-by: Mark Brown 


signature.asc
Description: Digital signature