RE: [PATCH v2 net-next 1/2] r8169: enable ALDPS for power saving

2012-10-23 Thread hayeswang 
 Francois Romieu [mailto:rom...@fr.zoreil.com] 
[...]
> > +static void r810x_aldps_disable(struct rtl8169_private *tp)
> > +{
> > +   rtl_writephy(tp, 0x1f, 0x);
> > +   rtl_writephy(tp, 0x18, 0x0310);
> > +   msleep(100);
> > +}
> 
> rtl8402_hw_phy_config used a msleep(20). Meguesses it won't 
> hurt, right ?

No, it won't hurt. The delay make suer there is enough time to pause ALDPS.
 
Best Regards,
Hayes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 net-next 1/2] r8169: enable ALDPS for power saving

2012-10-23 Thread Francois Romieu 
Hayes Wang  :
> Enable ALDPS function to save power when link down. Note that the
> feature should be set after the other PHY settings. And the firmware
> is necessary. Don't enable it without loading the firmware.
> 
> Signed-off-by: Hayes Wang 
[...]

Please see my just sent answer in yesterday's thread.

> +static void r810x_aldps_disable(struct rtl8169_private *tp)
> +{
> + rtl_writephy(tp, 0x1f, 0x);
> + rtl_writephy(tp, 0x18, 0x0310);
> + msleep(100);
> +}

rtl8402_hw_phy_config used a msleep(20). Meguesses it won't hurt, right ?

[...]
> +
> + /* ALDPS enable */
> + r8168_aldps_enable_1(tp);

The functions are literate enough: you can remove the comment.

[...]
> @@ -6391,6 +6431,8 @@ static void rtl8169_net_suspend(struct net_device *dev)
>  {
>   struct rtl8169_private *tp = netdev_priv(dev);
>  
> + tp->features &= ~RTL_FEATURE_EXTENDED;
> +
>   if (!netif_running(dev))
>   return;

No (as previously stated).

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/