Re: [PATCH v3 3/3] megaraid_sas : fix whitespace errors

2015-08-26 Thread James Bottomley
On Tue, 2015-07-07 at 15:52 -0500, Bjorn Helgaas wrote:
> Fix whitespace and indentation errors.  No code change.

checkpatch says you missed one:

ERROR: space required after that ',' (ctx:VxV)
#860: FILE: drivers/scsi/megaraid/megaraid_sas_base.c:6457:
+   if (sscanf(buf,"%u",&megasas_dbg_lvl) < 1) {
  ^

ERROR: space required after that ',' (ctx:VxO)
#860: FILE: drivers/scsi/megaraid/megaraid_sas_base.c:6457:
+   if (sscanf(buf,"%u",&megasas_dbg_lvl) < 1) {
   ^

ERROR: space required before that '&' (ctx:OxV)
#860: FILE: drivers/scsi/megaraid/megaraid_sas_base.c:6457:
+   if (sscanf(buf,"%u",&megasas_dbg_lvl) < 1) {


I fixed it up

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH v3 3/3] megaraid_sas : fix whitespace errors

2015-07-08 Thread Hannes Reinecke
On 07/07/2015 10:52 PM, Bjorn Helgaas wrote:
> Fix whitespace and indentation errors.  No code change.
> 
> Signed-off-by: Bjorn Helgaas 
> ---
>  drivers/scsi/megaraid/megaraid_sas_base.c |  244 
> ++---
>  1 file changed, 118 insertions(+), 126 deletions(-)
> 
Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
-- 
Dr. Hannes ReineckezSeries & Storage
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: [PATCH v3 3/3] megaraid_sas : fix whitespace errors

2015-07-08 Thread Sumit Saxena
> -Original Message-
> From: Bjorn Helgaas [mailto:bhelg...@google.com]
> Sent: Wednesday, July 08, 2015 2:23 AM
> To: Kashyap Desai; Uday Lingala; Sumit Saxena
> Cc: megaraidlinux@avagotech.com; linux-s...@vger.kernel.org; James
> E.J.
> Bottomley; linux-kernel@vger.kernel.org; Joe Perches; Christoph Hellwig
> Subject: [PATCH v3 3/3] megaraid_sas : fix whitespace errors
>
> Fix whitespace and indentation errors.  No code change.
>
> Signed-off-by: Bjorn Helgaas 
> ---
>  drivers/scsi/megaraid/megaraid_sas_base.c |  244
> ++--
> -
>  1 file changed, 118 insertions(+), 126 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megaraid_sas_base.c
> index a9bd592..5156faa 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -273,6 +273,7 @@ static inline void
>  megasas_enable_intr_xscale(struct megasas_instance *instance)  {
>   struct megasas_register_set __iomem *regs;
> +
>   regs = instance->reg_set;
>   writel(0, &(regs)->outbound_intr_mask);
>
> @@ -289,6 +290,7 @@ megasas_disable_intr_xscale(struct megasas_instance
> *instance)  {
>   struct megasas_register_set __iomem *regs;
>   u32 mask = 0x1f;
> +
>   regs = instance->reg_set;
>   writel(mask, ®s->outbound_intr_mask);
>   /* Dummy readl to force pci flush */
> @@ -313,6 +315,7 @@ megasas_clear_intr_xscale(struct megasas_register_set
> __iomem * regs)  {
>   u32 status;
>   u32 mfiStatus = 0;
> +
>   /*
>* Check if it is our interrupt
>*/
> @@ -348,6 +351,7 @@ megasas_fire_cmd_xscale(struct megasas_instance
> *instance,
>   struct megasas_register_set __iomem *regs)  {
>   unsigned long flags;
> +
>   spin_lock_irqsave(&instance->hba_lock, flags);
>   writel((frame_phys_addr >> 3)|(frame_count),
>  &(regs)->inbound_queue_port);
> @@ -364,6 +368,7 @@ megasas_adp_reset_xscale(struct megasas_instance
> *instance,  {
>   u32 i;
>   u32 pcidata;
> +
>   writel(MFI_ADP_RESET, ®s->inbound_doorbell);
>
>   for (i = 0; i < 3; i++)
> @@ -402,7 +407,6 @@ static int
>  megasas_check_reset_xscale(struct megasas_instance *instance,
>   struct megasas_register_set __iomem *regs)  {
> -
>   if ((instance->adprecovery != MEGASAS_HBA_OPERATIONAL) &&
>   (le32_to_cpu(*instance->consumer) ==
>   MEGASAS_ADPRESET_INPROG_SIGN))
> @@ -433,7 +437,7 @@ static struct megasas_instance_template
> megasas_instance_template_xscale = {
>
>  /**
>  *The following functions are defined for ppc (deviceid : 0x60)
> -*controllers
> +*controllers
>  */
>
>  /**
> @@ -444,6 +448,7 @@ static inline void
>  megasas_enable_intr_ppc(struct megasas_instance *instance)  {
>   struct megasas_register_set __iomem *regs;
> +
>   regs = instance->reg_set;
>   writel(0x, &(regs)->outbound_doorbell_clear);
>
> @@ -462,6 +467,7 @@ megasas_disable_intr_ppc(struct megasas_instance
> *instance)  {
>   struct megasas_register_set __iomem *regs;
>   u32 mask = 0x;
> +
>   regs = instance->reg_set;
>   writel(mask, ®s->outbound_intr_mask);
>   /* Dummy readl to force pci flush */
> @@ -522,6 +528,7 @@ megasas_fire_cmd_ppc(struct megasas_instance
> *instance,
>   struct megasas_register_set __iomem *regs)  {
>   unsigned long flags;
> +
>   spin_lock_irqsave(&instance->hba_lock, flags);
>   writel((frame_phys_addr | (frame_count<<1))|1,
>   &(regs)->inbound_queue_port);
> @@ -566,6 +573,7 @@ static inline void
>  megasas_enable_intr_skinny(struct megasas_instance *instance)  {
>   struct megasas_register_set __iomem *regs;
> +
>   regs = instance->reg_set;
>   writel(0x, &(regs)->outbound_intr_mask);
>
> @@ -584,6 +592,7 @@ megasas_disable_intr_skinny(struct megasas_instance
> *instance)  {
>   struct megasas_register_set __iomem *regs;
>   u32 mask = 0x;
> +
>   regs = instance->reg_set;
>   writel(mask, ®s->outbound_intr_mask);
>   /* Dummy readl to force pci flush */
> @@ -634,8 +643,8 @@ megasas_clear_intr_skinny(struct megasas_register_set
> __iomem *regs)
>   writel(status, ®s->outbound_intr_status);
>
>   /*
> - * dummy read to flush PCI
> - */
> +  * dummy read to flush PCI
> +  */
>   readl(®s->outbound_intr_status);
>
>   return mfiStatus;
> @@ -654,6 +663,7 @@ megasas_fire_cmd_skinny(struct megasas_instance
> *instance,
>   struct megasas_register_set __iomem *regs)  {
>   unsigned long flags;
> +
>   spin_lock_irqsave(&instance->hba_lock, flags);
>   writel(upper_32_bits(frame_phys_addr),
>  &(regs)->inbound_high_queue_port);
> @@ -706,6 +716,7 @@ static inline void
>  megasas_enable_intr_gen2(struct megasas_instance *instance)  {
>   struct megasas_register_set __iomem *regs;
> +
>