Re: [PATCH v4 08/14] dt: qcom: Add opp and thermal to the msm8996
On 04-05-18, 09:48, ilia...@codeaurora.org wrote: > Kryo has single clock per cluster. I define here a shared OPP table per > cluster. Thanks for clarifying. -- viresh
RE: [PATCH v4 08/14] dt: qcom: Add opp and thermal to the msm8996
Kryo has single clock per cluster. I define here a shared OPP table per cluster.
> -Original Message-
> From: Viresh Kumar
> Sent: Friday, May 4, 2018 09:04
> To: Ilia Lin
> Cc: Michael Turquette ; Stephen Boyd
> ; Rob Herring ; Mark Rutland
> ; Rafael J. Wysocki ; Liam
> Girdwood ; Mark Brown ;
> Andy Gross ; David Brown
> ; Catalin Marinas ; Will
> Deacon ; Linux Clock List c...@vger.kernel.org>; devicet...@vger.kernel.org; Linux Kernel Mailing List
> ; linux...@vger.kernel.org; linux-arm-
> m...@vger.kernel.org; open list:ARM/QUALCOMM SUPPORT s...@vger.kernel.org>; linux-arm-ker...@lists.infradead.org; Nayak,
> Rajendra ; Amit Kucheria
> ; Nicolas Dechesne
> ; cels...@codeaurora.org;
> tfin...@codeaurora.org
> Subject: Re: [PATCH v4 08/14] dt: qcom: Add opp and thermal to the
> msm8996
>
> On 2 April 2018 at 14:46, Viresh Kumar wrote:
>
> >> + cluster0_opp: opp_table0 {
> >> + compatible = "operating-points-v2";
> >> + opp-shared;
> >
> > Is Kryo like krait where CPUs do DVFS independently ? If yes, then
> > opp-shared thing should be dropped.
>
> Have you ever replied to this question ? Sorry, but I am not able to find it
> in
> my inbox :(
Re: [PATCH v4 08/14] dt: qcom: Add opp and thermal to the msm8996
On 2 April 2018 at 14:46, Viresh Kumar wrote:
>> + cluster0_opp: opp_table0 {
>> + compatible = "operating-points-v2";
>> + opp-shared;
>
> Is Kryo like krait where CPUs do DVFS independently ? If yes, then opp-shared
> thing should be dropped.
Have you ever replied to this question ? Sorry, but I am not able to
find it in my inbox :(
Re: [PATCH v4 08/14] dt: qcom: Add opp and thermal to the msm8996
On 30-03-18, 00:26, Ilia Lin wrote:
> Signed-off-by: Ilia Lin
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 275
> +-
> 1 file changed, 267 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 410ae78..a0792bd 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -14,6 +14,7 @@
> #include
> #include
> #include
> +#include
>
> / {
> model = "Qualcomm Technologies, Inc. MSM8996";
> @@ -97,6 +98,11 @@
> compatible = "qcom,kryo";
> reg = <0x0 0x0>;
> enable-method = "psci";
> + clocks = <&kryocc 0>;
> + operating-points-v2 = <&cluster0_opp>;
> + cooling-min-level = <0>;
> + cooling-max-level = <15>;
The min/max properties are removed from DT documentation now. You don't need to
add them anymore.
> + cluster0_opp: opp_table0 {
> + compatible = "operating-points-v2";
> + opp-shared;
Is Kryo like krait where CPUs do DVFS independently ? If yes, then opp-shared
thing should be dropped.
> +
> + opp-30720 {
> + opp-hz = /bits/ 64 < 30720 >;
Why have you added spaces after < and before > here ?
--
viresh
