Re: [PATCH v9 3/4] doc: bindings: mfd: act8945a: Update the example

[Lee Jones]

On Thu, 01 Sep 2016, wenyou.y...@microchip.com wrote:

> 
> 
> > -Original Message-
> > From: Sebastian Reichel [mailto:s...@kernel.org]
> > Sent: 2016年9月1日 20:48
> > To: Lee Jones <lee.jo...@linaro.org>
> > Cc: Wenyou Yang - A41535 <wenyou.y...@microchip.com>; Dmitry Eremin-
> > Solenikov <dbarysh...@gmail.com>; David Woodhouse
> > <dw...@infradead.org>; Rob Herring <robh...@kernel.org>; Pawel Moll
> > <pawel.m...@arm.com>; Mark Rutland <mark.rutl...@arm.com>; Ian Campbell
> > <ijc+devicet...@hellion.org.uk>; Kumar Gala <ga...@codeaurora.org>; Nicolas
> > Ferre <nicolas.fe...@atmel.com>; Alexandre Belloni <alexandre.belloni@free-
> > electrons.com>; linux-kernel@vger.kernel.org; Wenyou Yang - A41535
> > <wenyou.y...@microchip.com>; devicet...@vger.kernel.org; linux-arm-
> > ker...@lists.infradead.org; linux...@vger.kernel.org
> > Subject: Re: [PATCH v9 3/4] doc: bindings: mfd: act8945a: Update the example
> > 
> > Hi Lee,
> > 
> > On Thu, Sep 01, 2016 at 12:22:51PM +0100, Lee Jones wrote:
> > > On Thu, 01 Sep 2016, Wenyou Yang wrote:
> > >
> > > > Since the act8945a-charger is regarded as a sub-device and it using
> > > > "interrupts" property, update the examples section.
> > > >
> > > > Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com>
> > > > ---
> > > >
> > > > Changes in v9: None
> > > > Changes in v8: None
> > > > Changes in v7: None
> > > > Changes in v6: None
> > > > Changes in v4: None
> > > >
> > > >  Documentation/devicetree/bindings/mfd/act8945a.txt | 22
> > > > +++---
> > > >  1 file changed, 15 insertions(+), 7 deletions(-)
> > >
> > > This is a functional change.  I'll require a DT Ack.
> > 
> > Wenyou Yang forgot to take over Rob's Acked-By from the previous
> > version: https://patchwork.kernel.org/patch/9298871/
> 
> Yes, sorry. I forgot.

Very well.

Applied, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v9 3/4] doc: bindings: mfd: act8945a: Update the example

[Lee Jones]

On Thu, 01 Sep 2016, wenyou.y...@microchip.com wrote:

> 
> 
> > -Original Message-
> > From: Sebastian Reichel [mailto:s...@kernel.org]
> > Sent: 2016年9月1日 20:48
> > To: Lee Jones 
> > Cc: Wenyou Yang - A41535 ; Dmitry Eremin-
> > Solenikov ; David Woodhouse
> > ; Rob Herring ; Pawel Moll
> > ; Mark Rutland ; Ian Campbell
> > ; Kumar Gala ; Nicolas
> > Ferre ; Alexandre Belloni  > electrons.com>; linux-kernel@vger.kernel.org; Wenyou Yang - A41535
> > ; devicet...@vger.kernel.org; linux-arm-
> > ker...@lists.infradead.org; linux...@vger.kernel.org
> > Subject: Re: [PATCH v9 3/4] doc: bindings: mfd: act8945a: Update the example
> > 
> > Hi Lee,
> > 
> > On Thu, Sep 01, 2016 at 12:22:51PM +0100, Lee Jones wrote:
> > > On Thu, 01 Sep 2016, Wenyou Yang wrote:
> > >
> > > > Since the act8945a-charger is regarded as a sub-device and it using
> > > > "interrupts" property, update the examples section.
> > > >
> > > > Signed-off-by: Wenyou Yang 
> > > > ---
> > > >
> > > > Changes in v9: None
> > > > Changes in v8: None
> > > > Changes in v7: None
> > > > Changes in v6: None
> > > > Changes in v4: None
> > > >
> > > >  Documentation/devicetree/bindings/mfd/act8945a.txt | 22
> > > > +++---
> > > >  1 file changed, 15 insertions(+), 7 deletions(-)
> > >
> > > This is a functional change.  I'll require a DT Ack.
> > 
> > Wenyou Yang forgot to take over Rob's Acked-By from the previous
> > version: https://patchwork.kernel.org/patch/9298871/
> 
> Yes, sorry. I forgot.

Very well.

Applied, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

RE: [PATCH v9 3/4] doc: bindings: mfd: act8945a: Update the example

[Wenyou.Yang]

> -Original Message-
> From: Sebastian Reichel [mailto:s...@kernel.org]
> Sent: 2016年9月1日 20:48
> To: Lee Jones <lee.jo...@linaro.org>
> Cc: Wenyou Yang - A41535 <wenyou.y...@microchip.com>; Dmitry Eremin-
> Solenikov <dbarysh...@gmail.com>; David Woodhouse
> <dw...@infradead.org>; Rob Herring <robh...@kernel.org>; Pawel Moll
> <pawel.m...@arm.com>; Mark Rutland <mark.rutl...@arm.com>; Ian Campbell
> <ijc+devicet...@hellion.org.uk>; Kumar Gala <ga...@codeaurora.org>; Nicolas
> Ferre <nicolas.fe...@atmel.com>; Alexandre Belloni <alexandre.belloni@free-
> electrons.com>; linux-kernel@vger.kernel.org; Wenyou Yang - A41535
> <wenyou.y...@microchip.com>; devicet...@vger.kernel.org; linux-arm-
> ker...@lists.infradead.org; linux...@vger.kernel.org
> Subject: Re: [PATCH v9 3/4] doc: bindings: mfd: act8945a: Update the example
> 
> Hi Lee,
> 
> On Thu, Sep 01, 2016 at 12:22:51PM +0100, Lee Jones wrote:
> > On Thu, 01 Sep 2016, Wenyou Yang wrote:
> >
> > > Since the act8945a-charger is regarded as a sub-device and it using
> > > "interrupts" property, update the examples section.
> > >
> > > Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com>
> > > ---
> > >
> > > Changes in v9: None
> > > Changes in v8: None
> > > Changes in v7: None
> > > Changes in v6: None
> > > Changes in v4: None
> > >
> > >  Documentation/devicetree/bindings/mfd/act8945a.txt | 22
> > > +++---
> > >  1 file changed, 15 insertions(+), 7 deletions(-)
> >
> > This is a functional change.  I'll require a DT Ack.
> 
> Wenyou Yang forgot to take over Rob's Acked-By from the previous
> version: https://patchwork.kernel.org/patch/9298871/

Yes, sorry. I forgot.


Best Regards,
Wenyou Yang

RE: [PATCH v9 3/4] doc: bindings: mfd: act8945a: Update the example

[Wenyou.Yang]

> -Original Message-
> From: Sebastian Reichel [mailto:s...@kernel.org]
> Sent: 2016年9月1日 20:48
> To: Lee Jones 
> Cc: Wenyou Yang - A41535 ; Dmitry Eremin-
> Solenikov ; David Woodhouse
> ; Rob Herring ; Pawel Moll
> ; Mark Rutland ; Ian Campbell
> ; Kumar Gala ; Nicolas
> Ferre ; Alexandre Belloni  electrons.com>; linux-kernel@vger.kernel.org; Wenyou Yang - A41535
> ; devicet...@vger.kernel.org; linux-arm-
> ker...@lists.infradead.org; linux...@vger.kernel.org
> Subject: Re: [PATCH v9 3/4] doc: bindings: mfd: act8945a: Update the example
> 
> Hi Lee,
> 
> On Thu, Sep 01, 2016 at 12:22:51PM +0100, Lee Jones wrote:
> > On Thu, 01 Sep 2016, Wenyou Yang wrote:
> >
> > > Since the act8945a-charger is regarded as a sub-device and it using
> > > "interrupts" property, update the examples section.
> > >
> > > Signed-off-by: Wenyou Yang 
> > > ---
> > >
> > > Changes in v9: None
> > > Changes in v8: None
> > > Changes in v7: None
> > > Changes in v6: None
> > > Changes in v4: None
> > >
> > >  Documentation/devicetree/bindings/mfd/act8945a.txt | 22
> > > +++---
> > >  1 file changed, 15 insertions(+), 7 deletions(-)
> >
> > This is a functional change.  I'll require a DT Ack.
> 
> Wenyou Yang forgot to take over Rob's Acked-By from the previous
> version: https://patchwork.kernel.org/patch/9298871/

Yes, sorry. I forgot.


Best Regards,
Wenyou Yang

Re: [PATCH v9 3/4] doc: bindings: mfd: act8945a: Update the example

[Sebastian Reichel]

Hi Lee,

On Thu, Sep 01, 2016 at 12:22:51PM +0100, Lee Jones wrote:
> On Thu, 01 Sep 2016, Wenyou Yang wrote:
> 
> > Since the act8945a-charger is regarded as a sub-device and it using
> > "interrupts" property, update the examples section.
> > 
> > Signed-off-by: Wenyou Yang 
> > ---
> > 
> > Changes in v9: None
> > Changes in v8: None
> > Changes in v7: None
> > Changes in v6: None
> > Changes in v4: None
> > 
> >  Documentation/devicetree/bindings/mfd/act8945a.txt | 22 
> > +++---
> >  1 file changed, 15 insertions(+), 7 deletions(-)
> 
> This is a functional change.  I'll require a DT Ack.

Wenyou Yang forgot to take over Rob's Acked-By from the previous
version: https://patchwork.kernel.org/patch/9298871/

-- Sebastian


signature.asc
Description: PGP signature

Re: [PATCH v9 3/4] doc: bindings: mfd: act8945a: Update the example

[Sebastian Reichel]

Hi Lee,

On Thu, Sep 01, 2016 at 12:22:51PM +0100, Lee Jones wrote:
> On Thu, 01 Sep 2016, Wenyou Yang wrote:
> 
> > Since the act8945a-charger is regarded as a sub-device and it using
> > "interrupts" property, update the examples section.
> > 
> > Signed-off-by: Wenyou Yang 
> > ---
> > 
> > Changes in v9: None
> > Changes in v8: None
> > Changes in v7: None
> > Changes in v6: None
> > Changes in v4: None
> > 
> >  Documentation/devicetree/bindings/mfd/act8945a.txt | 22 
> > +++---
> >  1 file changed, 15 insertions(+), 7 deletions(-)
> 
> This is a functional change.  I'll require a DT Ack.

Wenyou Yang forgot to take over Rob's Acked-By from the previous
version: https://patchwork.kernel.org/patch/9298871/

-- Sebastian


signature.asc
Description: PGP signature

Re: [PATCH v9 3/4] doc: bindings: mfd: act8945a: Update the example

[Lee Jones]

On Thu, 01 Sep 2016, Wenyou Yang wrote:

> Since the act8945a-charger is regarded as a sub-device and it using
> "interrupts" property, update the examples section.
> 
> Signed-off-by: Wenyou Yang 
> ---
> 
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6: None
> Changes in v4: None
> 
>  Documentation/devicetree/bindings/mfd/act8945a.txt | 22 
> +++---
>  1 file changed, 15 insertions(+), 7 deletions(-)

This is a functional change.  I'll require a DT Ack.

> diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt 
> b/Documentation/devicetree/bindings/mfd/act8945a.txt
> index f712830..462819a 100644
> --- a/Documentation/devicetree/bindings/mfd/act8945a.txt
> +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> @@ -14,13 +14,6 @@ Example:
>   reg = <0x5b>;
>   status = "okay";
>  
> - pinctrl-names = "default";
> - pinctrl-0 = <_charger_chglev>;
> - active-semi,chglev-gpio = < 12 GPIO_ACTIVE_HIGH>;
> - active-semi,input-voltage-threshold-microvolt = <6600>;
> - active-semi,precondition-timeout = <40>;
> - active-semi,total-timeout = <3>;
> -
>   active-semi,vsel-high;
>  
>   regulators {
> @@ -73,4 +66,19 @@ Example:
>   regulator-always-on;
>   };
>   };
> +
> + charger {
> + compatible = "active-semi,act8945a-charger";
> + pinctrl-names = "default";
> + pinctrl-0 = <_charger_chglev 
> _charger_lbo _charger_irq>;
> + interrupt-parent = <>;
> + interrupts = <45 GPIO_ACTIVE_LOW>;
> +
> + active-semi,chglev-gpios = < 12 GPIO_ACTIVE_HIGH>;
> + active-semi,lbo-gpios = < 72 GPIO_ACTIVE_LOW>;
> + active-semi,input-voltage-threshold-microvolt = <6600>;
> + active-semi,precondition-timeout = <40>;
> + active-semi,total-timeout = <3>;
> + status = "okay";
> + };
>   };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v9 3/4] doc: bindings: mfd: act8945a: Update the example

[Lee Jones]

On Thu, 01 Sep 2016, Wenyou Yang wrote:

> Since the act8945a-charger is regarded as a sub-device and it using
> "interrupts" property, update the examples section.
> 
> Signed-off-by: Wenyou Yang 
> ---
> 
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6: None
> Changes in v4: None
> 
>  Documentation/devicetree/bindings/mfd/act8945a.txt | 22 
> +++---
>  1 file changed, 15 insertions(+), 7 deletions(-)

This is a functional change.  I'll require a DT Ack.

> diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt 
> b/Documentation/devicetree/bindings/mfd/act8945a.txt
> index f712830..462819a 100644
> --- a/Documentation/devicetree/bindings/mfd/act8945a.txt
> +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> @@ -14,13 +14,6 @@ Example:
>   reg = <0x5b>;
>   status = "okay";
>  
> - pinctrl-names = "default";
> - pinctrl-0 = <_charger_chglev>;
> - active-semi,chglev-gpio = < 12 GPIO_ACTIVE_HIGH>;
> - active-semi,input-voltage-threshold-microvolt = <6600>;
> - active-semi,precondition-timeout = <40>;
> - active-semi,total-timeout = <3>;
> -
>   active-semi,vsel-high;
>  
>   regulators {
> @@ -73,4 +66,19 @@ Example:
>   regulator-always-on;
>   };
>   };
> +
> + charger {
> + compatible = "active-semi,act8945a-charger";
> + pinctrl-names = "default";
> + pinctrl-0 = <_charger_chglev 
> _charger_lbo _charger_irq>;
> + interrupt-parent = <>;
> + interrupts = <45 GPIO_ACTIVE_LOW>;
> +
> + active-semi,chglev-gpios = < 12 GPIO_ACTIVE_HIGH>;
> + active-semi,lbo-gpios = < 72 GPIO_ACTIVE_LOW>;
> + active-semi,input-voltage-threshold-microvolt = <6600>;
> + active-semi,precondition-timeout = <40>;
> + active-semi,total-timeout = <3>;
> + status = "okay";
> + };
>   };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog