Re: Re: Re: [PATCH v3 11/14] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm
On 21-05-19, 05:41, Robin Gong wrote: > > -Original Message- > > From: Vinod Koul > > Sent: 2019年5月21日 13:13 > > > > On 21-05-19, 04:58, Robin Gong wrote: > > > > -Original Message- > > > > From: Vinod Koul > > > > Sent: 2019年5月21日 12:18 > > > > > > > > On 07-05-19, 09:16, Robin Gong wrote: > > > > > Because the number of ecspi1 rx event on i.mx8mm is 0, the > > > > > condition check ignore such special case without dma channel > > > > > enabled, which caused > > > > > ecspi1 rx works failed. Actually, no need to check event_id0, > > > > > checking > > > > > event_id1 is enough for DEV_2_DEV case because it's so lucky that > > > > > event_id1 never be 0. > > > > > > > > Well is that by chance or design that event_id1 will be never 0? > > > > > > > That's by chance. DEV_2_DEV is just for Audio case and non-zero for > > event_id1 on current i.MX family. > > > > Then it wont be fgood to rely on chance :) > Yes, I knew that. May I create another independent patch for event_id1 since > that's potential issue is not related with this ecspi patch set? Sure a patch should change one thing but I think it should come before this one. The log for this should be fixed up as well -- ~Vinod
RE: Re: Re: [PATCH v3 11/14] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm
> -Original Message- > From: Vinod Koul > Sent: 2019年5月21日 13:13 > > On 21-05-19, 04:58, Robin Gong wrote: > > > -Original Message- > > > From: Vinod Koul > > > Sent: 2019年5月21日 12:18 > > > > > > On 07-05-19, 09:16, Robin Gong wrote: > > > > Because the number of ecspi1 rx event on i.mx8mm is 0, the > > > > condition check ignore such special case without dma channel > > > > enabled, which caused > > > > ecspi1 rx works failed. Actually, no need to check event_id0, > > > > checking > > > > event_id1 is enough for DEV_2_DEV case because it's so lucky that > > > > event_id1 never be 0. > > > > > > Well is that by chance or design that event_id1 will be never 0? > > > > > That's by chance. DEV_2_DEV is just for Audio case and non-zero for > event_id1 on current i.MX family. > > Then it wont be fgood to rely on chance :) Yes, I knew that. May I create another independent patch for event_id1 since that's potential issue is not related with this ecspi patch set? > > -- > ~Vinod
Re: Re: [PATCH v3 11/14] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm
On 21-05-19, 04:58, Robin Gong wrote: > > -Original Message- > > From: Vinod Koul > > Sent: 2019年5月21日 12:18 > > > > On 07-05-19, 09:16, Robin Gong wrote: > > > Because the number of ecspi1 rx event on i.mx8mm is 0, the condition > > > check ignore such special case without dma channel enabled, which > > > caused > > > ecspi1 rx works failed. Actually, no need to check event_id0, checking > > > event_id1 is enough for DEV_2_DEV case because it's so lucky that > > > event_id1 never be 0. > > > > Well is that by chance or design that event_id1 will be never 0? > > > That's by chance. DEV_2_DEV is just for Audio case and non-zero for event_id1 > on current i.MX family. Then it wont be fgood to rely on chance :) -- ~Vinod
RE: Re: [PATCH v3 11/14] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm
> -Original Message- > From: Vinod Koul > Sent: 2019年5月21日 12:18 > > On 07-05-19, 09:16, Robin Gong wrote: > > Because the number of ecspi1 rx event on i.mx8mm is 0, the condition > > check ignore such special case without dma channel enabled, which > > caused > > ecspi1 rx works failed. Actually, no need to check event_id0, checking > > event_id1 is enough for DEV_2_DEV case because it's so lucky that > > event_id1 never be 0. > > Well is that by chance or design that event_id1 will be never 0? > That's by chance. DEV_2_DEV is just for Audio case and non-zero for event_id1 on current i.MX family.
