Re: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'
Tony Chuang writes: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> master >> head: ef2e9a563b0cd7965e2a1263125dcbb1c86aa6cc >> commit: ba0fbe236fb8a7b992e82d6eafb03a600f5eba43 rtw88: extract: make >> 8822c an individual kernel module >> date: 4 months ago >> config: i386-randconfig-r034-20200913 (attached as .config) >> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 >> reproduce (this is a W=1 build): >> git checkout ba0fbe236fb8a7b992e82d6eafb03a600f5eba43 >> # save the attached .config to linux build tree >> make W=1 ARCH=i386 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> All warnings (new ones prefixed by >>): >> >> >> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous >> >> prototype for 'rtw_pci_probe' [-Wmissing-prototypes] >> 1477 | int rtw_pci_probe(struct pci_dev *pdev, >> | ^ >> >> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no previous >> >> prototype for 'rtw_pci_remove' [-Wmissing-prototypes] >> 1557 | void rtw_pci_remove(struct pci_dev *pdev) >> | ^~ >> >> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no previous >> >> prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes] >> 1579 | void rtw_pci_shutdown(struct pci_dev *pdev) >> | ^~~~ >> [...] > Hi Kalle, > > The exported function is used by the following patchset. > So this is a false alarm. Good, thanks for checking. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
RE: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: ef2e9a563b0cd7965e2a1263125dcbb1c86aa6cc
> commit: ba0fbe236fb8a7b992e82d6eafb03a600f5eba43 rtw88: extract: make
> 8822c an individual kernel module
> date: 4 months ago
> config: i386-randconfig-r034-20200913 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> reproduce (this is a W=1 build):
> git checkout ba0fbe236fb8a7b992e82d6eafb03a600f5eba43
> # save the attached .config to linux build tree
> make W=1 ARCH=i386
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous
> >> prototype for 'rtw_pci_probe' [-Wmissing-prototypes]
> 1477 | int rtw_pci_probe(struct pci_dev *pdev,
> | ^
> >> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no previous
> >> prototype for 'rtw_pci_remove' [-Wmissing-prototypes]
> 1557 | void rtw_pci_remove(struct pci_dev *pdev)
> | ^~
> >> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no previous
> >> prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes]
> 1579 | void rtw_pci_shutdown(struct pci_dev *pdev)
> | ^~~~
>
> #
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b
> a0fbe236fb8a7b992e82d6eafb03a600f5eba43
> git remote add linus
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout ba0fbe236fb8a7b992e82d6eafb03a600f5eba43
> vim +/rtw_pci_probe +1477 drivers/net/wireless/realtek/rtw88/pci.c
>
> 79066903454b0fe Yu-Yen Ting 2019-09-03 1476
> 72f256c2b948622 Zong-Zhe Yang2020-05-15 @1477 int
> rtw_pci_probe(struct pci_dev *pdev,
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1478 const
> struct pci_device_id *id)
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1479 {
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1480 struct
> ieee80211_hw *hw;
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1481 struct rtw_dev
> *rtwdev;
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1482 int
> drv_data_size;
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1483 int ret;
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1484
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1485 drv_data_size
> = sizeof(struct rtw_dev) + sizeof(struct rtw_pci);
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1486 hw =
> ieee80211_alloc_hw(drv_data_size, _ops);
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1487 if (!hw) {
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1488
> dev_err(>dev, "failed to allocate hw\n");
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1489 return
> -ENOMEM;
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1490 }
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1491
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1492 rtwdev =
> hw->priv;
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1493 rtwdev->hw =
> hw;
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1494 rtwdev->dev =
> >dev;
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1495 rtwdev->chip =
> (struct rtw_chip_info *)id->driver_data;
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1496
> rtwdev->hci.ops = _pci_ops;
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1497
> rtwdev->hci.type = RTW_HCI_TYPE_PCIE;
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1498
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1499 ret =
> rtw_core_init(rtwdev);
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1500 if (ret)
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1501 goto
> err_release_hw;
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1502
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1503
> rtw_dbg(rtwdev, RTW_DBG_PCI,
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1504 "rtw88 pci
> probe: vendor=0x%4.04X device=0x%4.04X rev=%d\n",
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1505
> pdev->vendor, pdev->device, pdev->revision);
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1506
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1507 ret =
> rtw_pci_claim(rtwdev, pdev);
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1508 if (ret) {
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1509
> rtw_err(rtwdev, "failed to claim pci device\n");
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1510 goto
> err_deinit_core;
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1511 }
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1512
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1513 ret =
> rtw_pci_setup_resource(rtwdev, pdev);
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1514 if (ret) {
> e3037485c68ec1a Yan-Hsuan Chuang 2019-04-26 1515
> rtw_err(rtwdev, "failed to setup pci
Re: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'
Tony Chuang writes: >> + linux-wireless >> >> kernel test robot writes: >> >> > Hi Zong-Zhe, >> > >> > FYI, the error/warning still remains. >> > >> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> master >> > head: 23ee3e4e5bd27bdbc0f1785eef7209ce872794c7 >> > commit: 72f256c2b948622cc45ff8bc0456dd6039d8fe36 rtw88: extract: >> > export symbols about pci interface >> > date: 10 weeks ago >> > config: arc-randconfig-r026-20200725 (attached as .config) >> > compiler: arc-elf-gcc (GCC) 9.3.0 >> > reproduce (this is a W=1 build): >> > wget >> > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >> > -O ~/bin/make.cross >> > chmod +x ~/bin/make.cross >> > git checkout 72f256c2b948622cc45ff8bc0456dd6039d8fe36 >> > # save the attached .config to linux build tree >> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 >> make.cross ARCH=arc >> > >> > If you fix the issue, kindly add following tag as appropriate >> > Reported-by: kernel test robot >> > >> > All warnings (new ones prefixed by >>): >> > >> >>> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no >> >>> previous prototype for 'rtw_pci_probe' [-Wmissing-prototypes] >> > 1477 | int rtw_pci_probe(struct pci_dev *pdev, >> > | ^ >> >>> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no >> >>> previous prototype for 'rtw_pci_remove' [-Wmissing-prototypes] >> > 1557 | void rtw_pci_remove(struct pci_dev *pdev) >> > | ^~ >> >>> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no >> >>> previous prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes] >> > 1579 | void rtw_pci_shutdown(struct pci_dev *pdev) >> > | ^~~~ >> >> Tony, these are older warnings but please also check these. >> > > I think this warning can be ignored, as the commit was going to export > pci symbols for the follow-up patches to use, such as: > > f56f08636dda rtw88: extract: make 8723d an individual kernel module > 416e87fcc780 rtw88: extract: make 8822b an individual kernel module > ba0fbe236fb8 rtw88: extract: make 8822c an individual kernel module > > And these patches were submitted and applied together. Good, thanks for checking. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
RE: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'
> + linux-wireless > > kernel test robot writes: > > > Hi Zong-Zhe, > > > > FYI, the error/warning still remains. > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > > head: 23ee3e4e5bd27bdbc0f1785eef7209ce872794c7 > > commit: 72f256c2b948622cc45ff8bc0456dd6039d8fe36 rtw88: extract: > > export symbols about pci interface > > date: 10 weeks ago > > config: arc-randconfig-r026-20200725 (attached as .config) > > compiler: arc-elf-gcc (GCC) 9.3.0 > > reproduce (this is a W=1 build): > > wget > > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross > > -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > git checkout 72f256c2b948622cc45ff8bc0456dd6039d8fe36 > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 > make.cross ARCH=arc > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All warnings (new ones prefixed by >>): > > > >>> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no > >>> previous prototype for 'rtw_pci_probe' [-Wmissing-prototypes] > > 1477 | int rtw_pci_probe(struct pci_dev *pdev, > > | ^ > >>> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no > >>> previous prototype for 'rtw_pci_remove' [-Wmissing-prototypes] > > 1557 | void rtw_pci_remove(struct pci_dev *pdev) > > | ^~ > >>> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no > >>> previous prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes] > > 1579 | void rtw_pci_shutdown(struct pci_dev *pdev) > > | ^~~~ > > Tony, these are older warnings but please also check these. > I think this warning can be ignored, as the commit was going to export pci symbols for the follow-up patches to use, such as: f56f08636dda rtw88: extract: make 8723d an individual kernel module 416e87fcc780 rtw88: extract: make 8822b an individual kernel module ba0fbe236fb8 rtw88: extract: make 8822c an individual kernel module And these patches were submitted and applied together. Thanks, Yen-Hsuan
Re: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'
+ linux-wireless kernel test robot writes: > Hi Zong-Zhe, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 23ee3e4e5bd27bdbc0f1785eef7209ce872794c7 > commit: 72f256c2b948622cc45ff8bc0456dd6039d8fe36 rtw88: extract: > export symbols about pci interface > date: 10 weeks ago > config: arc-randconfig-r026-20200725 (attached as .config) > compiler: arc-elf-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross > -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout 72f256c2b948622cc45ff8bc0456dd6039d8fe36 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross > ARCH=arc > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > >>> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no >>> previous prototype for 'rtw_pci_probe' [-Wmissing-prototypes] > 1477 | int rtw_pci_probe(struct pci_dev *pdev, > | ^ >>> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no >>> previous prototype for 'rtw_pci_remove' [-Wmissing-prototypes] > 1557 | void rtw_pci_remove(struct pci_dev *pdev) > | ^~ >>> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no >>> previous prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes] > 1579 | void rtw_pci_shutdown(struct pci_dev *pdev) > | ^~~~ Tony, these are older warnings but please also check these. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
