Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
Hi Stephen, Stephen Rothwell writes: > On Wed, 19 Aug 2020 09:52:47 +0300 Kalle Valo wrote: >> >> Doh, I have checked carefully the commit ids but of course I missed >> checking the trailing. I really need to automate this. Stephen, are your >> scripts checking these available somewhere? > > I have attached them to this reply. Thanks a lot, these scripts are very helpful. For example with these I quickly found a problem in one pull request I recently got. I do see some cosmetic problems, most likely due to my git settings or version, but should be easy to fix. > I should put them up in a git repo somewhere. Yeah, please do. I'm sure people would benefit from these. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
Hi Kalle, On Wed, 19 Aug 2020 09:52:47 +0300 Kalle Valo wrote: > > Doh, I have checked carefully the commit ids but of course I missed > checking the trailing. I really need to automate this. Stephen, are your > scripts checking these available somewhere? I have attached them to this reply. I should put them up in a git repo somewhere. > But I'll leave this as is, no point of rebasing just because of this. Fair enough. -- Cheers, Stephen Rothwell check_fixes Description: application/shellscript check_commits Description: application/shellscript pgpQ4Q1EF6dbo.pgp Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
Stephen Rothwell writes:
> Hi all,
>
> In commit
>
> 3b9fb6791e71 ("wcn36xx: Fix reported 802.11n rx_highest rate
> wcn3660/wcn3680")
>
> Fixes tag
>
> Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more that one line. Also, keep all
> the commit message tags together at the end of the message.
Doh, I have checked carefully the commit ids but of course I missed
checking the trailing. I really need to automate this. Stephen, are your
scripts checking these available somewhere?
But I'll leave this as is, no point of rebasing just because of this.
Thanks for the report.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
Stephen Rothwell writes:
> In commit
>
> 4c7e1711cf4c ("mt76: mt7915: fix potential memory leak in mcu message
> handler")
>
> Fixes tag
>
> Fixes: c6b002bcdfa6 ("mt76: add mac80211 driver for MT7915 PCIe-based
> chipsets")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based
> chipsets")
Yeah, that should have been it but it's too much work to fix this now so
I'll just leave it be. Thanks for the report.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
Stephen Rothwell writes:
> Hi all,
>
> In commit
>
> ad96bc27032c ("brcmfmac: initialize the requested dwell time")
>
> Fixes tag
>
> Fixes: 4905432b28b7 ("brcmfmac: Fix P2P Group Formation failure via Go-neg
> method")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
>
> Maybe you meant
>
> Fixes: 9c29da3f4e7e ("brcmfmac: Fix P2P Group Formation failure via Go-neg
> method")
Heh, I noticed this and I even fixed it but maybe forgot to save my edit
or something. I'll need to be more careful next time.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
Stephen Rothwell writes:
> In commit
>
> f8d6379932dd ("mt76: mt7663: fix the usage WoW with net detect support")
>
> Fixes tag
>
> Fixes: bd39bd2f00c3 ("mt76: mt7663: introduce WoW with net detect support")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: a72ad451e704 ("mt76: mt7663: introduce WoW with net detect support")
Thanks for the report. I don't think this is bad enough to start
rebasing wireless-drivers-next so I'll leave it as is. But I'll try to
implement some kind of checking of Fixes tags in the future.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
RE: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
Hi Stephen,
You are correct, Its
Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
My bad, I added last 12 digits instead of first 12 digits of SHA1.
Regards,
Dundi
-Original Message-
From: Stephen Rothwell
Sent: Tuesday, July 2, 2019 3:03 AM
To: Kalle Valo ; Wireless
Cc: Linux Next Mailing List ; Linux Kernel
Mailing List ; Dundi Raviteja
Subject: linux-next: Fixes tag needs some work in the wireless-drivers-next
tree
Hi all,
In commit
c709df58832c ("ath10k: Fix memory leak in qmi")
Fixes tag
Fixes: fda6fee0001e ("ath10k: add QMI message handshake for wcn3990
client")
has these problem(s):
- Target SHA1 does not exist
Did you mean
Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
--
Cheers,
Stephen Rothwell
Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
> Hi all,
>
> In commit
>
> d923cf6bc38a ("mt76: mt7615: fix sparse warnings: warning: cast from
> restricted __le16")
>
> Fixes tag
>
> Fixes: 3ca0a6f6e9df ("mt7615: mcu: use standard signature for
> mt7615_mcu_msg_send")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: 516c3e380533 ("mt7615: mcu: use standard signature for
> mt7615_mcu_msg_send")
>
> In commit
>
> eda96044de27 ("mt76: mt7615: fix sparse warnings: incorrect type in
> assignment (different base types)")
>
> Fixes tag
>
> Fixes: 7339fbc0caa5 ("mt7615: mcu: do not use function pointers whenever
> possible")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: 1ca8089a55ee ("mt7615: mcu: do not use function pointers whenever
> possible")
>
> In commit
>
> 1a09d9e0e5f0 ("mt76: mt7615: fix incorrect settings in mesh mode")
>
> Fixes tag
>
> Fixes: f072c7ba2150 ("mt76: mt7615: enable support for mesh")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: f4ec7fdf7f83 ("mt76: mt7615: enable support for mesh")
Hi Stephen,
I used the hashes from my local git tree that are different from upstream ones,
sorry for the inconvenience. I will pay more attention next time.
Regards,
Lorenzo
>
> --
> Cheers,
> Stephen Rothwell
signature.asc
Description: PGP signature
