Re: linux-next: build warning after merge of the spi tree
Hi Mark
I will send a patch to fix this warning, sorry for that.
Patrice.
On 4/20/21 5:48 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the spi tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> In file included from include/linux/printk.h:409,
> from include/linux/kernel.h:16,
> from include/linux/clk.h:13,
> from drivers/spi/spi-stm32-qspi.c:7:
> drivers/spi/spi-stm32-qspi.c: In function 'stm32_qspi_dirmap_read':
> drivers/spi/spi-stm32-qspi.c:481:21: warning: format '%x' expects argument of
> type 'unsigned int', but argument 5 has type 'size_t' {aka 'long unsigned
> int'} [-Wformat=]
> 481 | dev_dbg(qspi->dev, "%s len = 0x%x offs = 0x%llx buf = 0x%p\n",
> __func__, len, offs, buf);
> | ^~
> include/linux/dynamic_debug.h:129:15: note: in definition of macro
> '__dynamic_func_call'
> 129 | func(, ##__VA_ARGS__); \
> | ^~~
> include/linux/dynamic_debug.h:161:2: note: in expansion of macro
> '_dynamic_func_call'
> 161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
> | ^~
> include/linux/dev_printk.h:123:2: note: in expansion of macro
> 'dynamic_dev_dbg'
> 123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
> | ^~~
> include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
> 123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
> | ^~~
> drivers/spi/spi-stm32-qspi.c:481:2: note: in expansion of macro 'dev_dbg'
> 481 | dev_dbg(qspi->dev, "%s len = 0x%x offs = 0x%llx buf = 0x%p\n",
> __func__, len, offs, buf);
> | ^~~
> drivers/spi/spi-stm32-qspi.c:481:34: note: format string is defined here
> 481 | dev_dbg(qspi->dev, "%s len = 0x%x offs = 0x%llx buf = 0x%p\n",
> __func__, len, offs, buf);
> | ~^
> | |
> | unsigned int
> | %lx
>
> Introduced by commit
>
> 18674dee3cd6 ("spi: stm32-qspi: Add dirmap support")
>
RE: linux-next: build warning after merge of the spi tree
> -Original Message- > From: Stephen Rothwell > Sent: Monday, January 4, 2021 2:07 AM > To: Mark Brown > Cc: Ardelean, Alexandru ; Andy Shevchenko > ; Linux Kernel Mailing List ker...@vger.kernel.org>; Linux Next Mailing List > Subject: linux-next: build warning after merge of the spi tree > > [External] > > Hi all, > > After merging the spi tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > Apologies for this. Will send a fix. > In file included from include/linux/device.h:15, > from include/linux/dmaengine.h:8, > from drivers/spi/spi-stm32.c:11: > drivers/spi/spi-stm32.c: In function 'stm32_spi_prepare_msg': > drivers/spi/spi-stm32.c:1030:20: warning: format '%d' expects argument of type > 'int', but argument 4 has type 'long unsigned int' [-Wformat=] > 1030 | dev_dbg(spi->dev, "cpol=%d cpha=%d lsb_first=%d cs_high=%d\n", > |^~~ > include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt' >19 | #define dev_fmt(fmt) fmt > | ^~~ > drivers/spi/spi-stm32.c:1030:2: note: in expansion of macro 'dev_dbg' > 1030 | dev_dbg(spi->dev, "cpol=%d cpha=%d lsb_first=%d cs_high=%d\n", > | ^~~ > drivers/spi/spi-stm32.c:1030:27: note: format string is defined here > 1030 | dev_dbg(spi->dev, "cpol=%d cpha=%d lsb_first=%d cs_high=%d\n", > | ~^ > | | > | int > | %ld > In file included from include/linux/device.h:15, > from include/linux/dmaengine.h:8, > from drivers/spi/spi-stm32.c:11: > drivers/spi/spi-stm32.c:1030:20: warning: format '%d' expects argument of type > 'int', but argument 5 has type 'long unsigned int' [-Wformat=] > 1030 | dev_dbg(spi->dev, "cpol=%d cpha=%d lsb_first=%d cs_high=%d\n", > |^~~ > include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt' >19 | #define dev_fmt(fmt) fmt > | ^~~ > drivers/spi/spi-stm32.c:1030:2: note: in expansion of macro 'dev_dbg' > 1030 | dev_dbg(spi->dev, "cpol=%d cpha=%d lsb_first=%d cs_high=%d\n", > | ^~~ > drivers/spi/spi-stm32.c:1030:35: note: format string is defined here > 1030 | dev_dbg(spi->dev, "cpol=%d cpha=%d lsb_first=%d cs_high=%d\n", > | ~^ > | | > | int > | %ld > In file included from include/linux/device.h:15, > from include/linux/dmaengine.h:8, > from drivers/spi/spi-stm32.c:11: > drivers/spi/spi-stm32.c:1030:20: warning: format '%d' expects argument of type > 'int', but argument 6 has type 'long unsigned int' [-Wformat=] > 1030 | dev_dbg(spi->dev, "cpol=%d cpha=%d lsb_first=%d cs_high=%d\n", > |^~~ > include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt' >19 | #define dev_fmt(fmt) fmt > | ^~~ > drivers/spi/spi-stm32.c:1030:2: note: in expansion of macro 'dev_dbg' > 1030 | dev_dbg(spi->dev, "cpol=%d cpha=%d lsb_first=%d cs_high=%d\n", > | ^~~ > drivers/spi/spi-stm32.c:1030:48: note: format string is defined here > 1030 | dev_dbg(spi->dev, "cpol=%d cpha=%d lsb_first=%d cs_high=%d\n", > | ~^ > || > |int > | %ld > In file included from include/linux/device.h:15, > from include/linux/dmaengine.h:8, > from drivers/spi/spi-stm32.c:11: > drivers/spi/spi-stm32.c:1030:20: warning: format '%d' expects argument of type > 'int', but argument 7 has type 'long unsigned int' [-Wformat=] > 1030 | dev_dbg(spi->dev, "cpol=%d cpha=%d lsb_first=%d cs_high=%d\n", > |^~~ > include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt' >19 | #define dev_fmt(fmt) fmt > | ^~~ > drivers/spi/spi-stm32.c:1030:2: note: in expansion of macro 'dev_dbg' > 1030 | dev_dbg(spi->dev, "cpol=%d cpha=%d lsb_first=%d cs_high=%d\n", > | ^~~ > drivers/spi/spi-stm32.c:1030:59: note: format string is defined here > 1030 | dev_dbg(spi->dev, "cpol=%d cpha=%d lsb_first=%d cs_high=%d\n", > | ~^ > | | > | int > |
Re: Re: linux-next: build warning after merge of the spi tree
On Thu, Jul 09, 2020 at 03:50:47PM +0800, Peng Fan wrote: > Hi, Browm, Stephen > Firstly, feel sorry for the problem introduced by me. I think I must > modify my bad,but should I send another patch to delete the label "out_free" > or > re-send patch of v2(which maybe need to go back)? > Could you give me some advices? Sorry again. You should send a patch on top of what's already applied but actually Colin Ian King sent a patch for this already which I can use so no need to do anything, thanks for staying on top of of this though. signature.asc Description: PGP signature
Re: Re: linux-next: build warning after merge of the spi tree
Hi, Browm, Stephen
Firstly, feel sorry for the problem introduced by me. I think I must modify
my bad,but should I send another patch to delete the label "out_free" or
re-send patch of v2(which maybe need to go back)?
Could you give me some advices? Sorry again.
Thanks
Peng Fan fanp...@loongson.cnwrote:
> Very sorry for that, I will re-send v2 later.
>
> Stephen Rothwell s...@canb.auug.org.auwrote:
> > Hi all,
> >
> > After merging the spi tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > drivers/spi/spi-atmel.c: In function 'atmel_spi_probe':
> > drivers/spi/spi-atmel.c:1680:1: warning: label 'out_free' defined but not
> > used [-Wunused-label]
> > 1680 | out_free:
> > | ^~~~
> >
> > Introduced by commit
> >
> > 2d9a744685bc ("spi: atmel: No need to call spi_master_put() if
> > spi_alloc_master() failed")
> >
> > --
> > Cheers,
> > Stephen Rothwell
Re: linux-next: build warning after merge of the spi tree
Very sorry for that, I will re-send v2 later.
Stephen Rothwell s...@canb.auug.org.auwrote:
> Hi all,
>
> After merging the spi tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/spi/spi-atmel.c: In function 'atmel_spi_probe':
> drivers/spi/spi-atmel.c:1680:1: warning: label 'out_free' defined but not
> used [-Wunused-label]
> 1680 | out_free:
> | ^~~~
>
> Introduced by commit
>
> 2d9a744685bc ("spi: atmel: No need to call spi_master_put() if
> spi_alloc_master() failed")
>
> --
> Cheers,
> Stephen Rothwell
Re: linux-next: build warning after merge of the spi tree
On Tue, Apr 28, 2020 at 10:31:56AM +0530, Sanjay R Mehta wrote: > Hi Stephen, > > I have just sent a fixup patch for this. Could it still reach 5.8? Yes, it'll be fine - thanks for sending the fix. Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed. signature.asc Description: PGP signature
RE: linux-next: build warning after merge of the spi tree
Hi Stephen,
> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: Tuesday, January 29, 2019 1:57 PM
> To: Yogesh Narayan Gaur
> Cc: Mark Brown ; Linux Next Mailing List n...@vger.kernel.org>; Linux Kernel Mailing List
> ;
> Frieder Schrempf ; Boris Brezillon
>
> Subject: Re: linux-next: build warning after merge of the spi tree
>
> Hi Yogesh,
>
> On Tue, 29 Jan 2019 06:57:51 + Yogesh Narayan Gaur
> wrote:
> >
> > > WARNING: modpost: missing MODULE_LICENSE() in
> > > drivers/spi/spi-nxp-fspi.o see include/linux/module.h for more
> > > information
> > >
> > Can someone help in pointing out that why above warning message is coming
> for mentioned commit.
> > Below MODULE_LICENSE string is present in the above mentioned file,
> drivers/spi/spi-nxp-fspi.c.
> > MODULE_LICENSE("GPL v2");
>
> The version in linux-next has no such line.
>
Yes, somehow this missing line was appended to the commit message instead of
the actual in patchwork, also being pointed out by Frieder in his reply.
Sorry for this.
I have send fix patch for this warning message [1]. Please check the patch and
apply.
--
Regards,
Yogesh Gaur
[1] https://patchwork.ozlabs.org/patch/1032586/
> --
> Cheers,
> Stephen Rothwell
Re: linux-next: build warning after merge of the spi tree
Hi Yogesh,
On Tue, 29 Jan 2019 06:57:51 + Yogesh Narayan Gaur
wrote:
>
> > WARNING: modpost: missing MODULE_LICENSE() in drivers/spi/spi-nxp-fspi.o
> > see include/linux/module.h for more information
> >
> Can someone help in pointing out that why above warning message is coming for
> mentioned commit.
> Below MODULE_LICENSE string is present in the above mentioned file,
> drivers/spi/spi-nxp-fspi.c.
> MODULE_LICENSE("GPL v2");
The version in linux-next has no such line.
--
Cheers,
Stephen Rothwell
pgpaFCrKI_onN.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the spi tree
On 29.01.19 07:57, Yogesh Narayan Gaur wrote:
> Hi,
>
>> -Original Message-
>> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
>> Sent: Tuesday, January 29, 2019 7:33 AM
>> To: Mark Brown
>> Cc: Linux Next Mailing List ; Linux Kernel
>> Mailing
>> List ; Yogesh Narayan Gaur
>> ; Frieder Schrempf
>> ; Boris Brezillon ;
>> Ashish Kumar
>> Subject: linux-next: build warning after merge of the spi tree
>>
>> Hi all,
>>
>> After merging the spi tree, today's linux-next build (KCONFIG_NAME) produced
>> this warning:
>>
>> WARNING: modpost: missing MODULE_LICENSE() in drivers/spi/spi-nxp-fspi.o
>> see include/linux/module.h for more information
>>
> Can someone help in pointing out that why above warning message is coming for
> mentioned commit.
> Below MODULE_LICENSE string is present in the above mentioned file,
> drivers/spi/spi-nxp-fspi.c.
> MODULE_LICENSE("GPL v2");
No, it is not present. Look at your patches [1] or at spi-next [2].
MODULE_LICENSE is definitely missing.
In patchwork the missing line was appended to the commit message instead
of the actual patch for some reason.
[1] https://patchwork.kernel.org/patch/10764347/
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/commit/?h=for-next=a5356aef6a907c2e2aed0caaa2b88b6021394471
RE: linux-next: build warning after merge of the spi tree
Hi,
> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: Tuesday, January 29, 2019 7:33 AM
> To: Mark Brown
> Cc: Linux Next Mailing List ; Linux Kernel Mailing
> List ; Yogesh Narayan Gaur
> ; Frieder Schrempf
> ; Boris Brezillon ;
> Ashish Kumar
> Subject: linux-next: build warning after merge of the spi tree
>
> Hi all,
>
> After merging the spi tree, today's linux-next build (KCONFIG_NAME) produced
> this warning:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/spi/spi-nxp-fspi.o
> see include/linux/module.h for more information
>
Can someone help in pointing out that why above warning message is coming for
mentioned commit.
Below MODULE_LICENSE string is present in the above mentioned file,
drivers/spi/spi-nxp-fspi.c.
MODULE_LICENSE("GPL v2");
--
Regards,
Yogesh Gaur
> Introduced by commit
>
> a5356aef6a90 ("spi: spi-mem: Add driver for NXP FlexSPI controller")
>
> --
> Cheers,
> Stephen Rothwell
Re: linux-next: build warning after merge of the spi tree
On Thu, Nov 15, 2018 at 05:56:19PM +0200, Tomer Maimon wrote: > Hi Mark and Stephen, > > I saw the warning from the kbuilt, in this matter the ioread() function > will call every time (and the val parameter will used) because rsize can be > 1 or 2. > > rsize = min(bytes_per_word(priv->bits_per_word), priv->rx_bytes); > bytes_per_word(priv->bits_per_word)function return 1 or 2. > npcm_pspi_recv()function will called only if parameter priv->rx_bytes is > not 0. > > please let me know if you think that I still need to modify the npcm_pspi_recv > to fix kbuilt warning. Please, it's going to create noise for people working on the kernel if they get a spurious warning. signature.asc Description: PGP signature
Re: linux-next: build warning after merge of the spi tree
On Thu, Nov 15, 2018 at 05:56:19PM +0200, Tomer Maimon wrote: > Hi Mark and Stephen, > > I saw the warning from the kbuilt, in this matter the ioread() function > will call every time (and the val parameter will used) because rsize can be > 1 or 2. > > rsize = min(bytes_per_word(priv->bits_per_word), priv->rx_bytes); > bytes_per_word(priv->bits_per_word)function return 1 or 2. > npcm_pspi_recv()function will called only if parameter priv->rx_bytes is > not 0. > > please let me know if you think that I still need to modify the npcm_pspi_recv > to fix kbuilt warning. Please, it's going to create noise for people working on the kernel if they get a spurious warning. signature.asc Description: PGP signature
Re: linux-next: build warning after merge of the spi tree
On Monday 27 March 2017 08:11 AM, Stephen Rothwell wrote:
> Hi Mark,
>
> After merging the spi tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> drivers/spi/spi-ti-qspi.c: In function 'ti_qspi_dma_xfer':
> drivers/spi/spi-ti-qspi.c:398:21: warning: unused variable 'dma_dev'
> [-Wunused-variable]
> struct dma_device *dma_dev = chan->device;
> ^
>
> Introduced by commit
>
> 1351aaeb50b2 ("spi: spi-ti-qspi: Use dma_engine wrapper for dma memcpy
> call")
>
Sorry, I have posted a fix for the same.
--
Regards
Vignesh
Re: linux-next: build warning after merge of the spi tree
On Monday 27 March 2017 08:11 AM, Stephen Rothwell wrote:
> Hi Mark,
>
> After merging the spi tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> drivers/spi/spi-ti-qspi.c: In function 'ti_qspi_dma_xfer':
> drivers/spi/spi-ti-qspi.c:398:21: warning: unused variable 'dma_dev'
> [-Wunused-variable]
> struct dma_device *dma_dev = chan->device;
> ^
>
> Introduced by commit
>
> 1351aaeb50b2 ("spi: spi-ti-qspi: Use dma_engine wrapper for dma memcpy
> call")
>
Sorry, I have posted a fix for the same.
--
Regards
Vignesh
