Re: + zsmalloc-add-comments-for-inuse-to-zspage.patch added to -mm tree

2015-09-23 Thread Sergey Senozhatsky 
On (09/23/15 14:53), a...@linux-foundation.org wrote:
> --
> From: Hui Zhu 
> Subject: zsmalloc: add comments for ->inuse to zspage
> 
> Signed-off-by: Hui Zhu 
> Cc: Sergey Senozhatsky 
> Cc: Dan Streetman 
> Cc: Minchan Kim 
> Signed-off-by: Andrew Morton 
> ---
> 
>  mm/zsmalloc.c |1 +
>  1 file changed, 1 insertion(+)
> 
> diff -puN mm/zsmalloc.c~zsmalloc-add-comments-for-inuse-to-zspage 
> mm/zsmalloc.c
> --- a/mm/zsmalloc.c~zsmalloc-add-comments-for-inuse-to-zspage
> +++ a/mm/zsmalloc.c
> @@ -38,6 +38,7 @@
>   *   page->lru: links together first pages of various zspages.
>   *   Basically forming list of zspages in a fullness group.
>   *   page->mapping: class index and fullness group of the zspage
> + *   page->inuse: the pages number that is used in this zspage

Probably arrived last night to my another mailbox, so haven't
seen this one.


The comment is wrong. page ->inuse represents the number of objects
in use in this zspage; not "the pages number".

usage example:

zspage_full() : page->inuse == page->objects
obj_malloc() : first_page->inuse++
obj_free() : first_page->inuse--

-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: + zsmalloc-add-comments-for-inuse-to-zspage.patch added to -mm tree

2015-09-23 Thread Sergey Senozhatsky 
On (09/23/15 14:53), a...@linux-foundation.org wrote:
> --
> From: Hui Zhu 
> Subject: zsmalloc: add comments for ->inuse to zspage
> 
> Signed-off-by: Hui Zhu 
> Cc: Sergey Senozhatsky 
> Cc: Dan Streetman 
> Cc: Minchan Kim 
> Signed-off-by: Andrew Morton 
> ---
> 
>  mm/zsmalloc.c |1 +
>  1 file changed, 1 insertion(+)
> 
> diff -puN mm/zsmalloc.c~zsmalloc-add-comments-for-inuse-to-zspage 
> mm/zsmalloc.c
> --- a/mm/zsmalloc.c~zsmalloc-add-comments-for-inuse-to-zspage
> +++ a/mm/zsmalloc.c
> @@ -38,6 +38,7 @@
>   *   page->lru: links together first pages of various zspages.
>   *   Basically forming list of zspages in a fullness group.
>   *   page->mapping: class index and fullness group of the zspage
> + *   page->inuse: the pages number that is used in this zspage

Probably arrived last night to my another mailbox, so haven't
seen this one.


The comment is wrong. page ->inuse represents the number of objects
in use in this zspage; not "the pages number".

usage example:

zspage_full() : page->inuse == page->objects
obj_malloc() : first_page->inuse++
obj_free() : first_page->inuse--

-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/