Re: [2.6 patch] SCSI: possible cleanups
On 03/01/05 17:17, Christoph Hellwig wrote: Doing it in the core means less duplication and avoiding updating all drivers. I agree. Luben - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] SCSI: possible cleanups
On Tue, Mar 01, 2005 at 09:40:48AM -0500, Luben Tuikov wrote: > On 03/01/05 03:14, Douglas Gilbert wrote: > >> - scsi_error.c: scsi_normalize_sense > > > > > >I introduced scsi_normalize_sense() recently, Christoph H. > >proposed it should be static but Luben Tuikov (aic7xxx > >maintainer) said he wished to use it in the future. > >Hence it was left global. > > Hi guys, > > I think the idea of normalized sense is very good. > Basically the question is if LLDD would submit normalized > sense to SCSI Core or whether they would submit a pointer > to raw sense data as returned by the device and let SCSI > Core decipher it. > > If the former, then it should be global, if the latter then > it should be static to SCSI Core. Doing it in the core means less duplication and avoiding updating all drivers. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] SCSI: possible cleanups
On 03/01/05 03:14, Douglas Gilbert wrote: - scsi_error.c: scsi_normalize_sense I introduced scsi_normalize_sense() recently, Christoph H. proposed it should be static but Luben Tuikov (aic7xxx maintainer) said he wished to use it in the future. Hence it was left global. Hi guys, I think the idea of normalized sense is very good. Basically the question is if LLDD would submit normalized sense to SCSI Core or whether they would submit a pointer to raw sense data as returned by the device and let SCSI Core decipher it. If the former, then it should be global, if the latter then it should be static to SCSI Core. Luben - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [2.6 patch] SCSI: possible cleanups
Christoph Hellwig writes: >> - scsi_scan.c: scsi_rescan_device >aacraid was going to use that one, Mark, any chance to get a patch anytime soon? >> - scsi_scan.c: scsi_scan_single_target >as mentioned above we'll need this one soon. Yup, we use both of them in our branch of the driver. I submit a patch to MarkH for the Hot-Add calls soon. Sincerely -- Mark Salyzyn - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] SCSI: possible cleanups
Adrian Bunk wrote: Before I'm getting flamed to death: Adrian, I have a few comments below. This patch contains possible cleanups. If parts of this patch conflict with pending changes these parts of my patch have to be dropped. This patch contains the following possible cleanups: - make needlessly global code static - remove or #if 0 the following unused functions: - scsi.h: print_driverbyte - scsi.h: print_hostbyte The names of the above are too general so they should go as soon as practical. - constants.c: scsi_print_hostbyte - constants.c: scsi_print_driverbyte I'm a bit surprised nothing else is using the above two. - scsi_scan.c: scsi_scan_single_target - remove the following unneeded EXPORT_SYMBOL's: - constants.c: __scsi_print_sense - hosts.c: scsi_host_lookup - scsi.c: scsi_device_cancel - scsi_error.c: scsi_normalize_sense I introduced scsi_normalize_sense() recently, Christoph H. proposed it should be static but Luben Tuikov (aic7xxx maintainer) said he wished to use it in the future. Hence it was left global. - scsi_error.c: scsi_sense_desc_find A pending patch on st from Kai M. will be using scsi_sense_desc_find(). I presume others will be using it in the future (e.g. SAT returns ATA status via a sense data descriptor with no corresponding fixed format representation). - scsi_lib.c: scsi_device_resume - scsi_scan.c: scsi_rescan_device - scsi_scan.c: scsi_scan_single_target Doug Gilbert - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] SCSI: possible cleanups
Adrian Bunk wrote: Before I'm getting flamed to death: Adrian, I have a few comments below. This patch contains possible cleanups. If parts of this patch conflict with pending changes these parts of my patch have to be dropped. This patch contains the following possible cleanups: - make needlessly global code static - remove or #if 0 the following unused functions: - scsi.h: print_driverbyte - scsi.h: print_hostbyte The names of the above are too general so they should go as soon as practical. - constants.c: scsi_print_hostbyte - constants.c: scsi_print_driverbyte I'm a bit surprised nothing else is using the above two. - scsi_scan.c: scsi_scan_single_target - remove the following unneeded EXPORT_SYMBOL's: - constants.c: __scsi_print_sense - hosts.c: scsi_host_lookup - scsi.c: scsi_device_cancel - scsi_error.c: scsi_normalize_sense I introduced scsi_normalize_sense() recently, Christoph H. proposed it should be static but Luben Tuikov (aic7xxx maintainer) said he wished to use it in the future. Hence it was left global. - scsi_error.c: scsi_sense_desc_find A pending patch on st from Kai M. will be using scsi_sense_desc_find(). I presume others will be using it in the future (e.g. SAT returns ATA status via a sense data descriptor with no corresponding fixed format representation). - scsi_lib.c: scsi_device_resume - scsi_scan.c: scsi_rescan_device - scsi_scan.c: scsi_scan_single_target Doug Gilbert - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [2.6 patch] SCSI: possible cleanups
Christoph Hellwig writes: - scsi_scan.c: scsi_rescan_device aacraid was going to use that one, Mark, any chance to get a patch anytime soon? - scsi_scan.c: scsi_scan_single_target as mentioned above we'll need this one soon. Yup, we use both of them in our branch of the driver. I submit a patch to MarkH for the Hot-Add calls soon. Sincerely -- Mark Salyzyn - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] SCSI: possible cleanups
On 03/01/05 03:14, Douglas Gilbert wrote: - scsi_error.c: scsi_normalize_sense I introduced scsi_normalize_sense() recently, Christoph H. proposed it should be static but Luben Tuikov (aic7xxx maintainer) said he wished to use it in the future. Hence it was left global. Hi guys, I think the idea of normalized sense is very good. Basically the question is if LLDD would submit normalized sense to SCSI Core or whether they would submit a pointer to raw sense data as returned by the device and let SCSI Core decipher it. If the former, then it should be global, if the latter then it should be static to SCSI Core. Luben - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] SCSI: possible cleanups
On Tue, Mar 01, 2005 at 09:40:48AM -0500, Luben Tuikov wrote: On 03/01/05 03:14, Douglas Gilbert wrote: - scsi_error.c: scsi_normalize_sense I introduced scsi_normalize_sense() recently, Christoph H. proposed it should be static but Luben Tuikov (aic7xxx maintainer) said he wished to use it in the future. Hence it was left global. Hi guys, I think the idea of normalized sense is very good. Basically the question is if LLDD would submit normalized sense to SCSI Core or whether they would submit a pointer to raw sense data as returned by the device and let SCSI Core decipher it. If the former, then it should be global, if the latter then it should be static to SCSI Core. Doing it in the core means less duplication and avoiding updating all drivers. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] SCSI: possible cleanups
On 03/01/05 17:17, Christoph Hellwig wrote: Doing it in the core means less duplication and avoiding updating all drivers. I agree. Luben - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] SCSI: possible cleanups
On Mon, Feb 28, 2005 at 10:25:09PM +, Christoph Hellwig wrote: >... > > - constants.c: scsi_print_hostbyte > > - constants.c: scsi_print_driverbyte > > these we'll probably keep for now. >... keep = #if 0 ? cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] SCSI: possible cleanups
On Mon, Feb 28, 2005 at 10:31:59PM +0100, Adrian Bunk wrote: > Before I'm getting flamed to death: > This patch contains possible cleanups. If parts of this patch conflict > with pending changes these parts of my patch have to be dropped. > > This patch contains the following possible cleanups: > - make needlessly global code static > - remove or #if 0 the following unused functions: > - scsi.h: print_driverbyte > - scsi.h: print_hostbyte these two please kill. > - constants.c: scsi_print_hostbyte > - constants.c: scsi_print_driverbyte these we'll probably keep for now. > - scsi_scan.c: scsi_scan_single_target this one will grow a user soon, but maybe it'll be completely rewritten before. > - remove the following unneeded EXPORT_SYMBOL's: > - constants.c: __scsi_print_sense this was put in for a drivea and makes sense as API. > - hosts.c: scsi_host_lookup we should probably kill this export. > - scsi.c: scsi_device_cancel > - scsi_lib.c: scsi_device_resume dito. > - scsi_error.c: scsi_normalize_sense > - scsi_error.c: scsi_sense_desc_find st is expected to use these soon. > - scsi_scan.c: scsi_rescan_device aacraid was going to use that one, Mark, any chance to get a patch anytime soon? > - scsi_scan.c: scsi_scan_single_target as mentioned above we'll need this one soon. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] SCSI: possible cleanups
On Mon, Feb 28, 2005 at 10:31:59PM +0100, Adrian Bunk wrote: Before I'm getting flamed to death: This patch contains possible cleanups. If parts of this patch conflict with pending changes these parts of my patch have to be dropped. This patch contains the following possible cleanups: - make needlessly global code static - remove or #if 0 the following unused functions: - scsi.h: print_driverbyte - scsi.h: print_hostbyte these two please kill. - constants.c: scsi_print_hostbyte - constants.c: scsi_print_driverbyte these we'll probably keep for now. - scsi_scan.c: scsi_scan_single_target this one will grow a user soon, but maybe it'll be completely rewritten before. - remove the following unneeded EXPORT_SYMBOL's: - constants.c: __scsi_print_sense this was put in for a drivea and makes sense as API. - hosts.c: scsi_host_lookup we should probably kill this export. - scsi.c: scsi_device_cancel - scsi_lib.c: scsi_device_resume dito. - scsi_error.c: scsi_normalize_sense - scsi_error.c: scsi_sense_desc_find st is expected to use these soon. - scsi_scan.c: scsi_rescan_device aacraid was going to use that one, Mark, any chance to get a patch anytime soon? - scsi_scan.c: scsi_scan_single_target as mentioned above we'll need this one soon. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] SCSI: possible cleanups
On Mon, Feb 28, 2005 at 10:25:09PM +, Christoph Hellwig wrote: ... - constants.c: scsi_print_hostbyte - constants.c: scsi_print_driverbyte these we'll probably keep for now. ... keep = #if 0 ? cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
