Re: [2.6 patch] remove the config option for the cs5530a_warm_reset() quirk
Adrian Bunk wrote: > I have no strong opinion regarding this - if it's agreed upon that it's > unlikely it will ever grow, I can also send an additional patch > simplifying it. I haven't got any response from the original person who submitted this patch. It isn't clear to me whether this is a fix for some machine that's in wide use, or a workaround for a prototype sitting on someone's bench. Andi has already accepted my more general patch which allows intercepting the halt/reboot process in arbitrary ways (the machine_ops patch), so that would seem to be a better way of handling this problem if more cases arise. J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] remove the config option for the cs5530a_warm_reset() quirk
On Sat, Mar 31, 2007 at 02:05:23PM -0700, Jeremy Fitzhardinge wrote: > Adrian Bunk wrote: > > Instead of cleaning up this mess, please replace this patch with the > > patch below. > > > > Yeah, I considered that patch as a placeholder; I'd been wondering if it > can be completely removed. > > But this patch looks fine, though I'd go further - the lookup table of > pci ids is overkill since it only has one entry (and doesn't look likely > to grow any more). I have no strong opinion regarding this - if it's agreed upon that it's unlikely it will ever grow, I can also send an additional patch simplifying it. > J cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] remove the config option for the cs5530a_warm_reset() quirk
Adrian Bunk wrote: > Instead of cleaning up this mess, please replace this patch with the > patch below. > Yeah, I considered that patch as a placeholder; I'd been wondering if it can be completely removed. But this patch looks fine, though I'd go further - the lookup table of pci ids is overkill since it only has one entry (and doesn't look likely to grow any more). J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] remove the config option for the cs5530a_warm_reset() quirk
Adrian Bunk wrote: Instead of cleaning up this mess, please replace this patch with the patch below. Yeah, I considered that patch as a placeholder; I'd been wondering if it can be completely removed. But this patch looks fine, though I'd go further - the lookup table of pci ids is overkill since it only has one entry (and doesn't look likely to grow any more). J - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] remove the config option for the cs5530a_warm_reset() quirk
On Sat, Mar 31, 2007 at 02:05:23PM -0700, Jeremy Fitzhardinge wrote: Adrian Bunk wrote: Instead of cleaning up this mess, please replace this patch with the patch below. Yeah, I considered that patch as a placeholder; I'd been wondering if it can be completely removed. But this patch looks fine, though I'd go further - the lookup table of pci ids is overkill since it only has one entry (and doesn't look likely to grow any more). I have no strong opinion regarding this - if it's agreed upon that it's unlikely it will ever grow, I can also send an additional patch simplifying it. J cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] remove the config option for the cs5530a_warm_reset() quirk
Adrian Bunk wrote: I have no strong opinion regarding this - if it's agreed upon that it's unlikely it will ever grow, I can also send an additional patch simplifying it. I haven't got any response from the original person who submitted this patch. It isn't clear to me whether this is a fix for some machine that's in wide use, or a workaround for a prototype sitting on someone's bench. Andi has already accepted my more general patch which allows intercepting the halt/reboot process in arbitrary ways (the machine_ops patch), so that would seem to be a better way of handling this problem if more cases arise. J - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
