Re: [2.6 patch] usbat_check_status(): fix check-after-use
Signed-off-by: Matthew Dharm <[EMAIL PROTECTED]> On Tue, Jul 31, 2007 at 12:28:22AM +0200, Adrian Bunk wrote: > The Coverity checker spotted that we have already oops'ed if "us" > was NULL. > > Since "us" can't be NULL in the only caller this patch removes the > NULL check. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > --- linux-2.6.23-rc1-mm1/drivers/usb/storage/shuttle_usbat.c.old > 2007-07-30 16:56:34.0 +0200 > +++ linux-2.6.23-rc1-mm1/drivers/usb/storage/shuttle_usbat.c 2007-07-30 > 16:57:24.0 +0200 > @@ -190,9 +190,6 @@ static int usbat_check_status(struct us_ > unsigned char *reply = us->iobuf; > int rc; > > - if (!us) > - return USB_STOR_TRANSPORT_ERROR; > - > rc = usbat_get_status(us, reply); > if (rc != USB_STOR_XFER_GOOD) > return USB_STOR_TRANSPORT_FAILED; -- Matthew Dharm Home: [EMAIL PROTECTED] Maintainer, Linux USB Mass Storage Driver I need a computer? -- Customer User Friendly, 2/19/1998 pgpfw0F2z8IIs.pgp Description: PGP signature
Re: [2.6 patch] usbat_check_status(): fix check-after-use
Signed-off-by: Matthew Dharm [EMAIL PROTECTED] On Tue, Jul 31, 2007 at 12:28:22AM +0200, Adrian Bunk wrote: The Coverity checker spotted that we have already oops'ed if us was NULL. Since us can't be NULL in the only caller this patch removes the NULL check. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux-2.6.23-rc1-mm1/drivers/usb/storage/shuttle_usbat.c.old 2007-07-30 16:56:34.0 +0200 +++ linux-2.6.23-rc1-mm1/drivers/usb/storage/shuttle_usbat.c 2007-07-30 16:57:24.0 +0200 @@ -190,9 +190,6 @@ static int usbat_check_status(struct us_ unsigned char *reply = us-iobuf; int rc; - if (!us) - return USB_STOR_TRANSPORT_ERROR; - rc = usbat_get_status(us, reply); if (rc != USB_STOR_XFER_GOOD) return USB_STOR_TRANSPORT_FAILED; -- Matthew Dharm Home: [EMAIL PROTECTED] Maintainer, Linux USB Mass Storage Driver I need a computer? -- Customer User Friendly, 2/19/1998 pgpfw0F2z8IIs.pgp Description: PGP signature
