Re: [6/6] 2.6.21-rc2: known regressions
From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Mon, 5 Mar 2007 03:26:02 +0100
> On Sun, Mar 04, 2007 at 06:07:25PM -0800, David Miller wrote:
> > From: Adrian Bunk <[EMAIL PROTECTED]>
> > Date: Mon, 5 Mar 2007 02:50:45 +0100
> >
> > > Subject: sparc64 compile error due to GENERIC_ISA_DMA removal
> > > References : http://bugzilla.kernel.org/show_bug.cgi?id=8097
> > > Submitter : Horst H. von Brand <[EMAIL PROTECTED]>
> > > Caused-By : David S. Miller <[EMAIL PROTECTED]>
> > > commit 1b51d3a08b6c80a1e47d4c579c41abbe56cd3c44
> > > Status : unknown
> >
> > Fixed in current GIT.
> >
> > commit 74bd7d093b8e87f35eaf3b14459b96a0e20d1d10
> > Author: David S. Miller <[EMAIL PROTECTED]>
> > Date: Wed Feb 28 13:09:34 2007 -0800
> >
> > [SPARC64]: Fix parport_pc build.
> >
> > Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
>
> Horst's problem is with the floppy driver and
> claim_dma_lock/release_dma_lock in include/asm-sparc64/dma.h .
Here is the fix I will send to Linus for this, thanks:
commit 08414aa2516da65ae7a522c6834b8ea576f38c4b
Author: David S. Miller <[EMAIL PROTECTED]>
Date: Sun Mar 4 20:36:18 2007 -0800
[SPARC64]: Fix floppy build failure.
Just define a local {claim,release}_dma_lock() implementation
for the floppy driver to use so we don't need to define and
export to modules the silly dma_spin_lock.
Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
diff --git a/include/asm-sparc64/dma.h b/include/asm-sparc64/dma.h
index 1bf4f7a..a9fd061 100644
--- a/include/asm-sparc64/dma.h
+++ b/include/asm-sparc64/dma.h
@@ -15,17 +15,6 @@
#include
#include
-extern spinlock_t dma_spin_lock;
-
-#define claim_dma_lock() \
-({ unsigned long flags; \
- spin_lock_irqsave(_spin_lock, flags); \
- flags; \
-})
-
-#define release_dma_lock(__flags) \
- spin_unlock_irqrestore(_spin_lock, __flags);
-
/* These are irrelevant for Sparc DMA, but we leave it in so that
* things can compile.
*/
diff --git a/include/asm-sparc64/floppy.h b/include/asm-sparc64/floppy.h
index dbe033e..331013a 100644
--- a/include/asm-sparc64/floppy.h
+++ b/include/asm-sparc64/floppy.h
@@ -854,4 +854,15 @@ static unsigned long __init sun_floppy_init(void)
#define EXTRA_FLOPPY_PARAMS
+static DEFINE_SPINLOCK(dma_spin_lock);
+
+#define claim_dma_lock() \
+({ unsigned long flags; \
+ spin_lock_irqsave(_spin_lock, flags); \
+ flags; \
+})
+
+#define release_dma_lock(__flags) \
+ spin_unlock_irqrestore(_spin_lock, __flags);
+
#endif /* !(__ASM_SPARC64_FLOPPY_H) */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [6/6] 2.6.21-rc2: known regressions
On Mon, Mar 05, 2007 at 02:50:45AM +0100, Adrian Bunk wrote: > > Subject: usb-serial broken > (ftdi serial device shows up as ttyUSB140 instead of ttyUSB0) > Submitter : Craig Schlenter <[EMAIL PROTECTED]> > Caused-By : Oliver Neukum <[EMAIL PROTECTED]> > commit 34ef50e5b1f96c2d8c0f3d28b7d407743806256c > Handled-By : Oliver Neukum <[EMAIL PROTECTED]> > Status : patch available Patch is queued up in my tree and will go to Linus in a few days. But I think there is another usb-serial patch that Oliver needs to send me to fix another problem with the usb-serial core... thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [6/6] 2.6.21-rc2: known regressions
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Mon, 5 Mar 2007 03:26:02 +0100 > On Sun, Mar 04, 2007 at 06:07:25PM -0800, David Miller wrote: > > From: Adrian Bunk <[EMAIL PROTECTED]> > > Date: Mon, 5 Mar 2007 02:50:45 +0100 > > > > > Subject: sparc64 compile error due to GENERIC_ISA_DMA removal > > > References : http://bugzilla.kernel.org/show_bug.cgi?id=8097 > > > Submitter : Horst H. von Brand <[EMAIL PROTECTED]> > > > Caused-By : David S. Miller <[EMAIL PROTECTED]> > > > commit 1b51d3a08b6c80a1e47d4c579c41abbe56cd3c44 > > > Status : unknown > > > > Fixed in current GIT. > > > > commit 74bd7d093b8e87f35eaf3b14459b96a0e20d1d10 > > Author: David S. Miller <[EMAIL PROTECTED]> > > Date: Wed Feb 28 13:09:34 2007 -0800 > > > > [SPARC64]: Fix parport_pc build. > > > > Signed-off-by: David S. Miller <[EMAIL PROTECTED]> > > Horst's problem is with the floppy driver and > claim_dma_lock/release_dma_lock in include/asm-sparc64/dma.h . Thanks for the clarification, I was thinking of the parport problem reported by Meelis Roos. I'll look into this. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [6/6] 2.6.21-rc2: known regressions
On Sun, Mar 04, 2007 at 06:07:25PM -0800, David Miller wrote: > From: Adrian Bunk <[EMAIL PROTECTED]> > Date: Mon, 5 Mar 2007 02:50:45 +0100 > > > Subject: sparc64 compile error due to GENERIC_ISA_DMA removal > > References : http://bugzilla.kernel.org/show_bug.cgi?id=8097 > > Submitter : Horst H. von Brand <[EMAIL PROTECTED]> > > Caused-By : David S. Miller <[EMAIL PROTECTED]> > > commit 1b51d3a08b6c80a1e47d4c579c41abbe56cd3c44 > > Status : unknown > > Fixed in current GIT. > > commit 74bd7d093b8e87f35eaf3b14459b96a0e20d1d10 > Author: David S. Miller <[EMAIL PROTECTED]> > Date: Wed Feb 28 13:09:34 2007 -0800 > > [SPARC64]: Fix parport_pc build. > > Signed-off-by: David S. Miller <[EMAIL PROTECTED]> Horst's problem is with the floppy driver and claim_dma_lock/release_dma_lock in include/asm-sparc64/dma.h . cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [6/6] 2.6.21-rc2: known regressions
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Mon, 5 Mar 2007 02:50:45 +0100 > Subject: sparc64 compile error due to GENERIC_ISA_DMA removal > References : http://bugzilla.kernel.org/show_bug.cgi?id=8097 > Submitter : Horst H. von Brand <[EMAIL PROTECTED]> > Caused-By : David S. Miller <[EMAIL PROTECTED]> > commit 1b51d3a08b6c80a1e47d4c579c41abbe56cd3c44 > Status : unknown Fixed in current GIT. commit 74bd7d093b8e87f35eaf3b14459b96a0e20d1d10 Author: David S. Miller <[EMAIL PROTECTED]> Date: Wed Feb 28 13:09:34 2007 -0800 [SPARC64]: Fix parport_pc build. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [6/6] 2.6.21-rc2: known regressions
On Sun, Mar 04, 2007 at 06:07:25PM -0800, David Miller wrote: From: Adrian Bunk [EMAIL PROTECTED] Date: Mon, 5 Mar 2007 02:50:45 +0100 Subject: sparc64 compile error due to GENERIC_ISA_DMA removal References : http://bugzilla.kernel.org/show_bug.cgi?id=8097 Submitter : Horst H. von Brand [EMAIL PROTECTED] Caused-By : David S. Miller [EMAIL PROTECTED] commit 1b51d3a08b6c80a1e47d4c579c41abbe56cd3c44 Status : unknown Fixed in current GIT. commit 74bd7d093b8e87f35eaf3b14459b96a0e20d1d10 Author: David S. Miller [EMAIL PROTECTED] Date: Wed Feb 28 13:09:34 2007 -0800 [SPARC64]: Fix parport_pc build. Signed-off-by: David S. Miller [EMAIL PROTECTED] Horst's problem is with the floppy driver and claim_dma_lock/release_dma_lock in include/asm-sparc64/dma.h . cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [6/6] 2.6.21-rc2: known regressions
From: Adrian Bunk [EMAIL PROTECTED] Date: Mon, 5 Mar 2007 03:26:02 +0100 On Sun, Mar 04, 2007 at 06:07:25PM -0800, David Miller wrote: From: Adrian Bunk [EMAIL PROTECTED] Date: Mon, 5 Mar 2007 02:50:45 +0100 Subject: sparc64 compile error due to GENERIC_ISA_DMA removal References : http://bugzilla.kernel.org/show_bug.cgi?id=8097 Submitter : Horst H. von Brand [EMAIL PROTECTED] Caused-By : David S. Miller [EMAIL PROTECTED] commit 1b51d3a08b6c80a1e47d4c579c41abbe56cd3c44 Status : unknown Fixed in current GIT. commit 74bd7d093b8e87f35eaf3b14459b96a0e20d1d10 Author: David S. Miller [EMAIL PROTECTED] Date: Wed Feb 28 13:09:34 2007 -0800 [SPARC64]: Fix parport_pc build. Signed-off-by: David S. Miller [EMAIL PROTECTED] Horst's problem is with the floppy driver and claim_dma_lock/release_dma_lock in include/asm-sparc64/dma.h . Thanks for the clarification, I was thinking of the parport problem reported by Meelis Roos. I'll look into this. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [6/6] 2.6.21-rc2: known regressions
From: Adrian Bunk [EMAIL PROTECTED]
Date: Mon, 5 Mar 2007 03:26:02 +0100
On Sun, Mar 04, 2007 at 06:07:25PM -0800, David Miller wrote:
From: Adrian Bunk [EMAIL PROTECTED]
Date: Mon, 5 Mar 2007 02:50:45 +0100
Subject: sparc64 compile error due to GENERIC_ISA_DMA removal
References : http://bugzilla.kernel.org/show_bug.cgi?id=8097
Submitter : Horst H. von Brand [EMAIL PROTECTED]
Caused-By : David S. Miller [EMAIL PROTECTED]
commit 1b51d3a08b6c80a1e47d4c579c41abbe56cd3c44
Status : unknown
Fixed in current GIT.
commit 74bd7d093b8e87f35eaf3b14459b96a0e20d1d10
Author: David S. Miller [EMAIL PROTECTED]
Date: Wed Feb 28 13:09:34 2007 -0800
[SPARC64]: Fix parport_pc build.
Signed-off-by: David S. Miller [EMAIL PROTECTED]
Horst's problem is with the floppy driver and
claim_dma_lock/release_dma_lock in include/asm-sparc64/dma.h .
Here is the fix I will send to Linus for this, thanks:
commit 08414aa2516da65ae7a522c6834b8ea576f38c4b
Author: David S. Miller [EMAIL PROTECTED]
Date: Sun Mar 4 20:36:18 2007 -0800
[SPARC64]: Fix floppy build failure.
Just define a local {claim,release}_dma_lock() implementation
for the floppy driver to use so we don't need to define and
export to modules the silly dma_spin_lock.
Signed-off-by: David S. Miller [EMAIL PROTECTED]
diff --git a/include/asm-sparc64/dma.h b/include/asm-sparc64/dma.h
index 1bf4f7a..a9fd061 100644
--- a/include/asm-sparc64/dma.h
+++ b/include/asm-sparc64/dma.h
@@ -15,17 +15,6 @@
#include asm/delay.h
#include asm/oplib.h
-extern spinlock_t dma_spin_lock;
-
-#define claim_dma_lock() \
-({ unsigned long flags; \
- spin_lock_irqsave(dma_spin_lock, flags); \
- flags; \
-})
-
-#define release_dma_lock(__flags) \
- spin_unlock_irqrestore(dma_spin_lock, __flags);
-
/* These are irrelevant for Sparc DMA, but we leave it in so that
* things can compile.
*/
diff --git a/include/asm-sparc64/floppy.h b/include/asm-sparc64/floppy.h
index dbe033e..331013a 100644
--- a/include/asm-sparc64/floppy.h
+++ b/include/asm-sparc64/floppy.h
@@ -854,4 +854,15 @@ static unsigned long __init sun_floppy_init(void)
#define EXTRA_FLOPPY_PARAMS
+static DEFINE_SPINLOCK(dma_spin_lock);
+
+#define claim_dma_lock() \
+({ unsigned long flags; \
+ spin_lock_irqsave(dma_spin_lock, flags); \
+ flags; \
+})
+
+#define release_dma_lock(__flags) \
+ spin_unlock_irqrestore(dma_spin_lock, __flags);
+
#endif /* !(__ASM_SPARC64_FLOPPY_H) */
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [6/6] 2.6.21-rc2: known regressions
From: Adrian Bunk [EMAIL PROTECTED] Date: Mon, 5 Mar 2007 02:50:45 +0100 Subject: sparc64 compile error due to GENERIC_ISA_DMA removal References : http://bugzilla.kernel.org/show_bug.cgi?id=8097 Submitter : Horst H. von Brand [EMAIL PROTECTED] Caused-By : David S. Miller [EMAIL PROTECTED] commit 1b51d3a08b6c80a1e47d4c579c41abbe56cd3c44 Status : unknown Fixed in current GIT. commit 74bd7d093b8e87f35eaf3b14459b96a0e20d1d10 Author: David S. Miller [EMAIL PROTECTED] Date: Wed Feb 28 13:09:34 2007 -0800 [SPARC64]: Fix parport_pc build. Signed-off-by: David S. Miller [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [6/6] 2.6.21-rc2: known regressions
On Mon, Mar 05, 2007 at 02:50:45AM +0100, Adrian Bunk wrote: Subject: usb-serial broken (ftdi serial device shows up as ttyUSB140 instead of ttyUSB0) Submitter : Craig Schlenter [EMAIL PROTECTED] Caused-By : Oliver Neukum [EMAIL PROTECTED] commit 34ef50e5b1f96c2d8c0f3d28b7d407743806256c Handled-By : Oliver Neukum [EMAIL PROTECTED] Status : patch available Patch is queued up in my tree and will go to Linus in a few days. But I think there is another usb-serial patch that Oliver needs to send me to fix another problem with the usb-serial core... thanks, greg k-h - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
