Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update
On Wed, Jan 31, 2007 at 09:57:26AM +1100, Benjamin Herrenschmidt wrote: > On Tue, 2007-01-30 at 14:49 -0800, Carl Love wrote: > > Christoph: > > > > In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt > > said that we should remove macros that are only used once and just put > > the actual code in. That is why the macros were removed. > > Heh... there is a balance to be found... In some cases, inline functions > might be better too. Well, unless there's a very good reasons against it (token pasting, header pollution) inlines are always preferable over macros, but I didn't want to bring that issue up aswell.. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update
On Wed, Jan 31, 2007 at 09:57:26AM +1100, Benjamin Herrenschmidt wrote: On Tue, 2007-01-30 at 14:49 -0800, Carl Love wrote: Christoph: In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt said that we should remove macros that are only used once and just put the actual code in. That is why the macros were removed. Heh... there is a balance to be found... In some cases, inline functions might be better too. Well, unless there's a very good reasons against it (token pasting, header pollution) inlines are always preferable over macros, but I didn't want to bring that issue up aswell.. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update
On Tue, 2007-01-30 at 14:49 -0800, Carl Love wrote: > Christoph: > > In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt > said that we should remove macros that are only used once and just put > the actual code in. That is why the macros were removed. Heh... there is a balance to be found... In some cases, inline functions might be better too. Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update
On Tue, 2007-01-30 at 14:49 -0800, Carl Love wrote: > Christoph: > > In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt > said that we should remove macros that are only used once and just put > the actual code in. That is why the macros were removed. I've looked at the macros you remove and indeed, they look like stuff you actually want to keep in macros. I don't have off the top of my head the circumstances where I asked you to remove macros in the PPE code, but I'm sure it was different. Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update
Christoph: In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt said that we should remove macros that are only used once and just put the actual code in. That is why the macros were removed. Carl Love On Tue, 2007-01-30 at 11:39 +0100, Christoph Hellwig wrote: > On Mon, Jan 29, 2007 at 01:46:50PM -0600, Maynard Johnson wrote: > > > > > > I don't think the macro removal is helpful, getting rid of the names > makes the code less readable to me. > ___ > cbe-oss-dev mailing list > [EMAIL PROTECTED] > https://ozlabs.org/mailman/listinfo/cbe-oss-dev - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update
On Mon, Jan 29, 2007 at 01:46:50PM -0600, Maynard Johnson wrote: > > I don't think the macro removal is helpful, getting rid of the names makes the code less readable to me. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update
On Mon, Jan 29, 2007 at 01:46:50PM -0600, Maynard Johnson wrote: I don't think the macro removal is helpful, getting rid of the names makes the code less readable to me. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update
Christoph: In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt said that we should remove macros that are only used once and just put the actual code in. That is why the macros were removed. Carl Love On Tue, 2007-01-30 at 11:39 +0100, Christoph Hellwig wrote: On Mon, Jan 29, 2007 at 01:46:50PM -0600, Maynard Johnson wrote: I don't think the macro removal is helpful, getting rid of the names makes the code less readable to me. ___ cbe-oss-dev mailing list [EMAIL PROTECTED] https://ozlabs.org/mailman/listinfo/cbe-oss-dev - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update
On Tue, 2007-01-30 at 14:49 -0800, Carl Love wrote: Christoph: In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt said that we should remove macros that are only used once and just put the actual code in. That is why the macros were removed. I've looked at the macros you remove and indeed, they look like stuff you actually want to keep in macros. I don't have off the top of my head the circumstances where I asked you to remove macros in the PPE code, but I'm sure it was different. Ben. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update
On Tue, 2007-01-30 at 14:49 -0800, Carl Love wrote: Christoph: In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt said that we should remove macros that are only used once and just put the actual code in. That is why the macros were removed. Heh... there is a balance to be found... In some cases, inline functions might be better too. Ben. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update
On Monday 29 January 2007 20:46, Maynard Johnson wrote: > This is a clean up patch that includes the following changes: > > -It removes some macro definitions that are only used once > with the actual code. > -Some comments were added to clarify the code based on feedback > from the community. > -The write_pm_cntrl() and set_count_mode() were passed a structure > element from a global variable. The argument was removed so the > functions now just operate on the global directly. > -The set_pm_event() function call in the cell_virtual_cntr() routine > was moved to a for-loop before the for_each_cpu loop > > Signed-off-by: Carl Love <[EMAIL PROTECTED]> > Signed-off-by: Maynard Johnson <[EMAIL PROTECTED]> > Acked-by: Arnd Bergmann <[EMAIL PROTECTED]> Just a small side note: Please give each of your patches a one-line summary in the subject of the email. I'm filing this one under: "cell: oprofile cleanup". It would also be good if you could use a mailer that sends out patches as inline, so you don't need to resort to using attachments. Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update
On Monday 29 January 2007 20:46, Maynard Johnson wrote: This is a clean up patch that includes the following changes: -It removes some macro definitions that are only used once with the actual code. -Some comments were added to clarify the code based on feedback from the community. -The write_pm_cntrl() and set_count_mode() were passed a structure element from a global variable. The argument was removed so the functions now just operate on the global directly. -The set_pm_event() function call in the cell_virtual_cntr() routine was moved to a for-loop before the for_each_cpu loop Signed-off-by: Carl Love [EMAIL PROTECTED] Signed-off-by: Maynard Johnson [EMAIL PROTECTED] Acked-by: Arnd Bergmann [EMAIL PROTECTED] Just a small side note: Please give each of your patches a one-line summary in the subject of the email. I'm filing this one under: cell: oprofile cleanup. It would also be good if you could use a mailer that sends out patches as inline, so you don't need to resort to using attachments. Arnd - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
