Re: [GIT PULL] scheduler fixes
The pull request you sent on Sat, 15 Aug 2020 13:27:31 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > sched-urgent-2020-08-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1195d58f003bf84d37fc5c30017600e09ba567b2 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [GIT PULL] scheduler fixes
The pull request you sent on Sat, 25 Jul 2020 12:47:20 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > sched-urgent-2020-07-25 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/3077805eebb63d75ad716e36777a54a3321d34a5 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
Re: [GIT PULL] scheduler fixes
The pull request you sent on Sat, 12 Oct 2019 16:58:36 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > sched-urgent-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/328fefadd9cfa15cd6ab746553d9ef13303c11a6 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
Re: [GIT PULL] scheduler fixes
On Tue, Oct 01, 2019 at 11:15:01AM -0700, John Stultz wrote: > On Tue, Oct 1, 2019 at 12:19 AM Peter Zijlstra wrote: > > > > On Mon, Sep 30, 2019 at 04:45:49PM -0700, John Stultz wrote: > > > Reverting the following patches: > > > > > "sched/membarrier: Fix p->mm->membarrier_state racy load" > > > > ARGH, I fudged it... please try: > > > > > > diff --git a/kernel/sched/membarrier.c b/kernel/sched/membarrier.c > > index a39bed2c784f..168479a7d61b 100644 > > --- a/kernel/sched/membarrier.c > > +++ b/kernel/sched/membarrier.c > > @@ -174,7 +174,6 @@ static int membarrier_private_expedited(int flags) > > */ > > if (cpu == raw_smp_processor_id()) > > continue; > > - rcu_read_lock(); > > p = rcu_dereference(cpu_rq(cpu)->curr); > > if (p && p->mm == mm) > > __cpumask_set_cpu(cpu, tmpmask); > > > Yep. Looks like that solves it! > Tested-by: John Stultz Makes sense. And here I was wondering yesterday why I was seeing bug reports with t->read_lock_nesting as non-zero when the task was interrupted in user mode ;-) Reviewed-by: Joel Fernandes (Google) thanks, - Joel
Re: [GIT PULL] scheduler fixes
On Tue, Oct 1, 2019 at 12:19 AM Peter Zijlstra wrote: > > On Mon, Sep 30, 2019 at 04:45:49PM -0700, John Stultz wrote: > > Reverting the following patches: > > > "sched/membarrier: Fix p->mm->membarrier_state racy load" > > ARGH, I fudged it... please try: > > > diff --git a/kernel/sched/membarrier.c b/kernel/sched/membarrier.c > index a39bed2c784f..168479a7d61b 100644 > --- a/kernel/sched/membarrier.c > +++ b/kernel/sched/membarrier.c > @@ -174,7 +174,6 @@ static int membarrier_private_expedited(int flags) > */ > if (cpu == raw_smp_processor_id()) > continue; > - rcu_read_lock(); > p = rcu_dereference(cpu_rq(cpu)->curr); > if (p && p->mm == mm) > __cpumask_set_cpu(cpu, tmpmask); Yep. Looks like that solves it! Tested-by: John Stultz Thanks so much for the quick turnaround! -john
Re: [GIT PULL] scheduler fixes
On Mon, Sep 30, 2019 at 04:45:49PM -0700, John Stultz wrote: > Reverting the following patches: > "sched/membarrier: Fix p->mm->membarrier_state racy load" ARGH, I fudged it... please try: diff --git a/kernel/sched/membarrier.c b/kernel/sched/membarrier.c index a39bed2c784f..168479a7d61b 100644 --- a/kernel/sched/membarrier.c +++ b/kernel/sched/membarrier.c @@ -174,7 +174,6 @@ static int membarrier_private_expedited(int flags) */ if (cpu == raw_smp_processor_id()) continue; - rcu_read_lock(); p = rcu_dereference(cpu_rq(cpu)->curr); if (p && p->mm == mm) __cpumask_set_cpu(cpu, tmpmask);
Re: [GIT PULL] scheduler fixes
On Sat, Sep 28, 2019 at 5:40 AM Ingo Molnar wrote: > > Please pull the latest sched-urgent-for-linus git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > sched-urgent-for-linus > ># HEAD: 4892f51ad54ddff2883a60b6ad4323c1f632a9d6 sched/fair: Avoid > redundant EAS calculation > > The changes are: > > - Apply a number of membarrier related fixes and cleanups, which fixes a >use-after-free race in the membarrier code. > > - Introduce proper RCU protection for tasks on the runqueue - to get rid >of the subtle task_rcu_dereference() interface that was easy to get >wrong. > > - Misc fixes, but also an EAS speedup. > > Thanks, > > Ingo > > --> > Eric W. Biederman (4): > tasks: Add a count of task RCU users > tasks, sched/core: Ensure tasks are available for a grace period after > leaving the runqueue > tasks, sched/core: With a grace period after finish_task_switch(), > remove unnecessary code > tasks, sched/core: RCUify the assignment of rq->curr > > KeMeng Shi (1): > sched/core: Fix migration to invalid CPU in __set_cpus_allowed_ptr() > > Mathieu Desnoyers (7): > sched/membarrier: Fix private expedited registration check > sched/membarrier: Remove redundant check > sched/membarrier: Call sync_core only before usermode for same mm > sched/membarrier: Fix p->mm->membarrier_state racy load > selftests, sched/membarrier: Add multi-threaded test > sched/membarrier: Skip IPIs when mm->mm_users == 1 > sched/membarrier: Return -ENOMEM to userspace on memory allocation > failure > > Qian Cai (3): > sched/fair: Remove unused cfs_rq_clock_task() function > sched/core: Convert vcpu_is_preempted() from macro to an inline function > sched/fair: Fix -Wunused-but-set-variable warnings > > Quentin Perret (1): > sched/fair: Avoid redundant EAS calculation > > Valentin Schneider (2): > sched/core: Fix preempt_schedule() interrupt return comment > sched/core: Remove double update_max_interval() call on CPU startup Hey all, After rebasing my hikey960 patches onto v5.4-rc1, I started seeing boot hangs/stalls trying boot AOSP: [9.788182] [ cut here ] [9.792829] WARNING: CPU: 7 PID: 516 at kernel/rcu/tree_plugin.h:293 rcu_note_context_switch+0x48/0x4a8 [9.802229] Modules linked in: [9.805298] CPU: 7 PID: 516 Comm: Jit thread pool Not tainted 5.3.0-13104-g0dbefe07634f #1126 [9.813822] Hardware name: HiKey960 (DT) [9.817742] pstate: 20400085 (nzCv daIf +PAN -UAO) [9.822530] pc : rcu_note_context_switch+0x48/0x4a8 [9.827403] lr : rcu_note_context_switch+0x1c/0x4a8 [9.832273] sp : ffc012ee3a60 [9.835581] x29: ffc012ee3a60 x28: ff82192d4140 [9.840889] x27: x26: ff821f7b38c0 [9.846195] x25: efb51cf8 x24: ffc0117ba000 [9.851501] x23: x22: ff82192d4140 [9.856806] x21: x20: ff821f7b38c0 [9.862111] x19: ff821f7b44c0 x18: [9.867416] x17: x16: [9.872721] x15: x14: [9.878026] x13: x12: [9.883331] x11: x10: [9.888636] x9 : x8 : ffc012ee3c60 [9.893941] x7 : ffc012ee3c70 x6 : ff8219026788 [9.899246] x5 : 014a2000 x4 : [9.904551] x3 : ffc20e1fe000 x2 : 0001 [9.909856] x1 : ffc0117ba428 x0 : 0023 [9.915163] Call trace: [9.917605] rcu_note_context_switch+0x48/0x4a8 [9.922134] __schedule+0x90/0x7d8 [9.925530] schedule+0x38/0xc0 [9.928667] futex_wait_queue_me+0xc0/0x140 [9.932847] futex_wait+0xe0/0x210 [9.936242] do_futex+0x618/0xdf8 [9.939551] __arm64_sys_futex_time32+0xfc/0x148 [9.944167] el0_svc_common.constprop.1+0x64/0x188 [9.948955] el0_svc_compat_handler+0x18/0x38 [9.953307] el0_svc_compat+0x8/0x2c [9.956876] ---[ end trace cdf2ffd45270a24d ]--- Usually followed by: [ 30.807092] rcu: INFO: rcu_preempt detected stalls on CPUs/tasks: [ 30.813207] rcu: Tasks blocked on level-0 rcu_node (CPUs 0-7): P521 P519 [ 30.819998] (detected by 4, t=5255 jiffies, g=169, q=5967) [ 30.825568] Jit thread pool S0 521 1 0x [ 30.831050] Call trace: [ 30.833498] __switch_to+0xd4/0x230 [ 30.836984] __schedule+0x320/0x7d8 [ 30.840464] schedule+0x38/0xc0 [ 30.843600] futex_wait_queue_me+0xc0/0x140 [ 30.847776] futex_wait+0xe0/0x210 [ 30.851169] do_futex+0x618/0xdf8 [ 30.854476] __arm64_sys_futex+0xfc/0x148 [ 30.858479] el0_svc_common.constprop.1+0x64/0x188 [ 30.863262] el0_svc_handler+0x20/0x80 [ 30.867003] el0_svc+0x8/0xc [ 30.869876] Jit thread pool S0 519 1 0x0040 [ 30.875353] Call trace: [
Re: [GIT PULL] scheduler fixes
The pull request you sent on Sat, 28 Sep 2019 14:39:05 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > sched-urgent-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9c5efe9ae7df78600c0ee7bcce27516eb687fa6e Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
Re: [GIT PULL] scheduler fixes
The pull request you sent on Thu, 5 Sep 2019 10:02:52 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > sched-urgent-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/262f7eeddc85c657e3087561dc8c3cfe227363ff Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
Re: [GIT PULL] scheduler fixes
The pull request you sent on Sat, 20 Apr 2019 09:33:41 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > sched-urgent-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/2b4cf5850db6acef2bbef52e3011f9bf93484209 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
Re: [GIT pull] scheduler fixes for 4.20
Linus,
On Sun, 11 Nov 2018, Linus Torvalds wrote:
> On Sun, Nov 11, 2018 at 2:11 AM Thomas Gleixner wrote:
> >
> >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> > sched-urgent-for-linus
>
> Hmm. I get
>
>Already up to date.
>
> with top commit being 993f0b0510da ("sched/topology: Fix off by one
> bug") that I already merged earlier.
>
> Did you forget to push out?
>
> I did find the commits in the 'sched/urgent' branch, so I pulled that.
Sorry. I was on a flaky wireless connection at the airport, so one of the
pushs must have failed without me noticing.
Thanks,
tglx
Re: [GIT pull] scheduler fixes for 4.20
Linus,
On Sun, 11 Nov 2018, Linus Torvalds wrote:
> On Sun, Nov 11, 2018 at 2:11 AM Thomas Gleixner wrote:
> >
> >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> > sched-urgent-for-linus
>
> Hmm. I get
>
>Already up to date.
>
> with top commit being 993f0b0510da ("sched/topology: Fix off by one
> bug") that I already merged earlier.
>
> Did you forget to push out?
>
> I did find the commits in the 'sched/urgent' branch, so I pulled that.
Sorry. I was on a flaky wireless connection at the airport, so one of the
pushs must have failed without me noticing.
Thanks,
tglx
Re: [GIT pull] scheduler fixes for 4.20
On Sun, Nov 11, 2018 at 2:11 AM Thomas Gleixner wrote:
>
>git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> sched-urgent-for-linus
Hmm. I get
Already up to date.
with top commit being 993f0b0510da ("sched/topology: Fix off by one
bug") that I already merged earlier.
Did you forget to push out?
I did find the commits in the 'sched/urgent' branch, so I pulled that.
Linus
Re: [GIT pull] scheduler fixes for 4.20
On Sun, Nov 11, 2018 at 2:11 AM Thomas Gleixner wrote:
>
>git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> sched-urgent-for-linus
Hmm. I get
Already up to date.
with top commit being 993f0b0510da ("sched/topology: Fix off by one
bug") that I already merged earlier.
Did you forget to push out?
I did find the commits in the 'sched/urgent' branch, so I pulled that.
Linus
Re: [GIT PULL] scheduler fixes
On Sat, Nov 3, 2018 at 4:52 PM Ingo Molnar wrote: > > A memory (under-)allocation fix and a comment fix. Pulled, Linus
Re: [GIT PULL] scheduler fixes
On Sat, Nov 3, 2018 at 4:52 PM Ingo Molnar wrote: > > A memory (under-)allocation fix and a comment fix. Pulled, Linus
Re: [GIT PULL] scheduler fixes
On Sat, Oct 20, 2018 at 10:45:16AM +0200, Ingo Molnar wrote: > Greg, > > Please pull the latest sched-urgent-for-linus git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > sched-urgent-for-linus Now merged, thanks. greg k-h
Re: [GIT PULL] scheduler fixes
On Sat, Oct 20, 2018 at 10:45:16AM +0200, Ingo Molnar wrote: > Greg, > > Please pull the latest sched-urgent-for-linus git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > sched-urgent-for-linus Now merged, thanks. greg k-h
Re: [GIT PULL] scheduler fixes
On Fri, Oct 05, 2018 at 11:50:17AM +0200, Ingo Molnar wrote: > Greg, > > Please pull the latest sched-urgent-for-linus git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > sched-urgent-for-linus Now merged, thanks. greg k-h
Re: [GIT PULL] scheduler fixes
On Fri, Oct 05, 2018 at 11:50:17AM +0200, Ingo Molnar wrote: > Greg, > > Please pull the latest sched-urgent-for-linus git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > sched-urgent-for-linus Now merged, thanks. greg k-h
Re: [GIT PULL] scheduler fixes
* Linus Torvalds wrote: > On Mon, Aug 20, 2012 at 2:12 AM, Ingo Molnar wrote: > > > > Please pull the latest sched-urgent-for-linus git tree from: > > Ingo, *please* get into the habit of writing a short explanation for > your pull request so that my merge messages can be more relevant, ok? Yeah, sorry: Small assorted fixlets, plus a lock contention fix which we felt rises to the level of needing a fix in -rc. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] scheduler fixes
* Linus Torvalds torva...@linux-foundation.org wrote: On Mon, Aug 20, 2012 at 2:12 AM, Ingo Molnar mi...@kernel.org wrote: Please pull the latest sched-urgent-for-linus git tree from: Ingo, *please* get into the habit of writing a short explanation for your pull request so that my merge messages can be more relevant, ok? Yeah, sorry: Small assorted fixlets, plus a lock contention fix which we felt rises to the level of needing a fix in -rc. Thanks, Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] scheduler fixes
On Mon, Aug 20, 2012 at 2:12 AM, Ingo Molnar wrote: > > Please pull the latest sched-urgent-for-linus git tree from: Ingo, *please* get into the habit of writing a short explanation for your pull request so that my merge messages can be more relevant, ok? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] scheduler fixes
On Mon, Aug 20, 2012 at 2:12 AM, Ingo Molnar mi...@kernel.org wrote: Please pull the latest sched-urgent-for-linus git tree from: Ingo, *please* get into the habit of writing a short explanation for your pull request so that my merge messages can be more relevant, ok? Linus -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [git pull] scheduler fixes
* Luiz Fernando N. Capitulino <[EMAIL PROTECTED]> wrote: > | >git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git > | > > | > It has another commit besides this fix. Thanks, > | > | Can you make up something that I can apply for 2.6.23-stable? or is > | this not an issue on that tree? > > FWIW I couldn't reproduce the problem with 2.6.23.9. sched_slice() is > quite different on that kernel and _maybe_ it won't never divide by > zero. no, this is due to a fairly recent commit, so 2.6.23 should not be affected. (We cleaned up sched_rr_interval() in one of the 2.6.24 scheduler commits.) > My original report on vendor-sec was wrong. I've said that 2.6.23.9 > had the same bug but turns out the kernel I tested had the Ingo's CFS > backport patch applied. I didn't know that, I thought it was a vanilla > kernel. > > Btw, I think it's important to release a new CFS backport patch > because maybe some distro is using it (Mandriva stable kernel is using > the CFS backport patch, but we didn't update to latest version yet). this should only affect the v24 CFS version - i've updated the v24 backport patches. sched_rr_interval() is almost never used, and it's basically never used for SCHED_OTHER tasks. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [git pull] scheduler fixes
Em Tue, 4 Dec 2007 10:28:51 -0800 Greg KH <[EMAIL PROTECTED]> escreveu: | On Tue, Dec 04, 2007 at 05:18:27PM +0100, Ingo Molnar wrote: | > | > * Ingo Molnar <[EMAIL PROTECTED]> wrote: | > | > > The problem is on SMP: if sched_rr_get_interval() gets a task from an | > > otherwise idle runqueue, then rq->load.weight is 0. Normally | > > sched_slice() is only used on a busy runqueue. So the correct fixup | > > site is not in sched_slice() but in sys_sched_rr_get_interval() - i'm | > > working on the right fix, i hope to be able to send a pull request in | > > a few minutes. | > | > the problem is on UP too - if there are no SCHED_OTHER tasks. I've | > tested the fix and it solves the problem for various combinations of | > crash.c. I've updated sched.git, please pull it from: | > | >git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git | > | > It has another commit besides this fix. Thanks, | | Can you make up something that I can apply for 2.6.23-stable? or is | this not an issue on that tree? FWIW I couldn't reproduce the problem with 2.6.23.9. sched_slice() is quite different on that kernel and _maybe_ it won't never divide by zero. My original report on vendor-sec was wrong. I've said that 2.6.23.9 had the same bug but turns out the kernel I tested had the Ingo's CFS backport patch applied. I didn't know that, I thought it was a vanilla kernel. Btw, I think it's important to release a new CFS backport patch because maybe some distro is using it (Mandriva stable kernel is using the CFS backport patch, but we didn't update to latest version yet). -- Luiz Fernando N. Capitulino -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [git pull] scheduler fixes
On Tue, Dec 04, 2007 at 05:18:27PM +0100, Ingo Molnar wrote: > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > The problem is on SMP: if sched_rr_get_interval() gets a task from an > > otherwise idle runqueue, then rq->load.weight is 0. Normally > > sched_slice() is only used on a busy runqueue. So the correct fixup > > site is not in sched_slice() but in sys_sched_rr_get_interval() - i'm > > working on the right fix, i hope to be able to send a pull request in > > a few minutes. > > the problem is on UP too - if there are no SCHED_OTHER tasks. I've > tested the fix and it solves the problem for various combinations of > crash.c. I've updated sched.git, please pull it from: > >git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git > > It has another commit besides this fix. Thanks, Can you make up something that I can apply for 2.6.23-stable? or is this not an issue on that tree? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [git pull] scheduler fixes
Em Tue, 4 Dec 2007 17:18:27 +0100 Ingo Molnar <[EMAIL PROTECTED]> escreveu: | | * Ingo Molnar <[EMAIL PROTECTED]> wrote: | | > The problem is on SMP: if sched_rr_get_interval() gets a task from an | > otherwise idle runqueue, then rq->load.weight is 0. Normally | > sched_slice() is only used on a busy runqueue. So the correct fixup | > site is not in sched_slice() but in sys_sched_rr_get_interval() - i'm | > working on the right fix, i hope to be able to send a pull request in | > a few minutes. | | the problem is on UP too - if there are no SCHED_OTHER tasks. I've | tested the fix and it solves the problem for various combinations of | crash.c. I've updated sched.git, please pull it from: | |git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git | | It has another commit besides this fix. Thanks, Yes, I tested the 'sched: fix crash in sys_sched_rr_get_interval()' one and it really fixes the problem. Thanks a lot Ingo. -- Luiz Fernando N. Capitulino -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [git pull] scheduler fixes
Em Tue, 4 Dec 2007 17:18:27 +0100 Ingo Molnar [EMAIL PROTECTED] escreveu: | | * Ingo Molnar [EMAIL PROTECTED] wrote: | | The problem is on SMP: if sched_rr_get_interval() gets a task from an | otherwise idle runqueue, then rq-load.weight is 0. Normally | sched_slice() is only used on a busy runqueue. So the correct fixup | site is not in sched_slice() but in sys_sched_rr_get_interval() - i'm | working on the right fix, i hope to be able to send a pull request in | a few minutes. | | the problem is on UP too - if there are no SCHED_OTHER tasks. I've | tested the fix and it solves the problem for various combinations of | crash.c. I've updated sched.git, please pull it from: | |git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git | | It has another commit besides this fix. Thanks, Yes, I tested the 'sched: fix crash in sys_sched_rr_get_interval()' one and it really fixes the problem. Thanks a lot Ingo. -- Luiz Fernando N. Capitulino -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [git pull] scheduler fixes
On Tue, Dec 04, 2007 at 05:18:27PM +0100, Ingo Molnar wrote: * Ingo Molnar [EMAIL PROTECTED] wrote: The problem is on SMP: if sched_rr_get_interval() gets a task from an otherwise idle runqueue, then rq-load.weight is 0. Normally sched_slice() is only used on a busy runqueue. So the correct fixup site is not in sched_slice() but in sys_sched_rr_get_interval() - i'm working on the right fix, i hope to be able to send a pull request in a few minutes. the problem is on UP too - if there are no SCHED_OTHER tasks. I've tested the fix and it solves the problem for various combinations of crash.c. I've updated sched.git, please pull it from: git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git It has another commit besides this fix. Thanks, Can you make up something that I can apply for 2.6.23-stable? or is this not an issue on that tree? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [git pull] scheduler fixes
Em Tue, 4 Dec 2007 10:28:51 -0800 Greg KH [EMAIL PROTECTED] escreveu: | On Tue, Dec 04, 2007 at 05:18:27PM +0100, Ingo Molnar wrote: | | * Ingo Molnar [EMAIL PROTECTED] wrote: | | The problem is on SMP: if sched_rr_get_interval() gets a task from an | otherwise idle runqueue, then rq-load.weight is 0. Normally | sched_slice() is only used on a busy runqueue. So the correct fixup | site is not in sched_slice() but in sys_sched_rr_get_interval() - i'm | working on the right fix, i hope to be able to send a pull request in | a few minutes. | | the problem is on UP too - if there are no SCHED_OTHER tasks. I've | tested the fix and it solves the problem for various combinations of | crash.c. I've updated sched.git, please pull it from: | | git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git | | It has another commit besides this fix. Thanks, | | Can you make up something that I can apply for 2.6.23-stable? or is | this not an issue on that tree? FWIW I couldn't reproduce the problem with 2.6.23.9. sched_slice() is quite different on that kernel and _maybe_ it won't never divide by zero. My original report on vendor-sec was wrong. I've said that 2.6.23.9 had the same bug but turns out the kernel I tested had the Ingo's CFS backport patch applied. I didn't know that, I thought it was a vanilla kernel. Btw, I think it's important to release a new CFS backport patch because maybe some distro is using it (Mandriva stable kernel is using the CFS backport patch, but we didn't update to latest version yet). -- Luiz Fernando N. Capitulino -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [git pull] scheduler fixes
* Luiz Fernando N. Capitulino [EMAIL PROTECTED] wrote: | git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git | | It has another commit besides this fix. Thanks, | | Can you make up something that I can apply for 2.6.23-stable? or is | this not an issue on that tree? FWIW I couldn't reproduce the problem with 2.6.23.9. sched_slice() is quite different on that kernel and _maybe_ it won't never divide by zero. no, this is due to a fairly recent commit, so 2.6.23 should not be affected. (We cleaned up sched_rr_interval() in one of the 2.6.24 scheduler commits.) My original report on vendor-sec was wrong. I've said that 2.6.23.9 had the same bug but turns out the kernel I tested had the Ingo's CFS backport patch applied. I didn't know that, I thought it was a vanilla kernel. Btw, I think it's important to release a new CFS backport patch because maybe some distro is using it (Mandriva stable kernel is using the CFS backport patch, but we didn't update to latest version yet). this should only affect the v24 CFS version - i've updated the v24 backport patches. sched_rr_interval() is almost never used, and it's basically never used for SCHED_OTHER tasks. Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [git pull] scheduler fixes
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > Linus, please pull the latest scheduler git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git > > 4 fixes - and one of the fixes could resolve the group-scheduler crashes > that were reported. Thanks, update: i've replaced this one: > Ingo Molnar (1): > sched: fix new task startup crash with the better fix from Srivatsa Vaddagiri: Srivatsa Vaddagiri (1): sched: fix new task startup crash Updated shortlog below. (if you pulled already that's not a problem either as both trees are fine - i'll sort it out) Ingo git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git --> Dhaval Giani (1): sched: fix !SYSFS build breakage Ken Chen (1): sched: fix improper load balance across sched domain Milton Miller (1): sched: more robust sd-sysctl entry freeing Srivatsa Vaddagiri (1): sched: fix new task startup crash include/linux/sched.h |2 ++ kernel/sched.c| 38 +++--- kernel/sched_fair.c |6 +- kernel/user.c | 23 +++ 4 files changed, 49 insertions(+), 20 deletions(-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [git pull] scheduler fixes
* Ingo Molnar [EMAIL PROTECTED] wrote: Linus, please pull the latest scheduler git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git 4 fixes - and one of the fixes could resolve the group-scheduler crashes that were reported. Thanks, update: i've replaced this one: Ingo Molnar (1): sched: fix new task startup crash with the better fix from Srivatsa Vaddagiri: Srivatsa Vaddagiri (1): sched: fix new task startup crash Updated shortlog below. (if you pulled already that's not a problem either as both trees are fine - i'll sort it out) Ingo git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git -- Dhaval Giani (1): sched: fix !SYSFS build breakage Ken Chen (1): sched: fix improper load balance across sched domain Milton Miller (1): sched: more robust sd-sysctl entry freeing Srivatsa Vaddagiri (1): sched: fix new task startup crash include/linux/sched.h |2 ++ kernel/sched.c| 38 +++--- kernel/sched_fair.c |6 +- kernel/user.c | 23 +++ 4 files changed, 49 insertions(+), 20 deletions(-) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
