Re: [PATCH][next] scsi: pm80xx: Fix potential infinite loop
On Wed, 7 Apr 2021 14:58:40 +0100, Colin King wrote: > The for-loop iterates with a u8 loop counter i and compares this > with the loop upper limit of pm8001_ha->max_q_num which is a u32 > type. There is a potential infinite loop if pm8001_ha->max_q_num > is larger than the u8 loop counter. Fix this by making the loop > counter the same type as pm8001_ha->max_q_num. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: pm80xx: Fix potential infinite loop https://git.kernel.org/mkp/scsi/c/40fa7394a1ad -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: pm80xx: Fix potential infinite loop
Colin, > The for-loop iterates with a u8 loop counter i and compares this with > the loop upper limit of pm8001_ha->max_q_num which is a u32 type. > There is a potential infinite loop if pm8001_ha->max_q_num is larger > than the u8 loop counter. Fix this by making the loop counter the same > type as pm8001_ha->max_q_num. Applied to 5.13/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: pm80xx: Fix potential infinite loop
On Wed, Apr 7, 2021 at 7:18 PM Martin K. Petersen wrote: > > > Hi Colin! > > > The for-loop iterates with a u8 loop counter i and compares this with > > the loop upper limit of pm8001_ha->max_q_num which is a u32 type. > > There is a potential infinite loop if pm8001_ha->max_q_num is larger > > than the u8 loop counter. Fix this by making the loop counter the same > > type as pm8001_ha->max_q_num. > > No particular objections to the patch for future-proofing. However, as > far as I can tell max_q_num is capped at 64 (PM8001_MAX_MSIX_VEC). Exactly. > > -- > Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: pm80xx: Fix potential infinite loop
Hi Colin! > The for-loop iterates with a u8 loop counter i and compares this with > the loop upper limit of pm8001_ha->max_q_num which is a u32 type. > There is a potential infinite loop if pm8001_ha->max_q_num is larger > than the u8 loop counter. Fix this by making the loop counter the same > type as pm8001_ha->max_q_num. No particular objections to the patch for future-proofing. However, as far as I can tell max_q_num is capped at 64 (PM8001_MAX_MSIX_VEC). -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: pm80xx: Fix potential infinite loop
On 07/04/2021 15:58, Colin King wrote:
> From: Colin Ian King
>
> The for-loop iterates with a u8 loop counter i and compares this
> with the loop upper limit of pm8001_ha->max_q_num which is a u32
> type. There is a potential infinite loop if pm8001_ha->max_q_num
> is larger than the u8 loop counter. Fix this by making the loop
> counter the same type as pm8001_ha->max_q_num.
Heh, coincidentally I've read your blog post on this issue today.
> Addresses-Coverity: ("Infinite loop")
> Fixes: 65df7d1986a1 ("scsi: pm80xx: Fix chip initialization failure")
AFAICS this still is in Martin's tree and not yet in Linus' tree.
Anyways, looks good.
Reviewed-by: Johannes Thumshirn
