Re: [PATCH] 'is_enabled' flag should be set/cleared when the device is actually enabled/disabled

2005-04-08 Thread Greg KH
On Fri, Apr 08, 2005 at 02:53:31PM +0900, Kenji Kaneshige wrote:
> Hi,
> 
> I think 'is_enabled' flag in pci_dev structure should be set/cleared
> when the device actually enabled/disabled. Especially about
> pci_enable_device(), it can be failed. By this change, we will also
> get the possibility of refering 'is_enabled' flag from the functions
> called through pci_enable_device()/pci_disable_device().
> 
> Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]>

Ah, nice catch.  I've applied this to my trees now, thanks.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] 'is_enabled' flag should be set/cleared when the device is actually enabled/disabled

2005-04-08 Thread Greg KH
On Fri, Apr 08, 2005 at 02:53:31PM +0900, Kenji Kaneshige wrote:
 Hi,
 
 I think 'is_enabled' flag in pci_dev structure should be set/cleared
 when the device actually enabled/disabled. Especially about
 pci_enable_device(), it can be failed. By this change, we will also
 get the possibility of refering 'is_enabled' flag from the functions
 called through pci_enable_device()/pci_disable_device().
 
 Signed-off-by: Kenji Kaneshige [EMAIL PROTECTED]

Ah, nice catch.  I've applied this to my trees now, thanks.

greg k-h
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/