Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Wednesday, 15 August 2007 04:51, Kyle Moffett wrote: > On Aug 14, 2007, at 19:24:30, Dave Jones wrote: > > On Tue, Aug 14, 2007 at 11:22:37AM -0700, Andrew Morton wrote: > >> On Tue, 14 Aug 2007 11:15:41 -0700 (PDT) Linus Torvalds > >> <[EMAIL PROTECTED]> wrote: > >>> In other words, it would be much better to just have per-file > >>> markers, along with some per-subdirectory stuff or similar. > >> > >> And a `make maintainers' target to pull it all together.. > >> > >> (perhaps we could add a > >> > >>maintainer > >> > >> record to Kconfig, then `make maintainers' goes and looks up > >> somewhere and does something with it) > > > > Not everything that's in MAINTAINERS has a Kconfig entry though, so > > it really needs to live in the .c/.h files. > > How about making "MAINTAINERS" operate vaguely similar > to .gitignore? You would need 4 pieces > > (a) A set of "Maintainers" files sprinkled around the source tree > where they make sense. Any file references would be done using > relative paths and patterns. For example, there would be one in the > root directory which has: > > [EVERYTHING ELSE] > P: Various Linux Kernel Developers > L: linux-kernel@vger.kernel.org > F: * > > > Then (using the earlier SUSPEND TO RAM example) in the kernel/power/ > Maintainers file, you would have: > > [SUSPEND TO RAM] > P: Pavel Machek > M: [EMAIL PROTECTED] > P: Rafael J. Wysocki > M: [EMAIL PROTECTED] > L: [EMAIL PROTECTED] > S: Maintained > F: * > > > Now that at least *one* of the maintainers files has the info for > Pavel and Rafael, you could just use this simpler form in any other > Maintainers file and still have it find their entries: > > [SUSPEND TO RAM] > F: linux/suspend.h > F: linux/freezer.h > F: linux/pm.h > F: asm-*/suspend.h > > > (b) You would need a little tool which generates a combined > MAINTAINERS file when "make maintainers" is run. It would iterate > over the directory tree and combine entries with the same names. > This also allows you to group people with their associated files even > if they work on the same subsystem/driver; they would be listed in > the respective sub-Maintainer-files, but when built it would mention > both of them. The intent would not be a MAINTAINERS file which is > perfectly human-readable, it would be one which can be efficiently > grepped by a helper tool to find the necessary information. When the > resulting MAINTAINERS file is built it would include the source > "Maintainers" file for each chunk right before said chunk, for example: > > [SUSPEND TO RAM] > > Origin: kernel/power/Maintainers > P: Pavel Machek > M: [EMAIL PROTECTED] > P: Rafael J. Wysocki > M: [EMAIL PROTECTED] > L: [EMAIL PROTECTED] > S: Maintained > F: kernel/power/* > > Origin: include/Maintainers > F: include/linux/suspend.h > F: include/linux/freezer.h > F: include/linux/pm.h > F: include/asm-*/suspend.h > > > > (c) You would need a tool to go digging through the built > MAINTAINERS file based on a file, an email address, a subsystem-name- > regexp, etc. It would return all matching entries, with the desired > fields user-selectable. > > > (d) You would need a little tool to poke at git similar to the shell > script Linus posted which dug through the recent commit history > looking for people doing significant *original* modifications (IE: > first person to sign-off) on code for which they aren't a maintainer, > as well as "Maintainers" who haven't recently signed off at all on > code for which they are responsible. The output might be something > like this: > > > ## Historical significance: 6 months > > ## Uncategorized file threshold: >10 changes or >20 sign-offs > > ## New maintainer threshold: >20 changes or >40 sign-offs > > ## Neglectful-maintainer threshold: <5 changes and <10 sign-offs > > > > [SUSPEND TO RAM] > > Nigel Cunningham should probably be a maintainer: > > kernel/power/* (130 changes, 132 sign-offs) > > include/linux/suspend.h (29 changes, 29 sign-offs) > > > > [RANDOM UNMAINTAINED DRIVER] > > J. Random Hacker has neglected his maintainership: > > drivers/random/unmaintained.c (0 changes, 0 sign-offs) > > > > [UNCATEGORIZED] > > John Linville should probably add/update a Maintainers entry: > > drivers/wireless/newly_added_driver.c (142 changes and 453 sign- > > offs) I like this idea. :-) Greetings, Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Wednesday, 15 August 2007 04:51, Kyle Moffett wrote: On Aug 14, 2007, at 19:24:30, Dave Jones wrote: On Tue, Aug 14, 2007 at 11:22:37AM -0700, Andrew Morton wrote: On Tue, 14 Aug 2007 11:15:41 -0700 (PDT) Linus Torvalds [EMAIL PROTECTED] wrote: In other words, it would be much better to just have per-file markers, along with some per-subdirectory stuff or similar. And a `make maintainers' target to pull it all together.. (perhaps we could add a maintainer keyword record to Kconfig, then `make maintainers' goes and looks up keyword somewhere and does something with it) Not everything that's in MAINTAINERS has a Kconfig entry though, so it really needs to live in the .c/.h files. How about making MAINTAINERS operate vaguely similar to .gitignore? You would need 4 pieces (a) A set of Maintainers files sprinkled around the source tree where they make sense. Any file references would be done using relative paths and patterns. For example, there would be one in the root directory which has: [EVERYTHING ELSE] P: Various Linux Kernel Developers L: linux-kernel@vger.kernel.org F: * Then (using the earlier SUSPEND TO RAM example) in the kernel/power/ Maintainers file, you would have: [SUSPEND TO RAM] P: Pavel Machek M: [EMAIL PROTECTED] P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Maintained F: * Now that at least *one* of the maintainers files has the info for Pavel and Rafael, you could just use this simpler form in any other Maintainers file and still have it find their entries: [SUSPEND TO RAM] F: linux/suspend.h F: linux/freezer.h F: linux/pm.h F: asm-*/suspend.h (b) You would need a little tool which generates a combined MAINTAINERS file when make maintainers is run. It would iterate over the directory tree and combine entries with the same names. This also allows you to group people with their associated files even if they work on the same subsystem/driver; they would be listed in the respective sub-Maintainer-files, but when built it would mention both of them. The intent would not be a MAINTAINERS file which is perfectly human-readable, it would be one which can be efficiently grepped by a helper tool to find the necessary information. When the resulting MAINTAINERS file is built it would include the source Maintainers file for each chunk right before said chunk, for example: [SUSPEND TO RAM] Origin: kernel/power/Maintainers P: Pavel Machek M: [EMAIL PROTECTED] P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Maintained F: kernel/power/* Origin: include/Maintainers F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h (c) You would need a tool to go digging through the built MAINTAINERS file based on a file, an email address, a subsystem-name- regexp, etc. It would return all matching entries, with the desired fields user-selectable. (d) You would need a little tool to poke at git similar to the shell script Linus posted which dug through the recent commit history looking for people doing significant *original* modifications (IE: first person to sign-off) on code for which they aren't a maintainer, as well as Maintainers who haven't recently signed off at all on code for which they are responsible. The output might be something like this: ## Historical significance: 6 months ## Uncategorized file threshold: 10 changes or 20 sign-offs ## New maintainer threshold: 20 changes or 40 sign-offs ## Neglectful-maintainer threshold: 5 changes and 10 sign-offs [SUSPEND TO RAM] Nigel Cunningham should probably be a maintainer: kernel/power/* (130 changes, 132 sign-offs) include/linux/suspend.h (29 changes, 29 sign-offs) [RANDOM UNMAINTAINED DRIVER] J. Random Hacker has neglected his maintainership: drivers/random/unmaintained.c (0 changes, 0 sign-offs) [UNCATEGORIZED] John Linville should probably add/update a Maintainers entry: drivers/wireless/newly_added_driver.c (142 changes and 453 sign- offs) I like this idea. :-) Greetings, Rafael - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Aug 14, 2007, at 19:24:30, Dave Jones wrote: On Tue, Aug 14, 2007 at 11:22:37AM -0700, Andrew Morton wrote: On Tue, 14 Aug 2007 11:15:41 -0700 (PDT) Linus Torvalds <[EMAIL PROTECTED]> wrote: In other words, it would be much better to just have per-file markers, along with some per-subdirectory stuff or similar. And a `make maintainers' target to pull it all together.. (perhaps we could add a maintainer record to Kconfig, then `make maintainers' goes and looks up somewhere and does something with it) Not everything that's in MAINTAINERS has a Kconfig entry though, so it really needs to live in the .c/.h files. How about making "MAINTAINERS" operate vaguely similar to .gitignore? You would need 4 pieces (a) A set of "Maintainers" files sprinkled around the source tree where they make sense. Any file references would be done using relative paths and patterns. For example, there would be one in the root directory which has: [EVERYTHING ELSE] P: Various Linux Kernel Developers L: linux-kernel@vger.kernel.org F: * Then (using the earlier SUSPEND TO RAM example) in the kernel/power/ Maintainers file, you would have: [SUSPEND TO RAM] P: Pavel Machek M: [EMAIL PROTECTED] P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Maintained F: * Now that at least *one* of the maintainers files has the info for Pavel and Rafael, you could just use this simpler form in any other Maintainers file and still have it find their entries: [SUSPEND TO RAM] F: linux/suspend.h F: linux/freezer.h F: linux/pm.h F: asm-*/suspend.h (b) You would need a little tool which generates a combined MAINTAINERS file when "make maintainers" is run. It would iterate over the directory tree and combine entries with the same names. This also allows you to group people with their associated files even if they work on the same subsystem/driver; they would be listed in the respective sub-Maintainer-files, but when built it would mention both of them. The intent would not be a MAINTAINERS file which is perfectly human-readable, it would be one which can be efficiently grepped by a helper tool to find the necessary information. When the resulting MAINTAINERS file is built it would include the source "Maintainers" file for each chunk right before said chunk, for example: [SUSPEND TO RAM] Origin: kernel/power/Maintainers P: Pavel Machek M: [EMAIL PROTECTED] P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Maintained F: kernel/power/* Origin: include/Maintainers F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h (c) You would need a tool to go digging through the built MAINTAINERS file based on a file, an email address, a subsystem-name- regexp, etc. It would return all matching entries, with the desired fields user-selectable. (d) You would need a little tool to poke at git similar to the shell script Linus posted which dug through the recent commit history looking for people doing significant *original* modifications (IE: first person to sign-off) on code for which they aren't a maintainer, as well as "Maintainers" who haven't recently signed off at all on code for which they are responsible. The output might be something like this: ## Historical significance: 6 months ## Uncategorized file threshold: >10 changes or >20 sign-offs ## New maintainer threshold: >20 changes or >40 sign-offs ## Neglectful-maintainer threshold: <5 changes and <10 sign-offs [SUSPEND TO RAM] Nigel Cunningham should probably be a maintainer: kernel/power/* (130 changes, 132 sign-offs) include/linux/suspend.h (29 changes, 29 sign-offs) [RANDOM UNMAINTAINED DRIVER] J. Random Hacker has neglected his maintainership: drivers/random/unmaintained.c (0 changes, 0 sign-offs) [UNCATEGORIZED] John Linville should probably add/update a Maintainers entry: drivers/wireless/newly_added_driver.c (142 changes and 453 sign- offs) Hopefully that kind of tool would make it a hundred times easier to keep an eye out for out-dated entries as well as missing new entries. The obsolescence-verification would be based on the rapidly- moving git changelog, so it would pick up new maintainers quite quickly, as well as noticing uncategorized source files and neglectful maintainers. Soon as I get moved into my new place I'll see what kind of Perl scripts I can hack up Cheers, Kyle Moffett - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tue, 2007-08-14 at 11:15 -0700, Linus Torvalds wrote: > In other words, it would be much better to just have per-file markers, > along with some per-subdirectory stuff or similar. So that there would be no hot single file, I cut the MAINTAINER file into single file segments in maintainers/* 00_descriptions 3c359_network_driver 3c505_network_driver 3c59x_network_driver 3cr990_network_driver ... zd1211rw_wireless_driver zf_machz_watchdog zr36067_video_for_linux_driver zs_decstation_z85c30_serial_driver zz_the_rest 611 files. How could "make" make a single MAINTAINERS? "cat [0-9a-z]* > ../MAINTAINERS"? Would it need to? Anyone have suggestions for Makefile/Kconfig support? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tue, Aug 14, 2007 at 11:22:37AM -0700, Andrew Morton wrote: > On Tue, 14 Aug 2007 11:15:41 -0700 (PDT) > Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > In other words, it would be much better to just have per-file markers, > > along with some per-subdirectory stuff or similar. > > And a `make maintainers' target to pull it all together.. > > (perhaps we could add a > > maintainer > > record to Kconfig, then `make maintainers' goes and looks up > somewhere and does something with it) Not everything that's in MAINTAINERS has a Kconfig entry though, so it really needs to live in the .c/.h files. Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tue, 2007-08-14 at 11:15 -0700, Linus Torvalds wrote: > Quite frankly, I think the MAINTAINERS file gets a whole lot uglier this > way. Me too. Chopping up the current file is simple. How about keeping the whole thing in git? Please look at thread: [PATCH] [1/2many] - Find the maintainer(s) for a patch - scripts/get_maintainer.pl > In other words, it would be much better to just have per-file markers, > along with some per-subdirectory stuff or similar. Perhaps a single top-level MAINTAINERS subdirectory with 500+ files or MAINTAINERS per subdirectory. Doesn't matter to me. I'd prefer no per-file external markers, nor embedded per-file keywords. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On 08/14/2007 08:15 PM, Linus Torvalds wrote: Quite frankly, I think the MAINTAINERS file gets a whole lot uglier this way. There's also a rather fundamental issue: this will likely make people touch the MAINTAINERS file *more*, and from a maintenance standpoint, that is exactly the wrong thing to have (one central file that everybody touches). It just tends to generate unnecessary merge conflicts etc. (We used to have that issue with the central configuration file, for example). So the more I look at these things, the more convinced I am that this is not the right thing to do. These things should *not* be in one huge file, and I'd much much rather have the maintainership information be carried along with the subsystem itself, or the files it contains. In other words, it would be much better to just have per-file markers, along with some per-subdirectory stuff or similar. Joe just now convinced me that rather than the per-file markers, the marker is meta-information that could just be stored in GIT, with the MAINTAINERS file turning into something generated. git info --maintainer and such (for many possible kinds of --flags) would throw out the information. Rene. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tue, 14 Aug 2007 11:15:41 -0700 (PDT) Linus Torvalds <[EMAIL PROTECTED]> wrote: > In other words, it would be much better to just have per-file markers, > along with some per-subdirectory stuff or similar. And a `make maintainers' target to pull it all together.. (perhaps we could add a maintainer record to Kconfig, then `make maintainers' goes and looks up somewhere and does something with it) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tue, 14 Aug 2007, Joe Perches wrote: > > SUSPEND TO RAM: > P:Pavel Machek > M:[EMAIL PROTECTED] > P:Rafael J. Wysocki > M:[EMAIL PROTECTED] > L:[EMAIL PROTECTED] > S:Maintained > F:Documentation/power/ > F:arch/i386/kernel/acpi/ > F:arch/x86_64/kernel/acpi/ > F:arch/x86_64/kernel/suspend.c > F:drivers/base/power/ > F:kernel/power/ > F:include/linux/suspend.h > F:include/linux/freezer.h > F:include/linux/pm.h > F:include/asm-*/suspend.h Quite frankly, I think the MAINTAINERS file gets a whole lot uglier this way. There's also a rather fundamental issue: this will likely make people touch the MAINTAINERS file *more*, and from a maintenance standpoint, that is exactly the wrong thing to have (one central file that everybody touches). It just tends to generate unnecessary merge conflicts etc. (We used to have that issue with the central configuration file, for example). So the more I look at these things, the more convinced I am that this is not the right thing to do. These things should *not* be in one huge file, and I'd much much rather have the maintainership information be carried along with the subsystem itself, or the files it contains. In other words, it would be much better to just have per-file markers, along with some per-subdirectory stuff or similar. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tuesday, 14 August 2007 19:57, Joe Perches wrote: > On Tue, 2007-08-14 at 19:37 +0200, Rafael J. Wysocki wrote: > > (1) hibernation > > F: Documentation/power/ > > F: arch/i386/power/ > > F: arch/x86_64/kernel/suspend_asm.S > > F: arch/x86_64/kernel/suspend.c > > F: drivers/base/power/ > > F: kernel/power/ > > F: include/linux/suspend.h > > F: include/linux/freezer.h > > F: include/linux/pm.h > > F: include/asm-*/suspend.h > > > > (2) suspend > > F: Documentation/power/ > > F: arch/i386/kernel/acpi/ > > F: arch/x86_64/kernel/acpi/ > > F: arch/x86_64/kernel/suspend.c > > F: drivers/base/power/ > > F: kernel/power/ > > F: include/linux/suspend.h > > F: include/linux/freezer.h > > F: include/linux/pm.h > > F: include/asm-*/suspend.h > > SUSPEND TO RAM: > P:Pavel Machek > M:[EMAIL PROTECTED] > P:Rafael J. Wysocki > M:[EMAIL PROTECTED] > L:[EMAIL PROTECTED] > S:Maintained > F:Documentation/power/ > F:arch/i386/kernel/acpi/ > F:arch/x86_64/kernel/acpi/ > F:arch/x86_64/kernel/suspend.c > F:drivers/base/power/ > F:kernel/power/ > F:include/linux/suspend.h > F:include/linux/freezer.h > F:include/linux/pm.h > F:include/asm-*/suspend.h > > HIBERNATION (aka Software Suspend, aka swsusp) > P:Pavel Machek > M:[EMAIL PROTECTED] > P:Rafael J. Wysocki > M:[EMAIL PROTECTED] > L:[EMAIL PROTECTED] > S:Supported > F:Documentation/power/ > F:arch/i386/power/ > F:arch/x86_64/kernel/suspend_asm.S > F:arch/x86_64/kernel/suspend.c > F:drivers/base/power/ > F:kernel/power/ > F:include/linux/suspend.h > F:include/linux/freezer.h > F:include/linux/pm.h > F:include/asm-*/suspend.h ACK - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tue, 2007-08-14 at 19:37 +0200, Rafael J. Wysocki wrote: > (1) hibernation > F: Documentation/power/ > F: arch/i386/power/ > F: arch/x86_64/kernel/suspend_asm.S > F: arch/x86_64/kernel/suspend.c > F: drivers/base/power/ > F: kernel/power/ > F: include/linux/suspend.h > F: include/linux/freezer.h > F: include/linux/pm.h > F: include/asm-*/suspend.h > > (2) suspend > F: Documentation/power/ > F: arch/i386/kernel/acpi/ > F: arch/x86_64/kernel/acpi/ > F: arch/x86_64/kernel/suspend.c > F: drivers/base/power/ > F: kernel/power/ > F: include/linux/suspend.h > F: include/linux/freezer.h > F: include/linux/pm.h > F: include/asm-*/suspend.h SUSPEND TO RAM: P: Pavel Machek M: [EMAIL PROTECTED] P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Maintained F: Documentation/power/ F: arch/i386/kernel/acpi/ F: arch/x86_64/kernel/acpi/ F: arch/x86_64/kernel/suspend.c F: drivers/base/power/ F: kernel/power/ F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h HIBERNATION (aka Software Suspend, aka swsusp) P: Pavel Machek M: [EMAIL PROTECTED] P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Supported F: Documentation/power/ F: arch/i386/power/ F: arch/x86_64/kernel/suspend_asm.S F: arch/x86_64/kernel/suspend.c F: drivers/base/power/ F: kernel/power/ F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tuesday, 14 August 2007 09:05, Pavel Machek wrote: > Hi! > > > > > + include/linux/suspend.h > > > > + include/linux/freezer.h > > > > + include/linux/pm.h > > > > + include/asm-*/suspend.h > > > > > > > > Hm, they are also relevant for suspend to RAM, so perhaps one common > > > > list of files for suspend to RAM and hibernation would be better? > > > > > > Maybe just collapse the 2 maintainers blocks into one? > > No, please don't. So, I think the F: entries should be the following: (1) hibernation F: Documentation/power/ F: arch/i386/power/ F: arch/x86_64/kernel/suspend_asm.S F: arch/x86_64/kernel/suspend.c F: drivers/base/power/ F: kernel/power/ F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h (2) suspend F: Documentation/power/ F: arch/i386/kernel/acpi/ F: arch/x86_64/kernel/acpi/ F: arch/x86_64/kernel/suspend.c F: drivers/base/power/ F: kernel/power/ F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h > > > HIBERNATION (aka Software Suspend, aka swsusp) and SUSPEND TO RAM: > > > P:Pavel Machek > > > M:[EMAIL PROTECTED] > > > P:Rafael J. Wysocki > > > M:[EMAIL PROTECTED] > > > L:[EMAIL PROTECTED] > > > S:Supported > > > > Then I think it should be "Maintained". > > No, supported is still right :-). OK Greetings, Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
Hi! > > > + include/linux/suspend.h > > > + include/linux/freezer.h > > > + include/linux/pm.h > > > + include/asm-*/suspend.h > > > > > > Hm, they are also relevant for suspend to RAM, so perhaps one common > > > list of files for suspend to RAM and hibernation would be better? > > > > Maybe just collapse the 2 maintainers blocks into one? No, please don't. > > HIBERNATION (aka Software Suspend, aka swsusp) and SUSPEND TO RAM: > > P: Pavel Machek > > M: [EMAIL PROTECTED] > > P: Rafael J. Wysocki > > M: [EMAIL PROTECTED] > > L: [EMAIL PROTECTED] > > S: Supported > > Then I think it should be "Maintained". No, supported is still right :-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
Hi! + include/linux/suspend.h + include/linux/freezer.h + include/linux/pm.h + include/asm-*/suspend.h Hm, they are also relevant for suspend to RAM, so perhaps one common list of files for suspend to RAM and hibernation would be better? Maybe just collapse the 2 maintainers blocks into one? No, please don't. HIBERNATION (aka Software Suspend, aka swsusp) and SUSPEND TO RAM: P: Pavel Machek M: [EMAIL PROTECTED] P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Supported Then I think it should be Maintained. No, supported is still right :-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tuesday, 14 August 2007 09:05, Pavel Machek wrote: Hi! + include/linux/suspend.h + include/linux/freezer.h + include/linux/pm.h + include/asm-*/suspend.h Hm, they are also relevant for suspend to RAM, so perhaps one common list of files for suspend to RAM and hibernation would be better? Maybe just collapse the 2 maintainers blocks into one? No, please don't. So, I think the F: entries should be the following: (1) hibernation F: Documentation/power/ F: arch/i386/power/ F: arch/x86_64/kernel/suspend_asm.S F: arch/x86_64/kernel/suspend.c F: drivers/base/power/ F: kernel/power/ F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h (2) suspend F: Documentation/power/ F: arch/i386/kernel/acpi/ F: arch/x86_64/kernel/acpi/ F: arch/x86_64/kernel/suspend.c F: drivers/base/power/ F: kernel/power/ F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h HIBERNATION (aka Software Suspend, aka swsusp) and SUSPEND TO RAM: P:Pavel Machek M:[EMAIL PROTECTED] P:Rafael J. Wysocki M:[EMAIL PROTECTED] L:[EMAIL PROTECTED] S:Supported Then I think it should be Maintained. No, supported is still right :-). OK Greetings, Rafael - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tue, 2007-08-14 at 19:37 +0200, Rafael J. Wysocki wrote: (1) hibernation F: Documentation/power/ F: arch/i386/power/ F: arch/x86_64/kernel/suspend_asm.S F: arch/x86_64/kernel/suspend.c F: drivers/base/power/ F: kernel/power/ F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h (2) suspend F: Documentation/power/ F: arch/i386/kernel/acpi/ F: arch/x86_64/kernel/acpi/ F: arch/x86_64/kernel/suspend.c F: drivers/base/power/ F: kernel/power/ F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h SUSPEND TO RAM: P: Pavel Machek M: [EMAIL PROTECTED] P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Maintained F: Documentation/power/ F: arch/i386/kernel/acpi/ F: arch/x86_64/kernel/acpi/ F: arch/x86_64/kernel/suspend.c F: drivers/base/power/ F: kernel/power/ F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h HIBERNATION (aka Software Suspend, aka swsusp) P: Pavel Machek M: [EMAIL PROTECTED] P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Supported F: Documentation/power/ F: arch/i386/power/ F: arch/x86_64/kernel/suspend_asm.S F: arch/x86_64/kernel/suspend.c F: drivers/base/power/ F: kernel/power/ F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tuesday, 14 August 2007 19:57, Joe Perches wrote: On Tue, 2007-08-14 at 19:37 +0200, Rafael J. Wysocki wrote: (1) hibernation F: Documentation/power/ F: arch/i386/power/ F: arch/x86_64/kernel/suspend_asm.S F: arch/x86_64/kernel/suspend.c F: drivers/base/power/ F: kernel/power/ F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h (2) suspend F: Documentation/power/ F: arch/i386/kernel/acpi/ F: arch/x86_64/kernel/acpi/ F: arch/x86_64/kernel/suspend.c F: drivers/base/power/ F: kernel/power/ F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h SUSPEND TO RAM: P:Pavel Machek M:[EMAIL PROTECTED] P:Rafael J. Wysocki M:[EMAIL PROTECTED] L:[EMAIL PROTECTED] S:Maintained F:Documentation/power/ F:arch/i386/kernel/acpi/ F:arch/x86_64/kernel/acpi/ F:arch/x86_64/kernel/suspend.c F:drivers/base/power/ F:kernel/power/ F:include/linux/suspend.h F:include/linux/freezer.h F:include/linux/pm.h F:include/asm-*/suspend.h HIBERNATION (aka Software Suspend, aka swsusp) P:Pavel Machek M:[EMAIL PROTECTED] P:Rafael J. Wysocki M:[EMAIL PROTECTED] L:[EMAIL PROTECTED] S:Supported F:Documentation/power/ F:arch/i386/power/ F:arch/x86_64/kernel/suspend_asm.S F:arch/x86_64/kernel/suspend.c F:drivers/base/power/ F:kernel/power/ F:include/linux/suspend.h F:include/linux/freezer.h F:include/linux/pm.h F:include/asm-*/suspend.h ACK - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tue, 14 Aug 2007, Joe Perches wrote: SUSPEND TO RAM: P:Pavel Machek M:[EMAIL PROTECTED] P:Rafael J. Wysocki M:[EMAIL PROTECTED] L:[EMAIL PROTECTED] S:Maintained F:Documentation/power/ F:arch/i386/kernel/acpi/ F:arch/x86_64/kernel/acpi/ F:arch/x86_64/kernel/suspend.c F:drivers/base/power/ F:kernel/power/ F:include/linux/suspend.h F:include/linux/freezer.h F:include/linux/pm.h F:include/asm-*/suspend.h Quite frankly, I think the MAINTAINERS file gets a whole lot uglier this way. There's also a rather fundamental issue: this will likely make people touch the MAINTAINERS file *more*, and from a maintenance standpoint, that is exactly the wrong thing to have (one central file that everybody touches). It just tends to generate unnecessary merge conflicts etc. (We used to have that issue with the central configuration file, for example). So the more I look at these things, the more convinced I am that this is not the right thing to do. These things should *not* be in one huge file, and I'd much much rather have the maintainership information be carried along with the subsystem itself, or the files it contains. In other words, it would be much better to just have per-file markers, along with some per-subdirectory stuff or similar. Linus - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tue, 14 Aug 2007 11:15:41 -0700 (PDT) Linus Torvalds [EMAIL PROTECTED] wrote: In other words, it would be much better to just have per-file markers, along with some per-subdirectory stuff or similar. And a `make maintainers' target to pull it all together.. (perhaps we could add a maintainer keyword record to Kconfig, then `make maintainers' goes and looks up keyword somewhere and does something with it) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On 08/14/2007 08:15 PM, Linus Torvalds wrote: Quite frankly, I think the MAINTAINERS file gets a whole lot uglier this way. There's also a rather fundamental issue: this will likely make people touch the MAINTAINERS file *more*, and from a maintenance standpoint, that is exactly the wrong thing to have (one central file that everybody touches). It just tends to generate unnecessary merge conflicts etc. (We used to have that issue with the central configuration file, for example). So the more I look at these things, the more convinced I am that this is not the right thing to do. These things should *not* be in one huge file, and I'd much much rather have the maintainership information be carried along with the subsystem itself, or the files it contains. In other words, it would be much better to just have per-file markers, along with some per-subdirectory stuff or similar. Joe just now convinced me that rather than the per-file markers, the marker is meta-information that could just be stored in GIT, with the MAINTAINERS file turning into something generated. git info --maintainer and such (for many possible kinds of --flags) would throw out the information. Rene. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tue, 2007-08-14 at 11:15 -0700, Linus Torvalds wrote: Quite frankly, I think the MAINTAINERS file gets a whole lot uglier this way. Me too. Chopping up the current file is simple. How about keeping the whole thing in git? Please look at thread: [PATCH] [1/2many] - Find the maintainer(s) for a patch - scripts/get_maintainer.pl In other words, it would be much better to just have per-file markers, along with some per-subdirectory stuff or similar. Perhaps a single top-level MAINTAINERS subdirectory with 500+ files or MAINTAINERS per subdirectory. Doesn't matter to me. I'd prefer no per-file external markers, nor embedded per-file keywords. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tue, Aug 14, 2007 at 11:22:37AM -0700, Andrew Morton wrote: On Tue, 14 Aug 2007 11:15:41 -0700 (PDT) Linus Torvalds [EMAIL PROTECTED] wrote: In other words, it would be much better to just have per-file markers, along with some per-subdirectory stuff or similar. And a `make maintainers' target to pull it all together.. (perhaps we could add a maintainer keyword record to Kconfig, then `make maintainers' goes and looks up keyword somewhere and does something with it) Not everything that's in MAINTAINERS has a Kconfig entry though, so it really needs to live in the .c/.h files. Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Tue, 2007-08-14 at 11:15 -0700, Linus Torvalds wrote: In other words, it would be much better to just have per-file markers, along with some per-subdirectory stuff or similar. So that there would be no hot single file, I cut the MAINTAINER file into single file segments in maintainers/* 00_descriptions 3c359_network_driver 3c505_network_driver 3c59x_network_driver 3cr990_network_driver ... zd1211rw_wireless_driver zf_machz_watchdog zr36067_video_for_linux_driver zs_decstation_z85c30_serial_driver zz_the_rest 611 files. How could make make a single MAINTAINERS? cat [0-9a-z]* ../MAINTAINERS? Would it need to? Anyone have suggestions for Makefile/Kconfig support? - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Aug 14, 2007, at 19:24:30, Dave Jones wrote: On Tue, Aug 14, 2007 at 11:22:37AM -0700, Andrew Morton wrote: On Tue, 14 Aug 2007 11:15:41 -0700 (PDT) Linus Torvalds [EMAIL PROTECTED] wrote: In other words, it would be much better to just have per-file markers, along with some per-subdirectory stuff or similar. And a `make maintainers' target to pull it all together.. (perhaps we could add a maintainer keyword record to Kconfig, then `make maintainers' goes and looks up keyword somewhere and does something with it) Not everything that's in MAINTAINERS has a Kconfig entry though, so it really needs to live in the .c/.h files. How about making MAINTAINERS operate vaguely similar to .gitignore? You would need 4 pieces (a) A set of Maintainers files sprinkled around the source tree where they make sense. Any file references would be done using relative paths and patterns. For example, there would be one in the root directory which has: [EVERYTHING ELSE] P: Various Linux Kernel Developers L: linux-kernel@vger.kernel.org F: * Then (using the earlier SUSPEND TO RAM example) in the kernel/power/ Maintainers file, you would have: [SUSPEND TO RAM] P: Pavel Machek M: [EMAIL PROTECTED] P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Maintained F: * Now that at least *one* of the maintainers files has the info for Pavel and Rafael, you could just use this simpler form in any other Maintainers file and still have it find their entries: [SUSPEND TO RAM] F: linux/suspend.h F: linux/freezer.h F: linux/pm.h F: asm-*/suspend.h (b) You would need a little tool which generates a combined MAINTAINERS file when make maintainers is run. It would iterate over the directory tree and combine entries with the same names. This also allows you to group people with their associated files even if they work on the same subsystem/driver; they would be listed in the respective sub-Maintainer-files, but when built it would mention both of them. The intent would not be a MAINTAINERS file which is perfectly human-readable, it would be one which can be efficiently grepped by a helper tool to find the necessary information. When the resulting MAINTAINERS file is built it would include the source Maintainers file for each chunk right before said chunk, for example: [SUSPEND TO RAM] Origin: kernel/power/Maintainers P: Pavel Machek M: [EMAIL PROTECTED] P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Maintained F: kernel/power/* Origin: include/Maintainers F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h (c) You would need a tool to go digging through the built MAINTAINERS file based on a file, an email address, a subsystem-name- regexp, etc. It would return all matching entries, with the desired fields user-selectable. (d) You would need a little tool to poke at git similar to the shell script Linus posted which dug through the recent commit history looking for people doing significant *original* modifications (IE: first person to sign-off) on code for which they aren't a maintainer, as well as Maintainers who haven't recently signed off at all on code for which they are responsible. The output might be something like this: ## Historical significance: 6 months ## Uncategorized file threshold: 10 changes or 20 sign-offs ## New maintainer threshold: 20 changes or 40 sign-offs ## Neglectful-maintainer threshold: 5 changes and 10 sign-offs [SUSPEND TO RAM] Nigel Cunningham should probably be a maintainer: kernel/power/* (130 changes, 132 sign-offs) include/linux/suspend.h (29 changes, 29 sign-offs) [RANDOM UNMAINTAINED DRIVER] J. Random Hacker has neglected his maintainership: drivers/random/unmaintained.c (0 changes, 0 sign-offs) [UNCATEGORIZED] John Linville should probably add/update a Maintainers entry: drivers/wireless/newly_added_driver.c (142 changes and 453 sign- offs) Hopefully that kind of tool would make it a hundred times easier to keep an eye out for out-dated entries as well as missing new entries. The obsolescence-verification would be based on the rapidly- moving git changelog, so it would pick up new maintainers quite quickly, as well as noticing uncategorized source files and neglectful maintainers. Soon as I get moved into my new place I'll see what kind of Perl scripts I can hack up Cheers, Kyle Moffett - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Monday, 13 August 2007 23:21, Joe Perches wrote: > On Mon, 2007-08-13 at 23:25 +0200, Rafael J. Wysocki wrote: > > + include/linux/suspend.h > > + include/linux/freezer.h > > + include/linux/pm.h > > + include/asm-*/suspend.h > > > > Hm, they are also relevant for suspend to RAM, so perhaps one common > > list of files for suspend to RAM and hibernation would be better? > > Maybe just collapse the 2 maintainers blocks into one? > > HIBERNATION (aka Software Suspend, aka swsusp) and SUSPEND TO RAM: > P:Pavel Machek > M:[EMAIL PROTECTED] > P:Rafael J. Wysocki > M:[EMAIL PROTECTED] > L:[EMAIL PROTECTED] > S:Supported Then I think it should be "Maintained". > F:Documentation/power/swsusp* F: Documentation/power/ > F:arch/i386/kernel/acpi/ > F:arch/i386/power/ > F:arch/x86_64/kernel/acpi/ > F:arch/x86_64/kernel/suspend_asm.S > F:arch/x86_64/kernel/suspend.c > F:drivers/base/power/ > F:kernel/power/ > F:include/linux/suspend.h > F:include/linux/freezer.h > F:include/linux/pm.h > F:include/asm-*/suspend.h Pavel, what do you think? -- "Premature optimization is the root of all evil." - Donald Knuth - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Mon, 2007-08-13 at 23:25 +0200, Rafael J. Wysocki wrote: > + include/linux/suspend.h > + include/linux/freezer.h > + include/linux/pm.h > + include/asm-*/suspend.h > > Hm, they are also relevant for suspend to RAM, so perhaps one common > list of files for suspend to RAM and hibernation would be better? Maybe just collapse the 2 maintainers blocks into one? HIBERNATION (aka Software Suspend, aka swsusp) and SUSPEND TO RAM: P: Pavel Machek M: [EMAIL PROTECTED] P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Supported F: Documentation/power/swsusp* F: arch/i386/kernel/acpi/ F: arch/i386/power/ F: arch/x86_64/kernel/acpi/ F: arch/x86_64/kernel/suspend_asm.S F: arch/x86_64/kernel/suspend.c F: drivers/base/power/ F: kernel/power/ F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Monday, 13 August 2007 22:54, Joe Perches wrote: > On Mon, 2007-08-13 at 22:50 +0200, Rafael J. Wysocki wrote: > > Please add > > arch/i386/power/ > > arch/x86_64/kernel/suspend_asm.S > > arch/x86_64/kernel/suspend.c > > drivers/base/power/ > > There also is a couple of headers. Do you want to list them too? > > Your choice. Just let me know. + include/linux/suspend.h + include/linux/freezer.h + include/linux/pm.h + include/asm-*/suspend.h Hm, they are also relevant for suspend to RAM, so perhaps one common list of files for suspend to RAM and hibernation would be better? > HIBERNATION (aka Software Suspend, aka swsusp): > P:Pavel Machek > M:[EMAIL PROTECTED] > P:Rafael J. Wysocki > M:[EMAIL PROTECTED] > L:[EMAIL PROTECTED] > S:Supported > F:Documentation/power/swsusp* > F:arch/i386/power/ > F:arch/x86_64/kernel/suspend* > F:drivers/base/power/ > F:kernel/power/ > > > > > -- "Premature optimization is the root of all evil." - Donald Knuth - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Mon, 2007-08-13 at 22:50 +0200, Rafael J. Wysocki wrote: > Please add > arch/i386/power/ > arch/x86_64/kernel/suspend_asm.S > arch/x86_64/kernel/suspend.c > drivers/base/power/ > There also is a couple of headers. Do you want to list them too? Your choice. Just let me know. HIBERNATION (aka Software Suspend, aka swsusp): P: Pavel Machek M: [EMAIL PROTECTED] P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Supported F: Documentation/power/swsusp* F: arch/i386/power/ F: arch/x86_64/kernel/suspend* F: drivers/base/power/ F: kernel/power/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Monday, 13 August 2007 08:36, [EMAIL PROTECTED] wrote: > Add file pattern to MAINTAINER entry > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > diff --git a/MAINTAINERS b/MAINTAINERS > index 29a2179..5ae90a2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4215,6 +4215,9 @@ P: Rafael J. Wysocki > M: [EMAIL PROTECTED] > L: [EMAIL PROTECTED] > S: Supported > +F: Documentation/power/swsusp* > +F: arch/i386/power/swsusp.S > +F: kernel/power/ Well, the list isn't complete. Please add arch/i386/power/ arch/x86_64/kernel/suspend_asm.S arch/x86_64/kernel/suspend.c drivers/base/power/ There also is a couple of headers. Do you want to list them too? > > SUSPEND TO RAM: > P: Pavel Machek > > Greetings, Rafael -- "Premature optimization is the root of all evil." - Donald Knuth - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
> Add file pattern to MAINTAINER entry > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> ACK. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches [EMAIL PROTECTED] ACK. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Monday, 13 August 2007 08:36, [EMAIL PROTECTED] wrote: Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches [EMAIL PROTECTED] diff --git a/MAINTAINERS b/MAINTAINERS index 29a2179..5ae90a2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4215,6 +4215,9 @@ P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Supported +F: Documentation/power/swsusp* +F: arch/i386/power/swsusp.S +F: kernel/power/ Well, the list isn't complete. Please add arch/i386/power/ arch/x86_64/kernel/suspend_asm.S arch/x86_64/kernel/suspend.c drivers/base/power/ There also is a couple of headers. Do you want to list them too? SUSPEND TO RAM: P: Pavel Machek Greetings, Rafael -- Premature optimization is the root of all evil. - Donald Knuth - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Mon, 2007-08-13 at 22:50 +0200, Rafael J. Wysocki wrote: Please add arch/i386/power/ arch/x86_64/kernel/suspend_asm.S arch/x86_64/kernel/suspend.c drivers/base/power/ There also is a couple of headers. Do you want to list them too? Your choice. Just let me know. HIBERNATION (aka Software Suspend, aka swsusp): P: Pavel Machek M: [EMAIL PROTECTED] P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Supported F: Documentation/power/swsusp* F: arch/i386/power/ F: arch/x86_64/kernel/suspend* F: drivers/base/power/ F: kernel/power/ - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Monday, 13 August 2007 22:54, Joe Perches wrote: On Mon, 2007-08-13 at 22:50 +0200, Rafael J. Wysocki wrote: Please add arch/i386/power/ arch/x86_64/kernel/suspend_asm.S arch/x86_64/kernel/suspend.c drivers/base/power/ There also is a couple of headers. Do you want to list them too? Your choice. Just let me know. + include/linux/suspend.h + include/linux/freezer.h + include/linux/pm.h + include/asm-*/suspend.h Hm, they are also relevant for suspend to RAM, so perhaps one common list of files for suspend to RAM and hibernation would be better? HIBERNATION (aka Software Suspend, aka swsusp): P:Pavel Machek M:[EMAIL PROTECTED] P:Rafael J. Wysocki M:[EMAIL PROTECTED] L:[EMAIL PROTECTED] S:Supported F:Documentation/power/swsusp* F:arch/i386/power/ F:arch/x86_64/kernel/suspend* F:drivers/base/power/ F:kernel/power/ -- Premature optimization is the root of all evil. - Donald Knuth - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Mon, 2007-08-13 at 23:25 +0200, Rafael J. Wysocki wrote: + include/linux/suspend.h + include/linux/freezer.h + include/linux/pm.h + include/asm-*/suspend.h Hm, they are also relevant for suspend to RAM, so perhaps one common list of files for suspend to RAM and hibernation would be better? Maybe just collapse the 2 maintainers blocks into one? HIBERNATION (aka Software Suspend, aka swsusp) and SUSPEND TO RAM: P: Pavel Machek M: [EMAIL PROTECTED] P: Rafael J. Wysocki M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Supported F: Documentation/power/swsusp* F: arch/i386/kernel/acpi/ F: arch/i386/power/ F: arch/x86_64/kernel/acpi/ F: arch/x86_64/kernel/suspend_asm.S F: arch/x86_64/kernel/suspend.c F: drivers/base/power/ F: kernel/power/ F: include/linux/suspend.h F: include/linux/freezer.h F: include/linux/pm.h F: include/asm-*/suspend.h - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):
On Monday, 13 August 2007 23:21, Joe Perches wrote: On Mon, 2007-08-13 at 23:25 +0200, Rafael J. Wysocki wrote: + include/linux/suspend.h + include/linux/freezer.h + include/linux/pm.h + include/asm-*/suspend.h Hm, they are also relevant for suspend to RAM, so perhaps one common list of files for suspend to RAM and hibernation would be better? Maybe just collapse the 2 maintainers blocks into one? HIBERNATION (aka Software Suspend, aka swsusp) and SUSPEND TO RAM: P:Pavel Machek M:[EMAIL PROTECTED] P:Rafael J. Wysocki M:[EMAIL PROTECTED] L:[EMAIL PROTECTED] S:Supported Then I think it should be Maintained. F:Documentation/power/swsusp* F: Documentation/power/ F:arch/i386/kernel/acpi/ F:arch/i386/power/ F:arch/x86_64/kernel/acpi/ F:arch/x86_64/kernel/suspend_asm.S F:arch/x86_64/kernel/suspend.c F:drivers/base/power/ F:kernel/power/ F:include/linux/suspend.h F:include/linux/freezer.h F:include/linux/pm.h F:include/asm-*/suspend.h Pavel, what do you think? -- Premature optimization is the root of all evil. - Donald Knuth - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
