Re: [PATCH] [RESEND] vmscan.c: add a sysctl entry for controlling memory reclaim IO congestion_wait length
On Thu 19-09-19 09:32:48, Lin Feng wrote: > > > On 9/18/19 20:27, Michal Hocko wrote: > > Please do not post a new version with a minor compile fixes until there > > is a general agreement on the approach. Willy had comments which really > > need to be resolved first. > > Sorry, but thanks for pointing out. > > > > > Also does this > > [...] > > > Reported-by: kbuild test robot > > really hold? Because it suggests that the problem has been spotted by > > the kbuild bot which is kinda unexpected... I suspect you have just > > added that for the minor compilation issue that you have fixed since the > > last version. > > Yes, I do know the issue is not reported by the robot, but > just followed the kbuild robot tip, this Reported-by suggested by kbuild robot > seems a little misleading, I'm not sure if it has other meanings. > 'If you fix the issue, kindly add following tag > Reported-by: kbuild test robot ' This would be normally the case for a patch which only fixes the particular issue. You can credit the bot in the changelog while documenting changes between version. -- Michal Hocko SUSE Labs
Re: [PATCH] [RESEND] vmscan.c: add a sysctl entry for controlling memory reclaim IO congestion_wait length
On 9/18/19 20:27, Michal Hocko wrote: Please do not post a new version with a minor compile fixes until there is a general agreement on the approach. Willy had comments which really need to be resolved first. Sorry, but thanks for pointing out. Also does this [...] Reported-by: kbuild test robot really hold? Because it suggests that the problem has been spotted by the kbuild bot which is kinda unexpected... I suspect you have just added that for the minor compilation issue that you have fixed since the last version. Yes, I do know the issue is not reported by the robot, but just followed the kbuild robot tip, this Reported-by suggested by kbuild robot seems a little misleading, I'm not sure if it has other meanings. 'If you fix the issue, kindly add following tag Reported-by: kbuild test robot '
Re: [PATCH] [RESEND] vmscan.c: add a sysctl entry for controlling memory reclaim IO congestion_wait length
Please do not post a new version with a minor compile fixes until there is a general agreement on the approach. Willy had comments which really need to be resolved first. And I do agree with him. Having an explicit tunable seems just wrong. Also does this [...] > Reported-by: kbuild test robot really hold? Because it suggests that the problem has been spotted by the kbuild bot which is kinda unexpected... I suspect you have just added that for the minor compilation issue that you have fixed since the last version. -- Michal Hocko SUSE Labs
