Re: [PATCH] 9p: basic sysfs support

2007-11-02 Thread Greg KH
On Fri, Nov 02, 2007 at 01:14:05PM -0600, Latchesar Ionkov wrote:
> This patch adds only the basic 9p functionality, we use the sysfs
> interface extensively for configuring the 9p in-kernel servers (patch
> 7 in the series). The v9fs filesyste will probably add some more
> subdirectories for authenticating users and mapping user names to
> uids...

Ah, ok.  I don't know your projected time frame for this patch series,
but if it's for 2.6.25, you might want to look at the set of patches I
just sent to lkml to help make files like this easier to create thanks
to the great work from Kay Sievers.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] 9p: basic sysfs support

2007-11-02 Thread Latchesar Ionkov
This patch adds only the basic 9p functionality, we use the sysfs
interface extensively for configuring the 9p in-kernel servers (patch
7 in the series). The v9fs filesyste will probably add some more
subdirectories for authenticating users and mapping user names to
uids...

Thanks,
Lucho

On 11/2/07, Greg KH <[EMAIL PROTECTED]> wrote:
> On Fri, Nov 02, 2007 at 10:53:31AM -0600, Latchesar Ionkov wrote:
> > This patch implements the basic sysfs support for 9p. If CONFIG_NET_9P_DEBUG
> > is defined, allows reading and modifying the debug level via
> > /sysfs/fs/9p/debuglevel.
>
> Since this is a debug-only type file, why not just put it in debugfs
> instead?
>
> And I have a huge patch-series pending that will make adding files like
> this to sysfs much easier in the future.  But nice job, it looks like
> you got it all correct, which is pretty hard to do first time these days
> due to the complexity of the current interface :)
>
> thanks,
>
> greg k-h
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] 9p: basic sysfs support

2007-11-02 Thread Greg KH
On Fri, Nov 02, 2007 at 10:53:31AM -0600, Latchesar Ionkov wrote:
> This patch implements the basic sysfs support for 9p. If CONFIG_NET_9P_DEBUG
> is defined, allows reading and modifying the debug level via
> /sysfs/fs/9p/debuglevel.

Since this is a debug-only type file, why not just put it in debugfs
instead?

And I have a huge patch-series pending that will make adding files like
this to sysfs much easier in the future.  But nice job, it looks like
you got it all correct, which is pretty hard to do first time these days
due to the complexity of the current interface :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/