Re: [PATCH] ACPI: Add phylib support code for mdio
On 2015/12/9 18:31, Yankejian (Hackim Yim) wrote: > > On 2015/12/9 3:55, Al Stone wrote: >> On 12/03/2015 03:47 AM, Graeme Gregory wrote: >>> On Thu, Dec 03, 2015 at 09:54:43AM +0800, yankejian wrote: Add support for getting the PHY devices on an MDIO bus by ACPI. Currently many of the ethernet drivers are open coding a solution for reading data out of ACPI to find the correct PHY device. This patch implements a set of common routines are similar to of_mdio.c >>> The general conclusion for the ACPI on ARM64 discussion so far has been that >>> things like PHYs should be setup by the firmware before the kernel takes >>> control. >>> >>> I am unsure that this doing it the same way as DT with a different >>> description language is the way to go. >>> >>> Graeme >> I have to agree with Graeme: if this is supposed to be an arm64 server using >> ACPI, please make sure the PHYs/clocks/regulators are set up properly before >> passing control to the kernel. That's the consensus so far on how this is to >> be done. >> >> This also looks to be using _DSD in ACPI, which is another topic that's still >> under discussion. What does the ASL look like for these PHYs, as used in >> this >> patch? >> > Hi Al > > The sample of the ASL for these PHYs is below: > > Device (PHY0) { > Name (_DSD, Package () { > > ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > Package () { > Package () {"phy-addr", 0}, > Package () {"ethernet-phy", > "ethernet-phy-ieee802.3-c22"}, > } > }) > } > > Best Regards, > yankejian > Maybe we need to add the ASL for mdio as well, the sample is shown below: Device (MDIO) { Name(_HID, "HISI00B1") Name (_CRS, ResourceTemplate (){ Memory32Fixed (ReadWrite, 0x803c , 0x1) }) Device (PHY0) { Name (_DSD, Package () { ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () {"phy-addr", 0}, Package () {"ethernet-phy", "ethernet-phy-ieee802.3-c22"}, } }) } Device (PHY1) { Name (_DSD, Package () { ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () {"phy-addr", 1}, Package () {"ethernet-phy", "ethernet-phy-ieee802.3-c22"}, } }) } } Best Regards, yankejian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ACPI: Add phylib support code for mdio
On 2015/12/9 3:55, Al Stone wrote: > On 12/03/2015 03:47 AM, Graeme Gregory wrote: >> On Thu, Dec 03, 2015 at 09:54:43AM +0800, yankejian wrote: >>> Add support for getting the PHY devices on an MDIO bus by ACPI. >>> Currently many of the ethernet drivers are open coding a solution >>> for reading data out of ACPI to find the correct PHY device. >>> This patch implements a set of common routines are similar to of_mdio.c >>> >> The general conclusion for the ACPI on ARM64 discussion so far has been that >> things like PHYs should be setup by the firmware before the kernel takes >> control. >> >> I am unsure that this doing it the same way as DT with a different >> description language is the way to go. >> >> Graeme > I have to agree with Graeme: if this is supposed to be an arm64 server using > ACPI, please make sure the PHYs/clocks/regulators are set up properly before > passing control to the kernel. That's the consensus so far on how this is to > be done. > > This also looks to be using _DSD in ACPI, which is another topic that's still > under discussion. What does the ASL look like for these PHYs, as used in this > patch? > Hi Al The sample of the ASL for these PHYs is below: Device (PHY0) { Name (_DSD, Package () { ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () {"phy-addr", 0}, Package () {"ethernet-phy", "ethernet-phy-ieee802.3-c22"}, } }) } Best Regards, yankejian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ACPI: Add phylib support code for mdio
On 2015/12/9 3:55, Al Stone wrote: > On 12/03/2015 03:47 AM, Graeme Gregory wrote: >> On Thu, Dec 03, 2015 at 09:54:43AM +0800, yankejian wrote: >>> Add support for getting the PHY devices on an MDIO bus by ACPI. >>> Currently many of the ethernet drivers are open coding a solution >>> for reading data out of ACPI to find the correct PHY device. >>> This patch implements a set of common routines are similar to of_mdio.c >>> >> The general conclusion for the ACPI on ARM64 discussion so far has been that >> things like PHYs should be setup by the firmware before the kernel takes >> control. >> >> I am unsure that this doing it the same way as DT with a different >> description language is the way to go. >> >> Graeme > I have to agree with Graeme: if this is supposed to be an arm64 server using > ACPI, please make sure the PHYs/clocks/regulators are set up properly before > passing control to the kernel. That's the consensus so far on how this is to > be done. > > This also looks to be using _DSD in ACPI, which is another topic that's still > under discussion. What does the ASL look like for these PHYs, as used in this > patch? > Hi Al The sample of the ASL for these PHYs is below: Device (PHY0) { Name (_DSD, Package () { ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () {"phy-addr", 0}, Package () {"ethernet-phy", "ethernet-phy-ieee802.3-c22"}, } }) } Best Regards, yankejian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ACPI: Add phylib support code for mdio
On 2015/12/9 18:31, Yankejian (Hackim Yim) wrote: > > On 2015/12/9 3:55, Al Stone wrote: >> On 12/03/2015 03:47 AM, Graeme Gregory wrote: >>> On Thu, Dec 03, 2015 at 09:54:43AM +0800, yankejian wrote: Add support for getting the PHY devices on an MDIO bus by ACPI. Currently many of the ethernet drivers are open coding a solution for reading data out of ACPI to find the correct PHY device. This patch implements a set of common routines are similar to of_mdio.c >>> The general conclusion for the ACPI on ARM64 discussion so far has been that >>> things like PHYs should be setup by the firmware before the kernel takes >>> control. >>> >>> I am unsure that this doing it the same way as DT with a different >>> description language is the way to go. >>> >>> Graeme >> I have to agree with Graeme: if this is supposed to be an arm64 server using >> ACPI, please make sure the PHYs/clocks/regulators are set up properly before >> passing control to the kernel. That's the consensus so far on how this is to >> be done. >> >> This also looks to be using _DSD in ACPI, which is another topic that's still >> under discussion. What does the ASL look like for these PHYs, as used in >> this >> patch? >> > Hi Al > > The sample of the ASL for these PHYs is below: > > Device (PHY0) { > Name (_DSD, Package () { > > ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > Package () { > Package () {"phy-addr", 0}, > Package () {"ethernet-phy", > "ethernet-phy-ieee802.3-c22"}, > } > }) > } > > Best Regards, > yankejian > Maybe we need to add the ASL for mdio as well, the sample is shown below: Device (MDIO) { Name(_HID, "HISI00B1") Name (_CRS, ResourceTemplate (){ Memory32Fixed (ReadWrite, 0x803c , 0x1) }) Device (PHY0) { Name (_DSD, Package () { ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () {"phy-addr", 0}, Package () {"ethernet-phy", "ethernet-phy-ieee802.3-c22"}, } }) } Device (PHY1) { Name (_DSD, Package () { ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () {"phy-addr", 1}, Package () {"ethernet-phy", "ethernet-phy-ieee802.3-c22"}, } }) } } Best Regards, yankejian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ACPI: Add phylib support code for mdio
On 12/03/2015 03:47 AM, Graeme Gregory wrote: > On Thu, Dec 03, 2015 at 09:54:43AM +0800, yankejian wrote: >> Add support for getting the PHY devices on an MDIO bus by ACPI. >> Currently many of the ethernet drivers are open coding a solution >> for reading data out of ACPI to find the correct PHY device. >> This patch implements a set of common routines are similar to of_mdio.c >> > > The general conclusion for the ACPI on ARM64 discussion so far has been that > things like PHYs should be setup by the firmware before the kernel takes > control. > > I am unsure that this doing it the same way as DT with a different > description language is the way to go. > > Graeme I have to agree with Graeme: if this is supposed to be an arm64 server using ACPI, please make sure the PHYs/clocks/regulators are set up properly before passing control to the kernel. That's the consensus so far on how this is to be done. This also looks to be using _DSD in ACPI, which is another topic that's still under discussion. What does the ASL look like for these PHYs, as used in this patch? -- ciao, al --- Al Stone Software Engineer Red Hat, Inc. a...@redhat.com --- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ACPI: Add phylib support code for mdio
On 12/03/2015 03:47 AM, Graeme Gregory wrote: > On Thu, Dec 03, 2015 at 09:54:43AM +0800, yankejian wrote: >> Add support for getting the PHY devices on an MDIO bus by ACPI. >> Currently many of the ethernet drivers are open coding a solution >> for reading data out of ACPI to find the correct PHY device. >> This patch implements a set of common routines are similar to of_mdio.c >> > > The general conclusion for the ACPI on ARM64 discussion so far has been that > things like PHYs should be setup by the firmware before the kernel takes > control. > > I am unsure that this doing it the same way as DT with a different > description language is the way to go. > > Graeme I have to agree with Graeme: if this is supposed to be an arm64 server using ACPI, please make sure the PHYs/clocks/regulators are set up properly before passing control to the kernel. That's the consensus so far on how this is to be done. This also looks to be using _DSD in ACPI, which is another topic that's still under discussion. What does the ASL look like for these PHYs, as used in this patch? -- ciao, al --- Al Stone Software Engineer Red Hat, Inc. a...@redhat.com --- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ACPI: Add phylib support code for mdio
On Thu, Dec 03, 2015 at 09:54:43AM +0800, yankejian wrote: > Add support for getting the PHY devices on an MDIO bus by ACPI. > Currently many of the ethernet drivers are open coding a solution > for reading data out of ACPI to find the correct PHY device. > This patch implements a set of common routines are similar to of_mdio.c > The general conclusion for the ACPI on ARM64 discussion so far has been that things like PHYs should be setup by the firmware before the kernel takes control. I am unsure that this doing it the same way as DT with a different description language is the way to go. Graeme > Signed-off-by: yankejian > --- > drivers/acpi/Makefile | 3 + > drivers/acpi/acpi_mdio.c | 263 > ++ > include/linux/acpi_mdio.h | 68 > 3 files changed, 334 insertions(+) > create mode 100644 drivers/acpi/acpi_mdio.c > create mode 100644 include/linux/acpi_mdio.h > > diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile > index 675eaf3..832e7d6 100644 > --- a/drivers/acpi/Makefile > +++ b/drivers/acpi/Makefile > @@ -35,6 +35,7 @@ acpi-y += bus.o glue.o > acpi-y += scan.o > acpi-y += resource.o > acpi-y += acpi_processor.o > +acpi-y += acpi_mdio.o > acpi-y += processor_core.o > acpi-$(CONFIG_ARCH_MIGHT_HAVE_ACPI_PDC) += processor_pdc.o > acpi-y += ec.o > @@ -65,6 +66,7 @@ obj-$(CONFIG_ACPI_BUTTON) += button.o > obj-$(CONFIG_ACPI_FAN) += fan.o > obj-$(CONFIG_ACPI_VIDEO) += video.o > obj-$(CONFIG_ACPI_PCI_SLOT) += pci_slot.o > +obj-$(CONFIG_PCI_MMCONFIG) += mcfg.o > obj-$(CONFIG_ACPI_PROCESSOR) += processor.o > obj-y+= container.o > obj-$(CONFIG_ACPI_THERMAL) += thermal.o > @@ -79,6 +81,7 @@ obj-$(CONFIG_ACPI_EC_DEBUGFS) += ec_sys.o > obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o > obj-$(CONFIG_ACPI_BGRT) += bgrt.o > obj-$(CONFIG_ACPI_CPPC_LIB) += cppc_acpi.o > +obj-$(CONFIG_IORT_TABLE) += iort.o > > # processor has its own "processor." module_param namespace > processor-y := processor_driver.o > diff --git a/drivers/acpi/acpi_mdio.c b/drivers/acpi/acpi_mdio.c > new file mode 100644 > index 000..3a5871d > --- /dev/null > +++ b/drivers/acpi/acpi_mdio.c > @@ -0,0 +1,263 @@ > +/* > + * Copyright (c) 2015 Hisilicon Limited. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +static > +int acpi_mdiobus_register_phy(struct mii_bus *mdio, struct fwnode_handle > *child, > + u32 addr) > +{ > + struct phy_device *phy; > + const char *phy_type; > + bool is_c45; > + int rc; > + > + rc = fwnode_property_read_string(child, "ethernet-phy", _type); > + if (rc < 0) > + return rc; > + > + if (!strncmp(phy_type, "ethernet-phy-ieee802.3-c45", > + sizeof("ethernet-phy-ieee802.3-c45"))) > + is_c45 = 1; > + else if (!strncmp(phy_type, "ethernet-phy-ieee802.3-c22", > + sizeof("ethernet-phy-ieee802.3-c22"))) > + is_c45 = 0; > + else > + return -ENODATA; > + > + phy = get_phy_device(mdio, addr, is_c45); > + if (!phy || IS_ERR(phy)) > + return 1; > + > + /* Associate the fw node with the device structure so it > + * can be looked up later > + */ > + phy->dev.fwnode = child; > + > + if (mdio->irq) > + phy->irq = mdio->irq[addr]; > + > + if (fwnode_property_read_bool(child, "broken-turn-around")) > + mdio->phy_ignore_ta_mask |= 1 << addr; > + > + /* All data is now stored in the phy struct; > + * register it > + */ > + rc = phy_device_register(phy); > + if (rc) { > + phy_device_free(phy); > + return 1; > + } > + > + dev_dbg(>dev, "registered phy at address %i\n", addr); > + > + return 0; > +} > + > +int acpi_mdio_parse_addr(struct device *dev, struct fwnode_handle *fwnode) > +{ > + u32 addr; > + int ret; > + > + ret = fwnode_property_read_u32(fwnode, "phy-addr", ); > + if (ret < 0) { > + dev_err(dev, "has invalid PHY address ret:%d\n", ret); > + return ret; > + } > + > + if (addr >= PHY_MAX_ADDR) { > + dev_err(dev, "PHY address %i is too large\n", addr); > + return -EINVAL; > + } > + > + return addr; > +} >
Re: [PATCH] ACPI: Add phylib support code for mdio
On Thu, Dec 03, 2015 at 09:54:43AM +0800, yankejian wrote: > Add support for getting the PHY devices on an MDIO bus by ACPI. > Currently many of the ethernet drivers are open coding a solution > for reading data out of ACPI to find the correct PHY device. > This patch implements a set of common routines are similar to of_mdio.c > The general conclusion for the ACPI on ARM64 discussion so far has been that things like PHYs should be setup by the firmware before the kernel takes control. I am unsure that this doing it the same way as DT with a different description language is the way to go. Graeme > Signed-off-by: yankejian> --- > drivers/acpi/Makefile | 3 + > drivers/acpi/acpi_mdio.c | 263 > ++ > include/linux/acpi_mdio.h | 68 > 3 files changed, 334 insertions(+) > create mode 100644 drivers/acpi/acpi_mdio.c > create mode 100644 include/linux/acpi_mdio.h > > diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile > index 675eaf3..832e7d6 100644 > --- a/drivers/acpi/Makefile > +++ b/drivers/acpi/Makefile > @@ -35,6 +35,7 @@ acpi-y += bus.o glue.o > acpi-y += scan.o > acpi-y += resource.o > acpi-y += acpi_processor.o > +acpi-y += acpi_mdio.o > acpi-y += processor_core.o > acpi-$(CONFIG_ARCH_MIGHT_HAVE_ACPI_PDC) += processor_pdc.o > acpi-y += ec.o > @@ -65,6 +66,7 @@ obj-$(CONFIG_ACPI_BUTTON) += button.o > obj-$(CONFIG_ACPI_FAN) += fan.o > obj-$(CONFIG_ACPI_VIDEO) += video.o > obj-$(CONFIG_ACPI_PCI_SLOT) += pci_slot.o > +obj-$(CONFIG_PCI_MMCONFIG) += mcfg.o > obj-$(CONFIG_ACPI_PROCESSOR) += processor.o > obj-y+= container.o > obj-$(CONFIG_ACPI_THERMAL) += thermal.o > @@ -79,6 +81,7 @@ obj-$(CONFIG_ACPI_EC_DEBUGFS) += ec_sys.o > obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o > obj-$(CONFIG_ACPI_BGRT) += bgrt.o > obj-$(CONFIG_ACPI_CPPC_LIB) += cppc_acpi.o > +obj-$(CONFIG_IORT_TABLE) += iort.o > > # processor has its own "processor." module_param namespace > processor-y := processor_driver.o > diff --git a/drivers/acpi/acpi_mdio.c b/drivers/acpi/acpi_mdio.c > new file mode 100644 > index 000..3a5871d > --- /dev/null > +++ b/drivers/acpi/acpi_mdio.c > @@ -0,0 +1,263 @@ > +/* > + * Copyright (c) 2015 Hisilicon Limited. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +static > +int acpi_mdiobus_register_phy(struct mii_bus *mdio, struct fwnode_handle > *child, > + u32 addr) > +{ > + struct phy_device *phy; > + const char *phy_type; > + bool is_c45; > + int rc; > + > + rc = fwnode_property_read_string(child, "ethernet-phy", _type); > + if (rc < 0) > + return rc; > + > + if (!strncmp(phy_type, "ethernet-phy-ieee802.3-c45", > + sizeof("ethernet-phy-ieee802.3-c45"))) > + is_c45 = 1; > + else if (!strncmp(phy_type, "ethernet-phy-ieee802.3-c22", > + sizeof("ethernet-phy-ieee802.3-c22"))) > + is_c45 = 0; > + else > + return -ENODATA; > + > + phy = get_phy_device(mdio, addr, is_c45); > + if (!phy || IS_ERR(phy)) > + return 1; > + > + /* Associate the fw node with the device structure so it > + * can be looked up later > + */ > + phy->dev.fwnode = child; > + > + if (mdio->irq) > + phy->irq = mdio->irq[addr]; > + > + if (fwnode_property_read_bool(child, "broken-turn-around")) > + mdio->phy_ignore_ta_mask |= 1 << addr; > + > + /* All data is now stored in the phy struct; > + * register it > + */ > + rc = phy_device_register(phy); > + if (rc) { > + phy_device_free(phy); > + return 1; > + } > + > + dev_dbg(>dev, "registered phy at address %i\n", addr); > + > + return 0; > +} > + > +int acpi_mdio_parse_addr(struct device *dev, struct fwnode_handle *fwnode) > +{ > + u32 addr; > + int ret; > + > + ret = fwnode_property_read_u32(fwnode, "phy-addr", ); > + if (ret < 0) { > + dev_err(dev, "has invalid PHY address ret:%d\n", ret); > + return ret; > + } > + > + if (addr >= PHY_MAX_ADDR) { > + dev_err(dev, "PHY address %i is too large\n", addr); > + return -EINVAL; > + } > + > +
Re: [PATCH] ACPI: Add phylib support code for mdio
Hi yankejian, [auto build test ERROR on pm/linux-next] [also build test ERROR on v4.4-rc3 next-20151202] url: https://github.com/0day-ci/linux/commits/yankejian/ACPI-Add-phylib-support-code-for-mdio/20151203-115039 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: i386-randconfig-i0-201548 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/built-in.o: In function `acpi_mdiobus_register_phy': >> acpi_mdio.c:(.text+0x2de27): undefined reference to `get_phy_device' >> acpi_mdio.c:(.text+0x2de84): undefined reference to `phy_device_register' >> acpi_mdio.c:(.text+0x2de8f): undefined reference to `phy_device_free' drivers/built-in.o: In function `acpi_phy_find_device': >> (.text+0x2dee4): undefined reference to `mdio_bus_type' drivers/built-in.o: In function `acpi_phy_attach': >> (.text+0x2df25): undefined reference to `phy_attach_direct' drivers/built-in.o: In function `acpi_phy_connect': >> (.text+0x2df71): undefined reference to `phy_connect_direct' drivers/built-in.o: In function `acpi_mdiobus_register': >> (.text+0x2e01a): undefined reference to `__mdiobus_register' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: Binary data
Re: [PATCH] ACPI: Add phylib support code for mdio
Hi yankejian, [auto build test ERROR on pm/linux-next] [also build test ERROR on v4.4-rc3 next-20151202] url: https://github.com/0day-ci/linux/commits/yankejian/ACPI-Add-phylib-support-code-for-mdio/20151203-115039 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: i386-randconfig-s1-201548 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> make[3]: *** No rule to make target 'drivers/acpi/mcfg.o', needed by >> 'drivers/acpi/built-in.o'. make[3]: Target '__build' not remade because of errors. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: Binary data
Re: [PATCH] ACPI: Add phylib support code for mdio
Hi yankejian, [auto build test ERROR on pm/linux-next] [also build test ERROR on v4.4-rc3 next-20151202] url: https://github.com/0day-ci/linux/commits/yankejian/ACPI-Add-phylib-support-code-for-mdio/20151203-115039 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: i386-randconfig-s1-201548 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> make[3]: *** No rule to make target 'drivers/acpi/mcfg.o', needed by >> 'drivers/acpi/built-in.o'. make[3]: Target '__build' not remade because of errors. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: Binary data
Re: [PATCH] ACPI: Add phylib support code for mdio
Hi yankejian, [auto build test ERROR on pm/linux-next] [also build test ERROR on v4.4-rc3 next-20151202] url: https://github.com/0day-ci/linux/commits/yankejian/ACPI-Add-phylib-support-code-for-mdio/20151203-115039 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: i386-randconfig-i0-201548 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/built-in.o: In function `acpi_mdiobus_register_phy': >> acpi_mdio.c:(.text+0x2de27): undefined reference to `get_phy_device' >> acpi_mdio.c:(.text+0x2de84): undefined reference to `phy_device_register' >> acpi_mdio.c:(.text+0x2de8f): undefined reference to `phy_device_free' drivers/built-in.o: In function `acpi_phy_find_device': >> (.text+0x2dee4): undefined reference to `mdio_bus_type' drivers/built-in.o: In function `acpi_phy_attach': >> (.text+0x2df25): undefined reference to `phy_attach_direct' drivers/built-in.o: In function `acpi_phy_connect': >> (.text+0x2df71): undefined reference to `phy_connect_direct' drivers/built-in.o: In function `acpi_mdiobus_register': >> (.text+0x2e01a): undefined reference to `__mdiobus_register' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: Binary data