Re: [PATCH] ARM: OMAP2+: Delete an unnecessary kfree() call in omap_hsmmc_pdata_init()
* Ladislav Michl [190827 18:15]: > On Mon, Aug 26, 2019 at 09:20:50AM -0700, Tony Lindgren wrote: > > * Markus Elfring [190826 06:31]: > > > From: Markus Elfring > > > Date: Mon, 26 Aug 2019 15:05:31 +0200 > > > > > > A null pointer would be passed to a call of the function "kfree" directly > > > after a call of the function "kzalloc" failed at one place. > > > Remove this superfluous function call. > > > > > > This issue was detected by using the Coccinelle software. > > > > Applying into omap-for-v5.4/soc thanks. > > Is it really wise touching almost dead code? Last user is pandora board, so > +Cc: Nikolaus Schaller Yeah would be good to finally get rid of that old code. Anyways, I'll keep the $subject patch to cut down on coccinelle produced issue. Regards, Tony
Re: [PATCH] ARM: OMAP2+: Delete an unnecessary kfree() call in omap_hsmmc_pdata_init()
On Mon, Aug 26, 2019 at 09:20:50AM -0700, Tony Lindgren wrote: > * Markus Elfring [190826 06:31]: > > From: Markus Elfring > > Date: Mon, 26 Aug 2019 15:05:31 +0200 > > > > A null pointer would be passed to a call of the function "kfree" directly > > after a call of the function "kzalloc" failed at one place. > > Remove this superfluous function call. > > > > This issue was detected by using the Coccinelle software. > > Applying into omap-for-v5.4/soc thanks. Is it really wise touching almost dead code? Last user is pandora board, so +Cc: Nikolaus Schaller
Re: [PATCH] ARM: OMAP2+: Delete an unnecessary kfree() call in omap_hsmmc_pdata_init()
* Markus Elfring [190826 06:31]: > From: Markus Elfring > Date: Mon, 26 Aug 2019 15:05:31 +0200 > > A null pointer would be passed to a call of the function "kfree" directly > after a call of the function "kzalloc" failed at one place. > Remove this superfluous function call. > > This issue was detected by using the Coccinelle software. Applying into omap-for-v5.4/soc thanks. Tony
