Re: [PATCH] ASoC: fsl: fix allyesconfig build for imx-pcm
On Wednesday 06 February 2013, Shawn Guo wrote: > On Tue, Feb 05, 2013 at 04:42:25PM +, Arnd Bergmann wrote: > > Patch 25b8d314 "ASoC: fsl: fix multiple definition of init_module changed > > the Makefile for imx-pcm.ko to build two modules that both contain the > > imx-pcm.c file, which nicely solves the problem of building both versions > > of the driver as modules, but it causes two new problems: > > > It's my fault, Arnd. The patch 25b8d314 is a crap. Instead of making > the Kconfig even complexer, I chose to revert the patch and do a little > surgery on the code to make it match the Kconfig rational. The fix[1] > should be on the way to mainline now. > > I'm sorry for messing thing up during -rc time. > > Shawn > > [1] http://thread.gmane.org/gmane.linux.alsa.devel/105018 > Ok, again you were faster than I was at finding a solution, and the new one looks good to me. Thanks for taking care of this already, Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ASoC: fsl: fix allyesconfig build for imx-pcm
On Wednesday 06 February 2013, Shawn Guo wrote: On Tue, Feb 05, 2013 at 04:42:25PM +, Arnd Bergmann wrote: Patch 25b8d314 ASoC: fsl: fix multiple definition of init_module changed the Makefile for imx-pcm.ko to build two modules that both contain the imx-pcm.c file, which nicely solves the problem of building both versions of the driver as modules, but it causes two new problems: It's my fault, Arnd. The patch 25b8d314 is a crap. Instead of making the Kconfig even complexer, I chose to revert the patch and do a little surgery on the code to make it match the Kconfig rational. The fix[1] should be on the way to mainline now. I'm sorry for messing thing up during -rc time. Shawn [1] http://thread.gmane.org/gmane.linux.alsa.devel/105018 Ok, again you were faster than I was at finding a solution, and the new one looks good to me. Thanks for taking care of this already, Arnd -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ASoC: fsl: fix allyesconfig build for imx-pcm
On Tue, Feb 05, 2013 at 04:42:25PM +, Arnd Bergmann wrote: > Patch 25b8d314 "ASoC: fsl: fix multiple definition of init_module changed > the Makefile for imx-pcm.ko to build two modules that both contain the > imx-pcm.c file, which nicely solves the problem of building both versions > of the driver as modules, but it causes two new problems: > It's my fault, Arnd. The patch 25b8d314 is a crap. Instead of making the Kconfig even complexer, I chose to revert the patch and do a little surgery on the code to make it match the Kconfig rational. The fix[1] should be on the way to mainline now. I'm sorry for messing thing up during -rc time. Shawn [1] http://thread.gmane.org/gmane.linux.alsa.devel/105018 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ASoC: fsl: fix allyesconfig build for imx-pcm
On Tue, Feb 05, 2013 at 04:42:25PM +, Arnd Bergmann wrote: Patch 25b8d314 ASoC: fsl: fix multiple definition of init_module changed the Makefile for imx-pcm.ko to build two modules that both contain the imx-pcm.c file, which nicely solves the problem of building both versions of the driver as modules, but it causes two new problems: It's my fault, Arnd. The patch 25b8d314 is a crap. Instead of making the Kconfig even complexer, I chose to revert the patch and do a little surgery on the code to make it match the Kconfig rational. The fix[1] should be on the way to mainline now. I'm sorry for messing thing up during -rc time. Shawn [1] http://thread.gmane.org/gmane.linux.alsa.devel/105018 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
