Re: [PATCH] ASoC: rt5677: use more of the volume range from DACs

2019-01-04 Thread Mark Brown
On Fri, Jan 04, 2019 at 01:51:32PM -0700, Ross Zwisler wrote:

> Ping on this patch.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.


signature.asc
Description: PGP signature


Re: [PATCH] ASoC: rt5677: use more of the volume range from DACs

2019-01-04 Thread Ross Zwisler
On Thu, Dec 20, 2018 at 04:25:55PM -0700, Ross Zwisler wrote:
> From: Dylan Reid 
> 
> The DACs volume can go over 0, both according to the data sheet and
> real world testing.  The control can go up to +30dB.
> 
> This was tested by playing audio at full volume on a samus chromebook.
> 
> Signed-off-by: Dylan Reid 
> Reviewed-by: Hsinyu Chao 
> Signed-off-by: Ross Zwisler 

Ping on this patch.