Re: [PATCH] EDAC, sb_edac: Remove VLA usage

2018-03-13 Thread Gustavo A. R. Silva 



On 03/13/2018 05:48 AM, Borislav Petkov wrote:

On Mon, Mar 12, 2018 at 05:52:13PM -0500, Gustavo A. R. Silva wrote:

Do you mean just adding a code comment?


No, I mean

#define MAX_INTERLEAVE (max_t(unsigned int, ARRAY_SIZE(knl_interleave_list), ...

which computes the max of all three array sizes.

Thx.



I got it.

Exactly this:

#define MAX_INTERLEAVE (max_t(unsigned int, 
ARRAY_SIZE(knl_interleave_list),\
max_t(unsigned int, 
ARRAY_SIZE(ibridge_interleave_list),\


ARRAY_SIZE(sbridge_interleave_list


I'll send v2 shortly.

Thanks!
--
Gustavo

Re: [PATCH] EDAC, sb_edac: Remove VLA usage

2018-03-13 Thread Gustavo A. R. Silva 



On 03/13/2018 05:48 AM, Borislav Petkov wrote:

On Mon, Mar 12, 2018 at 05:52:13PM -0500, Gustavo A. R. Silva wrote:

Do you mean just adding a code comment?


No, I mean

#define MAX_INTERLEAVE (max_t(unsigned int, ARRAY_SIZE(knl_interleave_list), ...

which computes the max of all three array sizes.

Thx.



I got it.

Exactly this:

#define MAX_INTERLEAVE (max_t(unsigned int, 
ARRAY_SIZE(knl_interleave_list),\
max_t(unsigned int, 
ARRAY_SIZE(ibridge_interleave_list),\


ARRAY_SIZE(sbridge_interleave_list


I'll send v2 shortly.

Thanks!
--
Gustavo

Re: [PATCH] EDAC, sb_edac: Remove VLA usage

2018-03-13 Thread Borislav Petkov 
On Mon, Mar 12, 2018 at 05:52:13PM -0500, Gustavo A. R. Silva wrote:
> Do you mean just adding a code comment?

No, I mean

#define MAX_INTERLEAVE (max_t(unsigned int, ARRAY_SIZE(knl_interleave_list), ...

which computes the max of all three array sizes.

Thx.

-- 
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH] EDAC, sb_edac: Remove VLA usage

2018-03-13 Thread Borislav Petkov 
On Mon, Mar 12, 2018 at 05:52:13PM -0500, Gustavo A. R. Silva wrote:
> Do you mean just adding a code comment?

No, I mean

#define MAX_INTERLEAVE (max_t(unsigned int, ARRAY_SIZE(knl_interleave_list), ...

which computes the max of all three array sizes.

Thx.

-- 
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH] EDAC, sb_edac: Remove VLA usage

2018-03-12 Thread Gustavo A. R. Silva 

Hi Borislav,

On 03/10/2018 08:04 AM, Borislav Petkov wrote:

On Fri, Mar 09, 2018 at 09:02:18PM -0600, Gustavo A. R. Silva wrote:

In preparation to enabling -Wvla, remove VLA and replace it
with a fixed-length array instead.

Fixed as part of the directive to remove all VLAs from
the kernel: https://lkml.org/lkml/2018/3/7/621

Signed-off-by: Gustavo A. R. Silva 
---

Notice that due to this change, the field max_interleave is no longer
used after it has been initialized. Maybe it should be removed?


Yes.



I'll remove it then.


@@ -110,6 +110,7 @@ static const u32 knl_interleave_list[] = {
0xdc, 0xe4, 0xec, 0xf4, 0xfc, /* 15-19 */
0x104, 0x10c, 0x114, 0x11c,   /* 20-23 */
  };
+#define MAX_INTERLEAVE ARRAY_SIZE(knl_interleave_list)


define that as the max of all interleave lists array sizes so that
people can update it properly when new interleave lists get added.



Do you mean just adding a code comment?

Thanks for the feedback.
--
Gustavo

Re: [PATCH] EDAC, sb_edac: Remove VLA usage

2018-03-12 Thread Gustavo A. R. Silva 

Hi Borislav,

On 03/10/2018 08:04 AM, Borislav Petkov wrote:

On Fri, Mar 09, 2018 at 09:02:18PM -0600, Gustavo A. R. Silva wrote:

In preparation to enabling -Wvla, remove VLA and replace it
with a fixed-length array instead.

Fixed as part of the directive to remove all VLAs from
the kernel: https://lkml.org/lkml/2018/3/7/621

Signed-off-by: Gustavo A. R. Silva 
---

Notice that due to this change, the field max_interleave is no longer
used after it has been initialized. Maybe it should be removed?


Yes.



I'll remove it then.


@@ -110,6 +110,7 @@ static const u32 knl_interleave_list[] = {
0xdc, 0xe4, 0xec, 0xf4, 0xfc, /* 15-19 */
0x104, 0x10c, 0x114, 0x11c,   /* 20-23 */
  };
+#define MAX_INTERLEAVE ARRAY_SIZE(knl_interleave_list)


define that as the max of all interleave lists array sizes so that
people can update it properly when new interleave lists get added.



Do you mean just adding a code comment?

Thanks for the feedback.
--
Gustavo

Re: [PATCH] EDAC, sb_edac: Remove VLA usage

2018-03-10 Thread Borislav Petkov 
On Fri, Mar 09, 2018 at 09:02:18PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wvla, remove VLA and replace it
> with a fixed-length array instead.
> 
> Fixed as part of the directive to remove all VLAs from
> the kernel: https://lkml.org/lkml/2018/3/7/621
> 
> Signed-off-by: Gustavo A. R. Silva 
> ---
> 
> Notice that due to this change, the field max_interleave is no longer
> used after it has been initialized. Maybe it should be removed?

Yes.

> @@ -110,6 +110,7 @@ static const u32 knl_interleave_list[] = {
>   0xdc, 0xe4, 0xec, 0xf4, 0xfc, /* 15-19 */
>   0x104, 0x10c, 0x114, 0x11c,   /* 20-23 */
>  };
> +#define MAX_INTERLEAVE   ARRAY_SIZE(knl_interleave_list)

define that as the max of all interleave lists array sizes so that
people can update it properly when new interleave lists get added.

-- 
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH] EDAC, sb_edac: Remove VLA usage

2018-03-10 Thread Borislav Petkov 
On Fri, Mar 09, 2018 at 09:02:18PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wvla, remove VLA and replace it
> with a fixed-length array instead.
> 
> Fixed as part of the directive to remove all VLAs from
> the kernel: https://lkml.org/lkml/2018/3/7/621
> 
> Signed-off-by: Gustavo A. R. Silva 
> ---
> 
> Notice that due to this change, the field max_interleave is no longer
> used after it has been initialized. Maybe it should be removed?

Yes.

> @@ -110,6 +110,7 @@ static const u32 knl_interleave_list[] = {
>   0xdc, 0xe4, 0xec, 0xf4, 0xfc, /* 15-19 */
>   0x104, 0x10c, 0x114, 0x11c,   /* 20-23 */
>  };
> +#define MAX_INTERLEAVE   ARRAY_SIZE(knl_interleave_list)

define that as the max of all interleave lists array sizes so that
people can update it properly when new interleave lists get added.

-- 
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.