Re: [PATCH] HID: core: clean up indentation issue
On Wed, Sep 25, 2019 at 1:48 PM Dan Carpenter wrote:
>
> On Mon, Sep 23, 2019 at 01:04:13PM +0200, Jiri Kosina wrote:
> > On Sun, 22 Sep 2019, Colin King wrote:
> >
> > > From: Colin Ian King
> > >
> > > There is an if statement that is indented by one extra space,
> > > fix this by removing the extraneous space.
> > >
> > > Signed-off-by: Colin Ian King
> > > ---
> > > drivers/hid/hid-core.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> > > index 3eaee2c37931..9469c382a182 100644
> > > --- a/drivers/hid/hid-core.c
> > > +++ b/drivers/hid/hid-core.c
> > > @@ -2329,10 +2329,10 @@ int hid_add_device(struct hid_device *hdev)
> > > /*
> > > * Check for the mandatory transport channel.
> > > */
> > > -if (!hdev->ll_driver->raw_request) {
> > > + if (!hdev->ll_driver->raw_request) {
> > > hid_err(hdev, "transport driver missing .raw_request()\n");
> > > return -EINVAL;
> > > -}
> > > + }
> >
> > Let's not pollute git blame and wait for an ocasion when we need to touch
> > the code for some more valid reason.
>
> Just use `git blame -w`.
>
> This probably came from a Smatch warning. Smatch warns very seldom
> warns about style issues, but in this case the indenting is legitimately
> bad.
Well, I tend to agree with Jiri here. Yes, you can use a particular
flag in a tool to 'solve' the git blame/history issue, but this is
putting the workload on the user, while tthe code is fine, in this
case. Why do we need to pollute the history of a file for no good
reasons?
Cheers,
Benjamin
Re: [PATCH] HID: core: clean up indentation issue
On Mon, Sep 23, 2019 at 01:04:13PM +0200, Jiri Kosina wrote:
> On Sun, 22 Sep 2019, Colin King wrote:
>
> > From: Colin Ian King
> >
> > There is an if statement that is indented by one extra space,
> > fix this by removing the extraneous space.
> >
> > Signed-off-by: Colin Ian King
> > ---
> > drivers/hid/hid-core.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> > index 3eaee2c37931..9469c382a182 100644
> > --- a/drivers/hid/hid-core.c
> > +++ b/drivers/hid/hid-core.c
> > @@ -2329,10 +2329,10 @@ int hid_add_device(struct hid_device *hdev)
> > /*
> > * Check for the mandatory transport channel.
> > */
> > -if (!hdev->ll_driver->raw_request) {
> > + if (!hdev->ll_driver->raw_request) {
> > hid_err(hdev, "transport driver missing .raw_request()\n");
> > return -EINVAL;
> > -}
> > + }
>
> Let's not pollute git blame and wait for an ocasion when we need to touch
> the code for some more valid reason.
Just use `git blame -w`.
This probably came from a Smatch warning. Smatch warns very seldom
warns about style issues, but in this case the indenting is legitimately
bad.
regards,
dan carpenter
Re: [PATCH] HID: core: clean up indentation issue
On Sun, 22 Sep 2019, Colin King wrote:
> From: Colin Ian King
>
> There is an if statement that is indented by one extra space,
> fix this by removing the extraneous space.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/hid/hid-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 3eaee2c37931..9469c382a182 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -2329,10 +2329,10 @@ int hid_add_device(struct hid_device *hdev)
> /*
>* Check for the mandatory transport channel.
>*/
> - if (!hdev->ll_driver->raw_request) {
> + if (!hdev->ll_driver->raw_request) {
> hid_err(hdev, "transport driver missing .raw_request()\n");
> return -EINVAL;
> - }
> + }
Let's not pollute git blame and wait for an ocasion when we need to touch
the code for some more valid reason.
Thanks,
--
Jiri Kosina
SUSE Labs
