Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable
On Mon, Apr 16, 2018 at 01:56:20AM -0700, Christoph Hellwig wrote: > On Mon, Apr 16, 2018 at 04:02:12AM +, Greg Thelen wrote: > > I think I've identified the set of options which use > > INFINIBAND_ADDR_TRANS without a kconfig depends: > > * CIFS_SMB_DIRECT > > * INFINIBAND_SRPT > > * NVME_RDMA > > * NVME_TARGET_RDMA > > > > I have patches for the above, but need to finish the commit logs. Let me > > know if they'll be nacked and I'll just patch my kernel and forget > > upstreaming. > > I think those are what is needed. But better do a full cycle through > the build bot first.. Yes, you have to post the full series and have the build bots say it is clean, collect acks from the various maintainers and then we can apply the whole thing through RDMA.. I n't want to apply kconfig changes piecemeal, we just get bug reports from build bots that way. Jason
Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable
在 2018/4/13 20:47, Bart Van Assche 写道:
> On Fri, 2018-04-13 at 00:06 -0700, Greg Thelen wrote:
>> Allow INFINIBAND without INFINIBAND_ADDR_TRANS.
>>
>> Signed-off-by: Greg Thelen
>> Cc: Tarick Bedeir
>> ---
>> drivers/infiniband/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
>> index ee270e065ba9..f20a3977087c 100644
>> --- a/drivers/infiniband/Kconfig
>> +++ b/drivers/infiniband/Kconfig
>> @@ -61,7 +61,7 @@ config INFINIBAND_ON_DEMAND_PAGING
>>pages on demand instead.
>>
>> config INFINIBAND_ADDR_TRANS
>> -bool
>> +bool "InfiniBand address translation"
>> depends on INFINIBAND
>> default y
>
> Hello Greg,
>
> Please change the short description from "InfiniBand address translation"
> (which
> is a misleading description) into "RDMA/CM". Please also add a help text that
> explains to people who are not RDMA experts what the RDMA/CM is.
>
> Thanks,
>
> Bart.
>
Hi, Bart
We need to select the INFINIBAND without INFINIBAND_ADDR_TRANS if use cm for
others?
Thanks
Lijun Ou
>
>
> �{.n�+���+%��lzwm��b�맲��r��zX��ݙ�����ܨ}���Ơz�&j:+v���zZ+��+zf���h���~i���z� �w���?&�)ߢf
>
Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable
On Mon, Apr 16, 2018 at 04:02:12AM +, Greg Thelen wrote: > I think I've identified the set of options which use > INFINIBAND_ADDR_TRANS without a kconfig depends: > * CIFS_SMB_DIRECT > * INFINIBAND_SRPT > * NVME_RDMA > * NVME_TARGET_RDMA > > I have patches for the above, but need to finish the commit logs. Let me > know if they'll be nacked and I'll just patch my kernel and forget > upstreaming. I think those are what is needed. But better do a full cycle through the build bot first.. Btw, should we rename the config symbol to something containing RDMACM? The current name seems rather confusing?
Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable
On Sun, Apr 15, 2018 at 5:06 AM Christoph Hellwig wrote: > On Fri, Apr 13, 2018 at 12:06:44AM -0700, Greg Thelen wrote: > > Allow INFINIBAND without INFINIBAND_ADDR_TRANS. > Why? We are pushing everyone heavily to use RDMA/CM, so making it > optional seems rather counter-intuitive. Bugs. We don't currently use CM. But fuzzy testing has been finding a fair number CM bugs, so we were thinking of disabling it until we need it. > You'll also have to fix tons of ULPs to explicitly depend on > INFINIBAND_ADDR_TRANS, or make code conditional on it. I think I've identified the set of options which use INFINIBAND_ADDR_TRANS without a kconfig depends: * CIFS_SMB_DIRECT * INFINIBAND_SRPT * NVME_RDMA * NVME_TARGET_RDMA I have patches for the above, but need to finish the commit logs. Let me know if they'll be nacked and I'll just patch my kernel and forget upstreaming.
Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable
On Fri, Apr 13, 2018 at 12:06:44AM -0700, Greg Thelen wrote: > Allow INFINIBAND without INFINIBAND_ADDR_TRANS. Why? We are pushing everyone heavily to use RDMA/CM, so making it optional seems rather counter-intuitive. You'll also have to fix tons of ULPs to explicitly depend on INFINIBAND_ADDR_TRANS, or make code conditional on it.
Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable
On Fri, 2018-04-13 at 00:06 -0700, Greg Thelen wrote: > Allow INFINIBAND without INFINIBAND_ADDR_TRANS. > > Signed-off-by: Greg Thelen > Cc: Tarick Bedeir > --- > drivers/infiniband/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig > index ee270e065ba9..f20a3977087c 100644 > --- a/drivers/infiniband/Kconfig > +++ b/drivers/infiniband/Kconfig > @@ -61,7 +61,7 @@ config INFINIBAND_ON_DEMAND_PAGING > pages on demand instead. > > config INFINIBAND_ADDR_TRANS > - bool > + bool "InfiniBand address translation" > depends on INFINIBAND > default y Hello Greg, Please change the short description from "InfiniBand address translation" (which is a misleading description) into "RDMA/CM". Please also add a help text that explains to people who are not RDMA experts what the RDMA/CM is. Thanks, Bart.
