Re: [PATCH] PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected (was: Re: [PATCH] PM / domains: Kconfig: always enable PM_RUNTIME when genpd enabled)
On Tuesday, November 18, 2014 09:34:11 AM Pavel Machek wrote: > On Tue 2014-11-18 01:39:06, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > The number of and dependencies between high-level power management > > Kconfig options make life much harder than necessary. Several > > conbinations of them have to be tested and supported, even though > > some of those combinations are very rarely used in practice (it > > they are used in practice at all). Moreover, the fact that we > > have separate independent Kconfig options for runtime PM and > > system suspend is a serious obscacle for integration between > > the two frameworks. > > > > To overcome these difficulties, always select PM_RUNTIME if PM_SLEEP > > is set. Among other things, this will allow system suspend callbacks > > provided by bus types and device drivers to rely on the runtime PM > > framework regardless of the kernel configuration. > > 3.18-rc5 still has: > > config PM_RUNTIME > bool "Run-time PM core functionality" > depends on !IA64_HP_SIM > ---help--- > > So I assume this patch is against tree where PM_RUNTIME does not > depend on anything? Yes. > > Signed-off-by: Rafael J. Wysocki > > --- > > > > As a follow up. > > > > Note that we won't need the patch making genpd select PM_RUNTIME with this, > > because genpd already depends on PM. > > Looking through the config file, there are more config options that > should be stripped. > > config SUSPEND_FREEZER > bool "Enable freezer for suspend to RAM/standby" \ > "Turning OFF this setting is NOT recommended! If in doubt, say Y." Yeah, I'll gladly apply a patch removing this one. :-) > config HIBERNATE_CALLBACKS >bool > > ...can we just use CONFIG_HIBERNATE, instead? We do, but in addition. HIBERNATE_CALLBACKS is used by Xen IIRC and they don't want to build in the whole hibernation image creation etc code (which they never use anyway). Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected (was: Re: [PATCH] PM / domains: Kconfig: always enable PM_RUNTIME when genpd enabled)
On Tue 2014-11-18 01:39:06, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The number of and dependencies between high-level power management > Kconfig options make life much harder than necessary. Several > conbinations of them have to be tested and supported, even though > some of those combinations are very rarely used in practice (it > they are used in practice at all). Moreover, the fact that we > have separate independent Kconfig options for runtime PM and > system suspend is a serious obscacle for integration between > the two frameworks. > > To overcome these difficulties, always select PM_RUNTIME if PM_SLEEP > is set. Among other things, this will allow system suspend callbacks > provided by bus types and device drivers to rely on the runtime PM > framework regardless of the kernel configuration. 3.18-rc5 still has: config PM_RUNTIME bool "Run-time PM core functionality" depends on !IA64_HP_SIM ---help--- So I assume this patch is against tree where PM_RUNTIME does not depend on anything? > Signed-off-by: Rafael J. Wysocki > --- > > As a follow up. > > Note that we won't need the patch making genpd select PM_RUNTIME with this, > because genpd already depends on PM. Looking through the config file, there are more config options that should be stripped. config SUSPEND_FREEZER bool "Enable freezer for suspend to RAM/standby" \ "Turning OFF this setting is NOT recommended! If in doubt, say Y." config HIBERNATE_CALLBACKS bool ...can we just use CONFIG_HIBERNATE, instead? > === > --- linux-pm.orig/kernel/power/Kconfig > +++ linux-pm/kernel/power/Kconfig > @@ -94,6 +94,7 @@ config PM_STD_PARTITION > config PM_SLEEP > def_bool y > depends on SUSPEND || HIBERNATE_CALLBACKS > + select PM_RUNTIME > > config PM_SLEEP_SMP > def_bool y Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected
On Tue, Nov 18, 2014 at 4:52 AM, Kevin Hilman wrote:
> "Rafael J. Wysocki" writes:
>
>> From: Rafael J. Wysocki
>>
>> The number of and dependencies between high-level power management
>> Kconfig options make life much harder than necessary. Several
>> conbinations of them have to be tested and supported, even though
>> some of those combinations are very rarely used in practice (it
>> they are used in practice at all). Moreover, the fact that we
>> have separate independent Kconfig options for runtime PM and
>> system suspend is a serious obscacle for integration between
>> the two frameworks.
>>
>> To overcome these difficulties, always select PM_RUNTIME if PM_SLEEP
>> is set. Among other things, this will allow system suspend callbacks
>> provided by bus types and device drivers to rely on the runtime PM
>> framework regardless of the kernel configuration.
>>
>> Signed-off-by: Rafael J. Wysocki
>> ---
>>
>> As a follow up.
>>
>> Note that we won't need the patch making genpd select PM_RUNTIME with this,
>> because genpd already depends on PM.
>>
>> Thoughts, comments?
>
> Acked-by: Kevin Hilman
This gets rid of
kernel/power/Kconfig:132:error: recursive dependency detected!
kernel/power/Kconfig:132: symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS
kernel/power/Kconfig:272: symbol PM_GENERIC_DOMAINS is selected by PM_RUNTIME
Tested-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected (was: Re: [PATCH] PM / domains: Kconfig: always enable PM_RUNTIME when genpd enabled)
On Tuesday, November 18, 2014 09:34:11 AM Pavel Machek wrote: On Tue 2014-11-18 01:39:06, Rafael J. Wysocki wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com The number of and dependencies between high-level power management Kconfig options make life much harder than necessary. Several conbinations of them have to be tested and supported, even though some of those combinations are very rarely used in practice (it they are used in practice at all). Moreover, the fact that we have separate independent Kconfig options for runtime PM and system suspend is a serious obscacle for integration between the two frameworks. To overcome these difficulties, always select PM_RUNTIME if PM_SLEEP is set. Among other things, this will allow system suspend callbacks provided by bus types and device drivers to rely on the runtime PM framework regardless of the kernel configuration. 3.18-rc5 still has: config PM_RUNTIME bool Run-time PM core functionality depends on !IA64_HP_SIM ---help--- So I assume this patch is against tree where PM_RUNTIME does not depend on anything? Yes. Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com --- As a follow up. Note that we won't need the patch making genpd select PM_RUNTIME with this, because genpd already depends on PM. Looking through the config file, there are more config options that should be stripped. config SUSPEND_FREEZER bool Enable freezer for suspend to RAM/standby \ Turning OFF this setting is NOT recommended! If in doubt, say Y. Yeah, I'll gladly apply a patch removing this one. :-) config HIBERNATE_CALLBACKS bool ...can we just use CONFIG_HIBERNATE, instead? We do, but in addition. HIBERNATE_CALLBACKS is used by Xen IIRC and they don't want to build in the whole hibernation image creation etc code (which they never use anyway). Rafael -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected
On Tue, Nov 18, 2014 at 4:52 AM, Kevin Hilman khil...@kernel.org wrote:
Rafael J. Wysocki r...@rjwysocki.net writes:
From: Rafael J. Wysocki rafael.j.wyso...@intel.com
The number of and dependencies between high-level power management
Kconfig options make life much harder than necessary. Several
conbinations of them have to be tested and supported, even though
some of those combinations are very rarely used in practice (it
they are used in practice at all). Moreover, the fact that we
have separate independent Kconfig options for runtime PM and
system suspend is a serious obscacle for integration between
the two frameworks.
To overcome these difficulties, always select PM_RUNTIME if PM_SLEEP
is set. Among other things, this will allow system suspend callbacks
provided by bus types and device drivers to rely on the runtime PM
framework regardless of the kernel configuration.
Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com
---
As a follow up.
Note that we won't need the patch making genpd select PM_RUNTIME with this,
because genpd already depends on PM.
Thoughts, comments?
Acked-by: Kevin Hilman khil...@linaro.org
This gets rid of
kernel/power/Kconfig:132:error: recursive dependency detected!
kernel/power/Kconfig:132: symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS
kernel/power/Kconfig:272: symbol PM_GENERIC_DOMAINS is selected by PM_RUNTIME
Tested-by: Geert Uytterhoeven geert+rene...@glider.be
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected (was: Re: [PATCH] PM / domains: Kconfig: always enable PM_RUNTIME when genpd enabled)
On Tue 2014-11-18 01:39:06, Rafael J. Wysocki wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com The number of and dependencies between high-level power management Kconfig options make life much harder than necessary. Several conbinations of them have to be tested and supported, even though some of those combinations are very rarely used in practice (it they are used in practice at all). Moreover, the fact that we have separate independent Kconfig options for runtime PM and system suspend is a serious obscacle for integration between the two frameworks. To overcome these difficulties, always select PM_RUNTIME if PM_SLEEP is set. Among other things, this will allow system suspend callbacks provided by bus types and device drivers to rely on the runtime PM framework regardless of the kernel configuration. 3.18-rc5 still has: config PM_RUNTIME bool Run-time PM core functionality depends on !IA64_HP_SIM ---help--- So I assume this patch is against tree where PM_RUNTIME does not depend on anything? Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com --- As a follow up. Note that we won't need the patch making genpd select PM_RUNTIME with this, because genpd already depends on PM. Looking through the config file, there are more config options that should be stripped. config SUSPEND_FREEZER bool Enable freezer for suspend to RAM/standby \ Turning OFF this setting is NOT recommended! If in doubt, say Y. config HIBERNATE_CALLBACKS bool ...can we just use CONFIG_HIBERNATE, instead? === --- linux-pm.orig/kernel/power/Kconfig +++ linux-pm/kernel/power/Kconfig @@ -94,6 +94,7 @@ config PM_STD_PARTITION config PM_SLEEP def_bool y depends on SUSPEND || HIBERNATE_CALLBACKS + select PM_RUNTIME config PM_SLEEP_SMP def_bool y Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected
"Rafael J. Wysocki" writes: > From: Rafael J. Wysocki > > The number of and dependencies between high-level power management > Kconfig options make life much harder than necessary. Several > conbinations of them have to be tested and supported, even though > some of those combinations are very rarely used in practice (it > they are used in practice at all). Moreover, the fact that we > have separate independent Kconfig options for runtime PM and > system suspend is a serious obscacle for integration between > the two frameworks. > > To overcome these difficulties, always select PM_RUNTIME if PM_SLEEP > is set. Among other things, this will allow system suspend callbacks > provided by bus types and device drivers to rely on the runtime PM > framework regardless of the kernel configuration. > > Signed-off-by: Rafael J. Wysocki > --- > > As a follow up. > > Note that we won't need the patch making genpd select PM_RUNTIME with this, > because genpd already depends on PM. > > Thoughts, comments? Acked-by: Kevin Hilman ...with dancing and singing in the streets (or more my speed: a celebratory beer.) Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected
Rafael J. Wysocki r...@rjwysocki.net writes: From: Rafael J. Wysocki rafael.j.wyso...@intel.com The number of and dependencies between high-level power management Kconfig options make life much harder than necessary. Several conbinations of them have to be tested and supported, even though some of those combinations are very rarely used in practice (it they are used in practice at all). Moreover, the fact that we have separate independent Kconfig options for runtime PM and system suspend is a serious obscacle for integration between the two frameworks. To overcome these difficulties, always select PM_RUNTIME if PM_SLEEP is set. Among other things, this will allow system suspend callbacks provided by bus types and device drivers to rely on the runtime PM framework regardless of the kernel configuration. Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com --- As a follow up. Note that we won't need the patch making genpd select PM_RUNTIME with this, because genpd already depends on PM. Thoughts, comments? Acked-by: Kevin Hilman khil...@linaro.org ...with dancing and singing in the streets (or more my speed: a celebratory beer.) Kevin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
