Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
On 10-04-17, 08:45, Krzysztof Kozlowski wrote: > Yes, keeping both make most sense, I think. > > Anyway, I found now the original report thread of Masahiro and I see > Mark's response about using '-'. In that case I am fine with this. I > would prefer to take only the exynos part (separated to ARMv7 and > ARMv8) through my tree but I already sent a pull request so I am fine > with this going directly to arm-soc. This may end up going via the PM tree. > I think you need to update also: > Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt Oops. I searched for opp@ and missed the complex ones. There are some DT files as well for TI which I missed. Will send a V2 with all that fixed. > With that change: > Reviewed-by: Krzysztof Kozlowski> (and implied acked-by) Thanks. -- viresh
Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
On 10-04-17, 08:45, Krzysztof Kozlowski wrote: > Yes, keeping both make most sense, I think. > > Anyway, I found now the original report thread of Masahiro and I see > Mark's response about using '-'. In that case I am fine with this. I > would prefer to take only the exynos part (separated to ARMv7 and > ARMv8) through my tree but I already sent a pull request so I am fine > with this going directly to arm-soc. This may end up going via the PM tree. > I think you need to update also: > Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt Oops. I searched for opp@ and missed the complex ones. There are some DT files as well for TI which I missed. Will send a V2 with all that fixed. > With that change: > Reviewed-by: Krzysztof Kozlowski > (and implied acked-by) Thanks. -- viresh
Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
On Mon, Apr 10, 2017 at 8:32 AM, Viresh Kumarwrote: > On 10-04-17, 15:30, Masahiro Yamada wrote: >> 2017-04-10 15:22 GMT+09:00 Viresh Kumar : >> > On 10-04-17, 10:46, Viresh Kumar wrote: >> >> Compiling the DT file with W=1, DTC warns like follows: >> >> >> >> Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a >> >> unit name, but no reg property >> >> >> >> Fix this by replacing '@' with '-' as the OPP nodes will never have a >> >> "reg" property. >> >> >> >> Reported-by: Masahiro Yamada >> >> Signed-off-by: Viresh Kumar >> > >> > + Reported-by: Krzysztof Kozlowski >> > >> > -- >> > viresh >> >> >> Given that this had already been reported one year before, >> the reported-by credit should be given to Krzysztof. >> >> Please drop my Reported-by. > > I don't think we need to drop any of you. We can very well keep both > :) Yes, keeping both make most sense, I think. Anyway, I found now the original report thread of Masahiro and I see Mark's response about using '-'. In that case I am fine with this. I would prefer to take only the exynos part (separated to ARMv7 and ARMv8) through my tree but I already sent a pull request so I am fine with this going directly to arm-soc. I think you need to update also: Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt With that change: Reviewed-by: Krzysztof Kozlowski (and implied acked-by) Best regards, Krzysztof
Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
On Mon, Apr 10, 2017 at 8:32 AM, Viresh Kumar wrote: > On 10-04-17, 15:30, Masahiro Yamada wrote: >> 2017-04-10 15:22 GMT+09:00 Viresh Kumar : >> > On 10-04-17, 10:46, Viresh Kumar wrote: >> >> Compiling the DT file with W=1, DTC warns like follows: >> >> >> >> Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a >> >> unit name, but no reg property >> >> >> >> Fix this by replacing '@' with '-' as the OPP nodes will never have a >> >> "reg" property. >> >> >> >> Reported-by: Masahiro Yamada >> >> Signed-off-by: Viresh Kumar >> > >> > + Reported-by: Krzysztof Kozlowski >> > >> > -- >> > viresh >> >> >> Given that this had already been reported one year before, >> the reported-by credit should be given to Krzysztof. >> >> Please drop my Reported-by. > > I don't think we need to drop any of you. We can very well keep both > :) Yes, keeping both make most sense, I think. Anyway, I found now the original report thread of Masahiro and I see Mark's response about using '-'. In that case I am fine with this. I would prefer to take only the exynos part (separated to ARMv7 and ARMv8) through my tree but I already sent a pull request so I am fine with this going directly to arm-soc. I think you need to update also: Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt With that change: Reviewed-by: Krzysztof Kozlowski (and implied acked-by) Best regards, Krzysztof
Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
Hi, On 2017년 04월 10일 14:16, Viresh Kumar wrote: > Compiling the DT file with W=1, DTC warns like follows: > > Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a > unit name, but no reg property > > Fix this by replacing '@' with '-' as the OPP nodes will never have a > "reg" property. > > Reported-by: Masahiro Yamada> Signed-off-by: Viresh Kumar > --- > .../devicetree/bindings/devfreq/exynos-bus.txt | 46 +++ > Documentation/devicetree/bindings/opp/opp.txt | 38 ++--- > arch/arm/boot/dts/exynos3250.dtsi | 46 +++ > arch/arm/boot/dts/exynos4210.dtsi | 32 +-- > arch/arm/boot/dts/exynos4412-prime.dtsi| 4 +- > arch/arm/boot/dts/exynos4412.dtsi | 66 > +++--- > arch/arm/boot/dts/exynos5420.dtsi | 40 ++--- > arch/arm/boot/dts/exynos5800.dtsi | 56 +- > arch/arm/boot/dts/pxa25x.dtsi | 8 +-- > arch/arm/boot/dts/pxa27x.dtsi | 14 ++--- > arch/arm/boot/dts/sun8i-a33.dtsi | 8 +-- > arch/arm/boot/dts/uniphier-pro5.dtsi | 32 +-- > arch/arm/boot/dts/uniphier-pxs2.dtsi | 16 +++--- > arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi | 48 > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 50 > arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi | 14 ++--- > arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 32 +-- > arch/arm64/boot/dts/zte/zx296718.dtsi | 10 ++-- > 18 files changed, 280 insertions(+), 280 deletions(-) > Reviewed-by: Chanwoo Choi [snip] -- Best Regards, Chanwoo Choi Samsung Electronics
Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
Hi, On 2017년 04월 10일 14:16, Viresh Kumar wrote: > Compiling the DT file with W=1, DTC warns like follows: > > Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a > unit name, but no reg property > > Fix this by replacing '@' with '-' as the OPP nodes will never have a > "reg" property. > > Reported-by: Masahiro Yamada > Signed-off-by: Viresh Kumar > --- > .../devicetree/bindings/devfreq/exynos-bus.txt | 46 +++ > Documentation/devicetree/bindings/opp/opp.txt | 38 ++--- > arch/arm/boot/dts/exynos3250.dtsi | 46 +++ > arch/arm/boot/dts/exynos4210.dtsi | 32 +-- > arch/arm/boot/dts/exynos4412-prime.dtsi| 4 +- > arch/arm/boot/dts/exynos4412.dtsi | 66 > +++--- > arch/arm/boot/dts/exynos5420.dtsi | 40 ++--- > arch/arm/boot/dts/exynos5800.dtsi | 56 +- > arch/arm/boot/dts/pxa25x.dtsi | 8 +-- > arch/arm/boot/dts/pxa27x.dtsi | 14 ++--- > arch/arm/boot/dts/sun8i-a33.dtsi | 8 +-- > arch/arm/boot/dts/uniphier-pro5.dtsi | 32 +-- > arch/arm/boot/dts/uniphier-pxs2.dtsi | 16 +++--- > arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi | 48 > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 50 > arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi | 14 ++--- > arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 32 +-- > arch/arm64/boot/dts/zte/zx296718.dtsi | 10 ++-- > 18 files changed, 280 insertions(+), 280 deletions(-) > Reviewed-by: Chanwoo Choi [snip] -- Best Regards, Chanwoo Choi Samsung Electronics
Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
On 10-04-17, 15:30, Masahiro Yamada wrote: > 2017-04-10 15:22 GMT+09:00 Viresh Kumar: > > On 10-04-17, 10:46, Viresh Kumar wrote: > >> Compiling the DT file with W=1, DTC warns like follows: > >> > >> Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a > >> unit name, but no reg property > >> > >> Fix this by replacing '@' with '-' as the OPP nodes will never have a > >> "reg" property. > >> > >> Reported-by: Masahiro Yamada > >> Signed-off-by: Viresh Kumar > > > > + Reported-by: Krzysztof Kozlowski > > > > -- > > viresh > > > Given that this had already been reported one year before, > the reported-by credit should be given to Krzysztof. > > Please drop my Reported-by. I don't think we need to drop any of you. We can very well keep both :) -- viresh
Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
On 10-04-17, 15:30, Masahiro Yamada wrote: > 2017-04-10 15:22 GMT+09:00 Viresh Kumar : > > On 10-04-17, 10:46, Viresh Kumar wrote: > >> Compiling the DT file with W=1, DTC warns like follows: > >> > >> Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a > >> unit name, but no reg property > >> > >> Fix this by replacing '@' with '-' as the OPP nodes will never have a > >> "reg" property. > >> > >> Reported-by: Masahiro Yamada > >> Signed-off-by: Viresh Kumar > > > > + Reported-by: Krzysztof Kozlowski > > > > -- > > viresh > > > Given that this had already been reported one year before, > the reported-by credit should be given to Krzysztof. > > Please drop my Reported-by. I don't think we need to drop any of you. We can very well keep both :) -- viresh
Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
2017-04-10 15:22 GMT+09:00 Viresh Kumar: > On 10-04-17, 10:46, Viresh Kumar wrote: >> Compiling the DT file with W=1, DTC warns like follows: >> >> Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a >> unit name, but no reg property >> >> Fix this by replacing '@' with '-' as the OPP nodes will never have a >> "reg" property. >> >> Reported-by: Masahiro Yamada >> Signed-off-by: Viresh Kumar > > + Reported-by: Krzysztof Kozlowski > > -- > viresh Given that this had already been reported one year before, the reported-by credit should be given to Krzysztof. Please drop my Reported-by. -- Best Regards Masahiro Yamada
Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
2017-04-10 15:22 GMT+09:00 Viresh Kumar : > On 10-04-17, 10:46, Viresh Kumar wrote: >> Compiling the DT file with W=1, DTC warns like follows: >> >> Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a >> unit name, but no reg property >> >> Fix this by replacing '@' with '-' as the OPP nodes will never have a >> "reg" property. >> >> Reported-by: Masahiro Yamada >> Signed-off-by: Viresh Kumar > > + Reported-by: Krzysztof Kozlowski > > -- > viresh Given that this had already been reported one year before, the reported-by credit should be given to Krzysztof. Please drop my Reported-by. -- Best Regards Masahiro Yamada
Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
On 10-04-17, 10:46, Viresh Kumar wrote: > Compiling the DT file with W=1, DTC warns like follows: > > Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a > unit name, but no reg property > > Fix this by replacing '@' with '-' as the OPP nodes will never have a > "reg" property. > > Reported-by: Masahiro Yamada> Signed-off-by: Viresh Kumar + Reported-by: Krzysztof Kozlowski -- viresh
Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
On 10-04-17, 10:46, Viresh Kumar wrote: > Compiling the DT file with W=1, DTC warns like follows: > > Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a > unit name, but no reg property > > Fix this by replacing '@' with '-' as the OPP nodes will never have a > "reg" property. > > Reported-by: Masahiro Yamada > Signed-off-by: Viresh Kumar + Reported-by: Krzysztof Kozlowski -- viresh
Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
On Mon, Apr 10, 2017 at 7:16 AM, Viresh Kumarwrote: > Compiling the DT file with W=1, DTC warns like follows: > > Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a > unit name, but no reg property > > Fix this by replacing '@' with '-' as the OPP nodes will never have a > "reg" property. > > Reported-by: Masahiro Yamada > Signed-off-by: Viresh Kumar This is an very old issue: https://www.spinics.net/lists/devicetree/msg120914.html (reported year ago, please update the Reported-by) and guide was to either use oppN format or whitelist opp nodes in dtc. Apparently the second never happened... Best regards, Krzysztof
Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
On Mon, Apr 10, 2017 at 7:16 AM, Viresh Kumar wrote: > Compiling the DT file with W=1, DTC warns like follows: > > Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a > unit name, but no reg property > > Fix this by replacing '@' with '-' as the OPP nodes will never have a > "reg" property. > > Reported-by: Masahiro Yamada > Signed-off-by: Viresh Kumar This is an very old issue: https://www.spinics.net/lists/devicetree/msg120914.html (reported year ago, please update the Reported-by) and guide was to either use oppN format or whitelist opp nodes in dtc. Apparently the second never happened... Best regards, Krzysztof
Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
On Mon, Apr 10, 2017 at 10:46:37AM +0530, Viresh Kumar wrote: > Compiling the DT file with W=1, DTC warns like follows: > > Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a > unit name, but no reg property > > Fix this by replacing '@' with '-' as the OPP nodes will never have a > "reg" property. > > Reported-by: Masahiro Yamada> Signed-off-by: Viresh Kumar > --- > .../devicetree/bindings/devfreq/exynos-bus.txt | 46 +++ > Documentation/devicetree/bindings/opp/opp.txt | 38 ++--- > arch/arm/boot/dts/exynos3250.dtsi | 46 +++ > arch/arm/boot/dts/exynos4210.dtsi | 32 +-- > arch/arm/boot/dts/exynos4412-prime.dtsi| 4 +- > arch/arm/boot/dts/exynos4412.dtsi | 66 > +++--- > arch/arm/boot/dts/exynos5420.dtsi | 40 ++--- > arch/arm/boot/dts/exynos5800.dtsi | 56 +- > arch/arm/boot/dts/pxa25x.dtsi | 8 +-- > arch/arm/boot/dts/pxa27x.dtsi | 14 ++--- > arch/arm/boot/dts/sun8i-a33.dtsi | 8 +-- For sunxi, Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc Description: PGP signature
Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
On Mon, Apr 10, 2017 at 10:46:37AM +0530, Viresh Kumar wrote: > Compiling the DT file with W=1, DTC warns like follows: > > Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a > unit name, but no reg property > > Fix this by replacing '@' with '-' as the OPP nodes will never have a > "reg" property. > > Reported-by: Masahiro Yamada > Signed-off-by: Viresh Kumar > --- > .../devicetree/bindings/devfreq/exynos-bus.txt | 46 +++ > Documentation/devicetree/bindings/opp/opp.txt | 38 ++--- > arch/arm/boot/dts/exynos3250.dtsi | 46 +++ > arch/arm/boot/dts/exynos4210.dtsi | 32 +-- > arch/arm/boot/dts/exynos4412-prime.dtsi| 4 +- > arch/arm/boot/dts/exynos4412.dtsi | 66 > +++--- > arch/arm/boot/dts/exynos5420.dtsi | 40 ++--- > arch/arm/boot/dts/exynos5800.dtsi | 56 +- > arch/arm/boot/dts/pxa25x.dtsi | 8 +-- > arch/arm/boot/dts/pxa27x.dtsi | 14 ++--- > arch/arm/boot/dts/sun8i-a33.dtsi | 8 +-- For sunxi, Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc Description: PGP signature