Re: [PATCH] Re: Forcing modes in libata
Hi, On Thu, 10 Jan 2008 16:56:10 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > FD Cami wrote: > > Revised patch attached. > > > > Best, > > > > François > > > > applied. please include signed-off-by lines in the future... Will do. Thanks ! François -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Re: Forcing modes in libata
FD Cami wrote: Revised patch attached. Best, François applied. please include signed-off-by lines in the future... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Re: Forcing modes in libata (was: SATA buffered read VERY slow)
On Sunday 06 January 2008, FD Cami wrote: > On Sun, 6 Jan 2008 17:27:38 +0100 > Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > > On Sunday 06 January 2008, FD Cami wrote: > > > On Sun, 6 Jan 2008 13:36:09 + > > > Alan Cox <[EMAIL PROTECTED]> wrote: > > > > > > > On Sun, 6 Jan 2008 08:03:31 +0300 > > > > > > For now you can boot with libata.dma=1 to select DMA on disks > > > > > > but not CD > > > > > > > > > > Great, but why isn't this in the documentation? > > > > > > > > Send patches > > > > > > patch attached. > > > > > > Description : Add libata.dma= to Documentation/kernel-parameters.txt > > > > > > Found documentation in : > > > http://www.mail-archive.com/linux-ide%40vger.kernel.org/msg09849.html > > > http://www.redhat.com/archives/fedora-extras-commits/2007-October/msg04568.html > > > > > > Signed-off-by: François Cami <[EMAIL PROTECTED]> > > > > diff -rU2 linux-2.6.24-rc6/Documentation/kernel-parameters.txt > > linux-2.6.24-rc6-mine/Documentation/kernel-parameters.txt > > --- > > linux-2.6.24-rc6/Documentation/kernel-parameters.txt2008-01-06 > > 15:58:54.0 +0100 +++ > > linux-2.6.24-rc6-mine/Documentation/kernel-parameters.txt 2008-01-06 > > 16:11:20.0 +0100 @@ -883,4 +883,11 @@ C2 power state. > > + libata.dma= [LIBATA] DMA control > > + libata.dma=0 Disable all PATA DMA like > > old IDE > > > > this doesn't seem entirely correct: > > > > * IDE has "hdx=nodma" so you can disable DMA on per-device basis > > I think that libata.dma=1 is designed to behave like > CONFIG_IDEDMA_ONLYDISK used to. "hdx=nodma" is more fine-grained than > this. Seems so but CONFIG_IDEDMA_ONLYDISK was removed on the same day that "hdx=nodma" was introduced (Oct 16 2007)... > > * is this really limited to PATA? > > Alan's original patch took care of PATA. SATA support was added > later by Jeff Garzik. Corrected documentation patch attached. > > > + libata.dma=1 Disk DMA only > > + libata.dma=2 ATAPI DMA only > > + libata.dma=3 CF DMA only > > This is also wrong, it should be "libata.dma=4 CF DMA only" > Thanks to Zoltan Boszormenyi <[EMAIL PROTECTED]> for catching this > mistake. > > Revised patch attached. Thanks, looks good to me. Bart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Re: Forcing modes in libata (was: SATA buffered read VERY slow)
On Sun, 6 Jan 2008 17:27:38 +0100 Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > On Sunday 06 January 2008, FD Cami wrote: > > On Sun, 6 Jan 2008 13:36:09 + > > Alan Cox <[EMAIL PROTECTED]> wrote: > > > > > On Sun, 6 Jan 2008 08:03:31 +0300 > > > > > For now you can boot with libata.dma=1 to select DMA on disks > > > > > but not CD > > > > > > > > Great, but why isn't this in the documentation? > > > > > > Send patches > > > > patch attached. > > > > Description : Add libata.dma= to Documentation/kernel-parameters.txt > > > > Found documentation in : > > http://www.mail-archive.com/linux-ide%40vger.kernel.org/msg09849.html > > http://www.redhat.com/archives/fedora-extras-commits/2007-October/msg04568.html > > > > Signed-off-by: François Cami <[EMAIL PROTECTED]> > > diff -rU2 linux-2.6.24-rc6/Documentation/kernel-parameters.txt > linux-2.6.24-rc6-mine/Documentation/kernel-parameters.txt > --- > linux-2.6.24-rc6/Documentation/kernel-parameters.txt2008-01-06 > 15:58:54.0 +0100 +++ > linux-2.6.24-rc6-mine/Documentation/kernel-parameters.txt 2008-01-06 > 16:11:20.0 +0100 @@ -883,4 +883,11 @@ C2 power state. > + libata.dma= [LIBATA] DMA control > + libata.dma=0 Disable all PATA DMA like > old IDE > > this doesn't seem entirely correct: > > * IDE has "hdx=nodma" so you can disable DMA on per-device basis I think that libata.dma=1 is designed to behave like CONFIG_IDEDMA_ONLYDISK used to. "hdx=nodma" is more fine-grained than this. > * is this really limited to PATA? Alan's original patch took care of PATA. SATA support was added later by Jeff Garzik. Corrected documentation patch attached. > + libata.dma=1 Disk DMA only > + libata.dma=2 ATAPI DMA only > + libata.dma=3 CF DMA only This is also wrong, it should be "libata.dma=4 CF DMA only" Thanks to Zoltan Boszormenyi <[EMAIL PROTECTED]> for catching this mistake. Revised patch attached. Best, François diff -rU4 linux-2.6.24-rc6/Documentation/kernel-parameters.txt linux-2.6.24-rc6-mine/Documentation/kernel-parameters.txt --- linux-2.6.24-rc6/Documentation/kernel-parameters.txt2008-01-06 15:58:54.0 +0100 +++ linux-2.6.24-rc6-mine/Documentation/kernel-parameters.txt 2008-01-06 18:46:49.0 +0100 @@ -881,8 +881,16 @@ lapic_timer_c2_ok [X86-32,x86-64,APIC] trust the local apic timer in C2 power state. + libata.dma= [LIBATA] DMA control + libata.dma=0 Disable all PATA and SATA DMA + libata.dma=1 PATA and SATA Disk DMA only + libata.dma=2 ATAPI (CDROM) DMA only + libata.dma=4 Compact Flash DMA only + Combinations also work, so libata.dma=3 enables DMA + for disks and CDROMs, but not CFs. + libata.noacpi [LIBATA] Disables use of ACPI in libata suspend/resume when set. Format:
