Re: [PATCH] Revert "arm64: dts: amlogic: add missing ethernet reset ID"
On 03/03/2021 00:28, Kevin Hilman wrote: > Hi Neil, > > Neil Armstrong writes: > >> It has been reported on IRC and in KernelCI boot tests, this change breaks >> internal PHY support on the Amlogic G12A/SM1 Based boards. >> >> We suspect the added signal to reset more than the Ethernet MAC but also >> the MDIO/(RG)MII mux used to redirect the MAC signals to the internal PHY. >> >> This reverts commit f3362f0c18174a1f334a419ab7d567a36bd1b3f3 while we find >> and acceptable solution to cleanly reset the Ethernet MAC. >> >> Reported-by: Corentin Labbe >> Acked-by: Jérôme Brunet >> Signed-off-by: Neil Armstrong >> --- >> Hi Kevin, >> >> This has been reported to also break on 5.10, when this lands on 5.11, I'll >> send another >> patch for 5.10 because meson-axg.dtsi needs a conflict resolution on 5.11. > > Looks like this never got submitted to v5.10. I just discovered it that > v5.10 in SEI610 (internal PHY) is broken. > > Could you submit this to v5.10 stable also please? Sure, I'll prepare this. Neil > > Thanks, > > Kevin > > > > >
Re: [PATCH] Revert "arm64: dts: amlogic: add missing ethernet reset ID"
Hi Neil, Neil Armstrong writes: > It has been reported on IRC and in KernelCI boot tests, this change breaks > internal PHY support on the Amlogic G12A/SM1 Based boards. > > We suspect the added signal to reset more than the Ethernet MAC but also > the MDIO/(RG)MII mux used to redirect the MAC signals to the internal PHY. > > This reverts commit f3362f0c18174a1f334a419ab7d567a36bd1b3f3 while we find > and acceptable solution to cleanly reset the Ethernet MAC. > > Reported-by: Corentin Labbe > Acked-by: Jérôme Brunet > Signed-off-by: Neil Armstrong > --- > Hi Kevin, > > This has been reported to also break on 5.10, when this lands on 5.11, I'll > send another > patch for 5.10 because meson-axg.dtsi needs a conflict resolution on 5.11. Looks like this never got submitted to v5.10. I just discovered it that v5.10 in SEI610 (internal PHY) is broken. Could you submit this to v5.10 stable also please? Thanks, Kevin
Re: [PATCH] Revert "arm64: dts: amlogic: add missing ethernet reset ID"
On Tue, 26 Jan 2021 09:09:51 +0100, Neil Armstrong wrote: > It has been reported on IRC and in KernelCI boot tests, this change breaks > internal PHY support on the Amlogic G12A/SM1 Based boards. > > We suspect the added signal to reset more than the Ethernet MAC but also > the MDIO/(RG)MII mux used to redirect the MAC signals to the internal PHY. > > This reverts commit f3362f0c18174a1f334a419ab7d567a36bd1b3f3 while we find > and acceptable solution to cleanly reset the Ethernet MAC. Applied, thanks! [1/1] Revert "arm64: dts: amlogic: add missing ethernet reset ID" commit: 19f6fe976a61f9afc289b062b7ef67f99b72e7b9 Best regards, -- Kevin Hilman