Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters
On Tue, Feb 25, 2014 at 09:46:19AM +, Ian Abbott wrote: > On 2014-02-24 16:49, Monam Agarwal wrote: > > Signed-off-by: Monam Agarwal > > --- > > drivers/staging/comedi/comedi_fops.c |3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/comedi/comedi_fops.c > > b/drivers/staging/comedi/comedi_fops.c > > index ac1edd9..7da8566 100644 > > --- a/drivers/staging/comedi/comedi_fops.c > > +++ b/drivers/staging/comedi/comedi_fops.c > > @@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev, > > async->cmd.data = NULL; > > /* load channel/gain list */ > > async->cmd.chanlist = memdup_user(user_chanlist, > > - async->cmd.chanlist_len * > > sizeof(int)); > > + async->cmd.chanlist_len > > + * sizeof(int)); > > The `*` operator should go at the end of the line according to the > CodingStyle. Which is why I modified it by hand before applying it :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters
On Tue, 2014-02-25 at 14:05 +0300, Dan Carpenter wrote: > On Tue, Feb 25, 2014 at 01:59:25AM -0800, Joe Perches wrote: > > On Tue, 2014-02-25 at 09:46 +, Ian Abbott wrote: > > > On 2014-02-24 16:49, Monam Agarwal wrote: > > [] > > > > diff --git a/drivers/staging/comedi/comedi_fops.c > > > > b/drivers/staging/comedi/comedi_fops.c > > [] > > > > @@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev, > > > > async->cmd.data = NULL; > > > > /* load channel/gain list */ > > > > async->cmd.chanlist = memdup_user(user_chanlist, > > > > - async->cmd.chanlist_len * > > > > sizeof(int)); > > > > + async->cmd.chanlist_len > > > > + * sizeof(int)); > > > The `*` operator should go at the end of the line according to the > > > CodingStyle. > > I don't believe there's a CodingStyle guide for this. > Meanwhile you have felt totally justified in correcting me on this in > the past. :P Doubtful. You're probably thinking of something else. Besides, we generally agree on style. Anything I may have written was more more suggestion than correction. > Anyway, it should be that the operator goes on the first line like Ian > says... Feel free to use whatever style you want. Feel free to update CodingStyle too. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters
On Tue, Feb 25, 2014 at 01:59:25AM -0800, Joe Perches wrote: > On Tue, 2014-02-25 at 09:46 +, Ian Abbott wrote: > > On 2014-02-24 16:49, Monam Agarwal wrote: > [] > > > diff --git a/drivers/staging/comedi/comedi_fops.c > > > b/drivers/staging/comedi/comedi_fops.c > [] > > > @@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev, > > > async->cmd.data = NULL; > > > /* load channel/gain list */ > > > async->cmd.chanlist = memdup_user(user_chanlist, > > > - async->cmd.chanlist_len * > > > sizeof(int)); > > > + async->cmd.chanlist_len > > > + * sizeof(int)); > > > > The `*` operator should go at the end of the line according to the > > CodingStyle. > > I don't believe there's a CodingStyle guide for this. > Meanwhile you have felt totally justified in correcting me on this in the past. :P Anyway, it should be that the operator goes on the first line like Ian says... regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters
On Tue, 2014-02-25 at 09:46 +, Ian Abbott wrote: > On 2014-02-24 16:49, Monam Agarwal wrote: [] > > diff --git a/drivers/staging/comedi/comedi_fops.c > > b/drivers/staging/comedi/comedi_fops.c [] > > @@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev, > > async->cmd.data = NULL; > > /* load channel/gain list */ > > async->cmd.chanlist = memdup_user(user_chanlist, > > - async->cmd.chanlist_len * > > sizeof(int)); > > + async->cmd.chanlist_len > > + * sizeof(int)); > > The `*` operator should go at the end of the line according to the > CodingStyle. I don't believe there's a CodingStyle guide for this. Another way to do this is to move the memdup_user to a separate line like: async->cmd_chanlist = memdup_user(user_chanlist, async->cmd.chanlist_len * sizeof(int)); but I'm not bothered by the existing > 80 column use. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters
On 2014-02-24 16:49, Monam Agarwal wrote:
Signed-off-by: Monam Agarwal
---
drivers/staging/comedi/comedi_fops.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.c
index ac1edd9..7da8566 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev,
async->cmd.data = NULL;
/* load channel/gain list */
async->cmd.chanlist = memdup_user(user_chanlist,
- async->cmd.chanlist_len *
sizeof(int));
+ async->cmd.chanlist_len
+ * sizeof(int));
The `*` operator should go at the end of the line according to the
CodingStyle.
if (IS_ERR(async->cmd.chanlist)) {
ret = PTR_ERR(async->cmd.chanlist);
async->cmd.chanlist = NULL;
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters
On 2014-02-24 16:49, Monam Agarwal wrote:
Signed-off-by: Monam Agarwal monamagarwal...@gmail.com
---
drivers/staging/comedi/comedi_fops.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.c
index ac1edd9..7da8566 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev,
async-cmd.data = NULL;
/* load channel/gain list */
async-cmd.chanlist = memdup_user(user_chanlist,
- async-cmd.chanlist_len *
sizeof(int));
+ async-cmd.chanlist_len
+ * sizeof(int));
The `*` operator should go at the end of the line according to the
CodingStyle.
if (IS_ERR(async-cmd.chanlist)) {
ret = PTR_ERR(async-cmd.chanlist);
async-cmd.chanlist = NULL;
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters
On Tue, 2014-02-25 at 09:46 +, Ian Abbott wrote: On 2014-02-24 16:49, Monam Agarwal wrote: [] diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c [] @@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev, async-cmd.data = NULL; /* load channel/gain list */ async-cmd.chanlist = memdup_user(user_chanlist, - async-cmd.chanlist_len * sizeof(int)); + async-cmd.chanlist_len + * sizeof(int)); The `*` operator should go at the end of the line according to the CodingStyle. I don't believe there's a CodingStyle guide for this. Another way to do this is to move the memdup_user to a separate line like: async-cmd_chanlist = memdup_user(user_chanlist, async-cmd.chanlist_len * sizeof(int)); but I'm not bothered by the existing 80 column use. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters
On Tue, Feb 25, 2014 at 01:59:25AM -0800, Joe Perches wrote: On Tue, 2014-02-25 at 09:46 +, Ian Abbott wrote: On 2014-02-24 16:49, Monam Agarwal wrote: [] diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c [] @@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev, async-cmd.data = NULL; /* load channel/gain list */ async-cmd.chanlist = memdup_user(user_chanlist, - async-cmd.chanlist_len * sizeof(int)); + async-cmd.chanlist_len + * sizeof(int)); The `*` operator should go at the end of the line according to the CodingStyle. I don't believe there's a CodingStyle guide for this. Meanwhile you have felt totally justified in correcting me on this in the past. :P Anyway, it should be that the operator goes on the first line like Ian says... regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters
On Tue, 2014-02-25 at 14:05 +0300, Dan Carpenter wrote: On Tue, Feb 25, 2014 at 01:59:25AM -0800, Joe Perches wrote: On Tue, 2014-02-25 at 09:46 +, Ian Abbott wrote: On 2014-02-24 16:49, Monam Agarwal wrote: [] diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c [] @@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev, async-cmd.data = NULL; /* load channel/gain list */ async-cmd.chanlist = memdup_user(user_chanlist, - async-cmd.chanlist_len * sizeof(int)); + async-cmd.chanlist_len + * sizeof(int)); The `*` operator should go at the end of the line according to the CodingStyle. I don't believe there's a CodingStyle guide for this. Meanwhile you have felt totally justified in correcting me on this in the past. :P Doubtful. You're probably thinking of something else. Besides, we generally agree on style. Anything I may have written was more more suggestion than correction. Anyway, it should be that the operator goes on the first line like Ian says... Feel free to use whatever style you want. Feel free to update CodingStyle too. cheers, Joe -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters
On Tue, Feb 25, 2014 at 09:46:19AM +, Ian Abbott wrote: On 2014-02-24 16:49, Monam Agarwal wrote: Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/comedi/comedi_fops.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index ac1edd9..7da8566 100644 --- a/drivers/staging/comedi/comedi_fops.c +++ b/drivers/staging/comedi/comedi_fops.c @@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev, async-cmd.data = NULL; /* load channel/gain list */ async-cmd.chanlist = memdup_user(user_chanlist, - async-cmd.chanlist_len * sizeof(int)); + async-cmd.chanlist_len + * sizeof(int)); The `*` operator should go at the end of the line according to the CodingStyle. Which is why I modified it by hand before applying it :) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
