Re: [PATCH] block: pass correct prot_buf pointer to integrity metadata processing function
> "Sam" == Sam Bradshaw writes: Hey Sam, Sam> The prot_buf pointer passed to the generate/verify functions is Sam> incorrect for the second and subsequent range, making it impossible Sam> to verify the guard tag. The patch correctly increments the Sam> prot_buf pointer by the tuple size for each pass. prot_buf is just a temporary variable used to get the kernel address of the buffer pointer. We only care about iter.prot_buf and that gets incremented by the generate or verify functions. Are your data buffers page aligned? Things are going to break if they aren't... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] block: pass correct prot_buf pointer to integrity metadata processing function
Sam == Sam Bradshaw sbrads...@micron.com writes: Hey Sam, Sam The prot_buf pointer passed to the generate/verify functions is Sam incorrect for the second and subsequent range, making it impossible Sam to verify the guard tag. The patch correctly increments the Sam prot_buf pointer by the tuple size for each pass. prot_buf is just a temporary variable used to get the kernel address of the buffer pointer. We only care about iter.prot_buf and that gets incremented by the generate or verify functions. Are your data buffers page aligned? Things are going to break if they aren't... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
