Re: [PATCH] checkpatch: stop checking for CONFIG_EXPERIMENTAL
On Sat, 2013-03-16 at 15:38 -0700, Kees Cook wrote: > Hrm, I actually think it would be better to change this to ERROR > instead of WARN. I figured the main reason to add this warning was to prevent people to add dependencies on EXPERIMENTAL while you were cleaning the tree, which could mean you had to redo patches each time that happened. Anyhow, with EXPERIMENTAL gone, this is just one of the mistakes people can make in using the kconfig system. I'm not sure that we should use checkpatch to catch these. For this particular case it must also be noted that if code gets in while still depending on EXPERIMENTAL someone also missed that this code doesn't get build at all. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] checkpatch: stop checking for CONFIG_EXPERIMENTAL
On Sat, Mar 16, 2013 at 2:30 PM, Paul Bolle wrote:
> CONFIG_EXPERIMENTAL has been removed from the tree, in commit
> 3d374d09f16f64ab4d71704cbe621514d36cd0b1 ("final removal of
> CONFIG_EXPERIMENTAL"). There's no need to test for it in checkpatch
> anymore. If it ever pops up again it can be caught when someone feels
> like cleaning up invalid Kconfig symbols and macros again.
Hrm, I actually think it would be better to change this to ERROR
instead of WARN.
-Kees
--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] checkpatch: stop checking for CONFIG_EXPERIMENTAL
On Sat, Mar 16, 2013 at 10:30:35PM +0100, Paul Bolle wrote: > 1) A lot of defconfigs still have CONFIG_EXPERIMENTAL in them. How > should that be cleaned up? Just ignore it, when ever those defconfigs ever get used, or updated, it will fall out automatically. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
