Re: [PATCH] crush:Make the function crush_ln static
On Tue, Jun 16, 2015 at 8:22 PM, nick wrote: > > > On 2015-06-16 01:16 PM, Ilya Dryomov wrote: >> On Tue, Jun 16, 2015 at 8:07 PM, nick wrote: >>> >>> >>> On 2015-06-16 12:47 PM, Ilya Dryomov wrote: On Tue, Jun 16, 2015 at 7:18 PM, nick wrote: > Ilya, > That's fine I do have a unrelated question through. I have over 90 > patches lying around in terms of cleanups/ > fixes and need help getting them merged. Should I just resend them or > wait until the end of this merge window. Are all of those ceph patches? Thanks, Ilya >>> Ilya, >>> Sorry for the second email but two of them are. I just checked, would you >>> like me to resend >>> these two patches. >> >> No need to resend, just point them out in a reply. >> >> Thanks, >> >> Ilya >> > The two patches have these subject headers: > ceph:Remove the unused marco AES_KEY_SIZE > ceph:Make the function ceph_monmap_contains bool > If you can't find them I will resend them. I can't - looks like ceph-devel wasn't CC'ed. Please resend. Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] crush:Make the function crush_ln static
On Tue, Jun 16, 2015 at 8:07 PM, nick wrote: > > > On 2015-06-16 12:47 PM, Ilya Dryomov wrote: >> On Tue, Jun 16, 2015 at 7:18 PM, nick wrote: >>> Ilya, >>> That's fine I do have a unrelated question through. I have over 90 patches >>> lying around in terms of cleanups/ >>> fixes and need help getting them merged. Should I just resend them or wait >>> until the end of this merge window. >> >> Are all of those ceph patches? >> >> Thanks, >> >> Ilya >> > Ilya, > Sorry for the second email but two of them are. I just checked, would you > like me to resend > these two patches. No need to resend, just point them out in a reply. Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] crush:Make the function crush_ln static
On Tue, Jun 16, 2015 at 7:57 PM, nick wrote: > > > On 2015-06-16 12:47 PM, Ilya Dryomov wrote: >> On Tue, Jun 16, 2015 at 7:18 PM, nick wrote: >>> Ilya, >>> That's fine I do have a unrelated question through. I have over 90 patches >>> lying around in terms of cleanups/ >>> fixes and need help getting them merged. Should I just resend them or wait >>> until the end of this merge window. >> >> Are all of those ceph patches? >> >> Thanks, >> >> Ilya >> > No there all over networking stack including drivers. I'd suggest reaching out to the respective maintainers, especially if those ~90 patches can be broken into a few chunks that a small number of people can deal with. If that doesn't get you anywhere, try resending the whole batch to triv...@kernel.org. Jiri may be able to merge it through his trivial tree. Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] crush:Make the function crush_ln static
On Tue, Jun 16, 2015 at 7:18 PM, nick wrote: > Ilya, > That's fine I do have a unrelated question through. I have over 90 patches > lying around in terms of cleanups/ > fixes and need help getting them merged. Should I just resend them or wait > until the end of this merge window. Are all of those ceph patches? Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] crush:Make the function crush_ln static
On Tue, Jun 9, 2015 at 11:00 AM, Ilya Dryomov wrote:
> On Tue, Jun 9, 2015 at 1:51 AM, Nicholas Krause wrote:
>> This makes the function, crush_ln static now due to having
>> only one caller in its own definition and declaration file
>> of mapper.c
>>
>> Signed-off-by: Nicholas Krause
>> ---
>> net/ceph/crush/mapper.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c
>> index 5b47736..86778d4 100644
>> --- a/net/ceph/crush/mapper.c
>> +++ b/net/ceph/crush/mapper.c
>> @@ -239,7 +239,7 @@ static int bucket_straw_choose(struct crush_bucket_straw
>> *bucket,
>> }
>>
>> // compute 2^44*log2(input+1)
>> -uint64_t crush_ln(unsigned xin)
>> +static uint64_t crush_ln(unsigned xin)
>> {
>> unsigned x=xin, x1;
>> int iexpon, index1, index2;
>
> This is tied up with a bunch of style cleanups, I'll apply it after
> they are sorted out.
I folded your patch into a cleanup commit [1] that also fixed
crush_ln() formatting - I hope you don't mind.
[1]
https://github.com/ceph/ceph-client/commit/45c7a1f5df419e53c17f2eeb5680d6fb20a07162
Thanks,
Ilya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] crush:Make the function crush_ln static
On Tue, Jun 9, 2015 at 11:00 AM, Ilya Dryomov idryo...@gmail.com wrote:
On Tue, Jun 9, 2015 at 1:51 AM, Nicholas Krause xerofo...@gmail.com wrote:
This makes the function, crush_ln static now due to having
only one caller in its own definition and declaration file
of mapper.c
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
net/ceph/crush/mapper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c
index 5b47736..86778d4 100644
--- a/net/ceph/crush/mapper.c
+++ b/net/ceph/crush/mapper.c
@@ -239,7 +239,7 @@ static int bucket_straw_choose(struct crush_bucket_straw
*bucket,
}
// compute 2^44*log2(input+1)
-uint64_t crush_ln(unsigned xin)
+static uint64_t crush_ln(unsigned xin)
{
unsigned x=xin, x1;
int iexpon, index1, index2;
This is tied up with a bunch of style cleanups, I'll apply it after
they are sorted out.
I folded your patch into a cleanup commit [1] that also fixed
crush_ln() formatting - I hope you don't mind.
[1]
https://github.com/ceph/ceph-client/commit/45c7a1f5df419e53c17f2eeb5680d6fb20a07162
Thanks,
Ilya
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] crush:Make the function crush_ln static
On Tue, Jun 16, 2015 at 8:07 PM, nick xerofo...@gmail.com wrote: On 2015-06-16 12:47 PM, Ilya Dryomov wrote: On Tue, Jun 16, 2015 at 7:18 PM, nick xerofo...@gmail.com wrote: Ilya, That's fine I do have a unrelated question through. I have over 90 patches lying around in terms of cleanups/ fixes and need help getting them merged. Should I just resend them or wait until the end of this merge window. Are all of those ceph patches? Thanks, Ilya Ilya, Sorry for the second email but two of them are. I just checked, would you like me to resend these two patches. No need to resend, just point them out in a reply. Thanks, Ilya -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] crush:Make the function crush_ln static
On Tue, Jun 16, 2015 at 7:18 PM, nick xerofo...@gmail.com wrote: Ilya, That's fine I do have a unrelated question through. I have over 90 patches lying around in terms of cleanups/ fixes and need help getting them merged. Should I just resend them or wait until the end of this merge window. Are all of those ceph patches? Thanks, Ilya -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] crush:Make the function crush_ln static
On Tue, Jun 16, 2015 at 8:22 PM, nick xerofo...@gmail.com wrote: On 2015-06-16 01:16 PM, Ilya Dryomov wrote: On Tue, Jun 16, 2015 at 8:07 PM, nick xerofo...@gmail.com wrote: On 2015-06-16 12:47 PM, Ilya Dryomov wrote: On Tue, Jun 16, 2015 at 7:18 PM, nick xerofo...@gmail.com wrote: Ilya, That's fine I do have a unrelated question through. I have over 90 patches lying around in terms of cleanups/ fixes and need help getting them merged. Should I just resend them or wait until the end of this merge window. Are all of those ceph patches? Thanks, Ilya Ilya, Sorry for the second email but two of them are. I just checked, would you like me to resend these two patches. No need to resend, just point them out in a reply. Thanks, Ilya The two patches have these subject headers: ceph:Remove the unused marco AES_KEY_SIZE ceph:Make the function ceph_monmap_contains bool If you can't find them I will resend them. I can't - looks like ceph-devel wasn't CC'ed. Please resend. Thanks, Ilya -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] crush:Make the function crush_ln static
On Tue, Jun 16, 2015 at 7:57 PM, nick xerofo...@gmail.com wrote: On 2015-06-16 12:47 PM, Ilya Dryomov wrote: On Tue, Jun 16, 2015 at 7:18 PM, nick xerofo...@gmail.com wrote: Ilya, That's fine I do have a unrelated question through. I have over 90 patches lying around in terms of cleanups/ fixes and need help getting them merged. Should I just resend them or wait until the end of this merge window. Are all of those ceph patches? Thanks, Ilya No there all over networking stack including drivers. I'd suggest reaching out to the respective maintainers, especially if those ~90 patches can be broken into a few chunks that a small number of people can deal with. If that doesn't get you anywhere, try resending the whole batch to triv...@kernel.org. Jiri may be able to merge it through his trivial tree. Thanks, Ilya -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] crush:Make the function crush_ln static
On Tue, Jun 9, 2015 at 1:51 AM, Nicholas Krause wrote:
> This makes the function, crush_ln static now due to having
> only one caller in its own definition and declaration file
> of mapper.c
>
> Signed-off-by: Nicholas Krause
> ---
> net/ceph/crush/mapper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c
> index 5b47736..86778d4 100644
> --- a/net/ceph/crush/mapper.c
> +++ b/net/ceph/crush/mapper.c
> @@ -239,7 +239,7 @@ static int bucket_straw_choose(struct crush_bucket_straw
> *bucket,
> }
>
> // compute 2^44*log2(input+1)
> -uint64_t crush_ln(unsigned xin)
> +static uint64_t crush_ln(unsigned xin)
> {
> unsigned x=xin, x1;
> int iexpon, index1, index2;
This is tied up with a bunch of style cleanups, I'll apply it after
they are sorted out.
Thanks,
Ilya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] crush:Make the function crush_ln static
On Tue, Jun 9, 2015 at 1:51 AM, Nicholas Krause xerofo...@gmail.com wrote:
This makes the function, crush_ln static now due to having
only one caller in its own definition and declaration file
of mapper.c
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
net/ceph/crush/mapper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c
index 5b47736..86778d4 100644
--- a/net/ceph/crush/mapper.c
+++ b/net/ceph/crush/mapper.c
@@ -239,7 +239,7 @@ static int bucket_straw_choose(struct crush_bucket_straw
*bucket,
}
// compute 2^44*log2(input+1)
-uint64_t crush_ln(unsigned xin)
+static uint64_t crush_ln(unsigned xin)
{
unsigned x=xin, x1;
int iexpon, index1, index2;
This is tied up with a bunch of style cleanups, I'll apply it after
they are sorted out.
Thanks,
Ilya
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
