Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular

[Paul Gortmaker]

[Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular] On 
05/01/2016 (Tue 11:31) Masahiro Yamada wrote:

> 2016-01-05 11:26 GMT+09:00 Masahiro Yamada :
> > Hi Paul,
> >

[...]

> >
> >
> > I assume commit 326ea45aa827 ("bus: uniphier: allow only built-in driver")
> > is a temporary fix.
> >
> > I'd like to revive the tristate for this driver
> > by hook or by crook.
> >
> >
> > I've sent the following to fix the build error.
> > http://www.thefreedictionary.com/
> 
> Sorry, I mean this one:
> https://patchwork.kernel.org/patch/7952361/

Sure, I'll shelf it and assume it will get back to tristate.

Note however that the patch I was looking at was not 326ea. It was

commit 6c741c74092c61465af206672ba567940a23d709
Author: Daniel Kurtz 
Date:   Tue Dec 22 21:46:37 2015 +0800

pinctrl: mediatek: convert to arch_initcall

..and if you make it tristate again, you defeat the above change,
since if you look at module.h, you will see for the =m config:

 #define arch_initcall(fn)   module_init(fn)

...meaning that the change in 6c741c does nothing if =m is set.
I don't know if that is an issue or not, perhaps Daniel can comment.

Paul.
--

> 
> 
> 
> -- 
> Best Regards
> Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular

[Paul Gortmaker]

[Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular] On 
05/01/2016 (Tue 11:31) Masahiro Yamada wrote:

> 2016-01-05 11:26 GMT+09:00 Masahiro Yamada <yamada.masah...@socionext.com>:
> > Hi Paul,
> >

[...]

> >
> >
> > I assume commit 326ea45aa827 ("bus: uniphier: allow only built-in driver")
> > is a temporary fix.
> >
> > I'd like to revive the tristate for this driver
> > by hook or by crook.
> >
> >
> > I've sent the following to fix the build error.
> > http://www.thefreedictionary.com/
> 
> Sorry, I mean this one:
> https://patchwork.kernel.org/patch/7952361/

Sure, I'll shelf it and assume it will get back to tristate.

Note however that the patch I was looking at was not 326ea. It was

commit 6c741c74092c61465af206672ba567940a23d709
Author: Daniel Kurtz <djku...@chromium.org>
Date:   Tue Dec 22 21:46:37 2015 +0800

pinctrl: mediatek: convert to arch_initcall

..and if you make it tristate again, you defeat the above change,
since if you look at module.h, you will see for the =m config:

 #define arch_initcall(fn)   module_init(fn)

...meaning that the change in 6c741c does nothing if =m is set.
I don't know if that is an issue or not, perhaps Daniel can comment.

Paul.
--

> 
> 
> 
> -- 
> Best Regards
> Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular

[Masahiro Yamada]

2016-01-05 11:26 GMT+09:00 Masahiro Yamada :
> Hi Paul,
>
>
> 2016-01-05 8:24 GMT+09:00 Masahiro Yamada :
>> Hi Olof,
>>
>> Sorry my misunderstanding.
>>
>>
>> 2016-01-05 8:15 GMT+09:00 Masahiro Yamada :
>>> Hi Paul, Olof,
>>>
>>> 2016-01-05 4:22 GMT+09:00 Paul Gortmaker :
 The Kconfig currently controlling compilation of this code is:

 drivers/bus/Kconfig:config UNIPHIER_SYSTEM_BUS
 drivers/bus/Kconfig:bool "UniPhier System Bus driver"

 ...meaning that it currently is not being built as a module by anyone.

 Lets remove the modular code that is essentially orphaned, so that
 when reading the driver there is no doubt it is builtin-only.

 Since module_platform_driver() uses the same init level priority as
 builtin_platform_driver() the init ordering remains unchanged with
 this commit.

 Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

 We also delete the MODULE_LICENSE tag etc. since all that information
 is already contained at the top of the file in the comments.

 Cc: Masahiro Yamada 
 Cc: Rob Herring 
 Cc: Arnd Bergmann 
 Cc: Olof Johansson 
 Cc: linux-arm-ker...@lists.infradead.org
 Signed-off-by: Paul Gortmaker 
>
>
>
> I assume commit 326ea45aa827 ("bus: uniphier: allow only built-in driver")
> is a temporary fix.
>
> I'd like to revive the tristate for this driver
> by hook or by crook.
>
>
> I've sent the following to fix the build error.
> http://www.thefreedictionary.com/

Sorry, I mean this one:
https://patchwork.kernel.org/patch/7952361/



-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular

[Masahiro Yamada]

Hi Paul,


2016-01-05 8:24 GMT+09:00 Masahiro Yamada :
> Hi Olof,
>
> Sorry my misunderstanding.
>
>
> 2016-01-05 8:15 GMT+09:00 Masahiro Yamada :
>> Hi Paul, Olof,
>>
>> 2016-01-05 4:22 GMT+09:00 Paul Gortmaker :
>>> The Kconfig currently controlling compilation of this code is:
>>>
>>> drivers/bus/Kconfig:config UNIPHIER_SYSTEM_BUS
>>> drivers/bus/Kconfig:bool "UniPhier System Bus driver"
>>>
>>> ...meaning that it currently is not being built as a module by anyone.
>>>
>>> Lets remove the modular code that is essentially orphaned, so that
>>> when reading the driver there is no doubt it is builtin-only.
>>>
>>> Since module_platform_driver() uses the same init level priority as
>>> builtin_platform_driver() the init ordering remains unchanged with
>>> this commit.
>>>
>>> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>>>
>>> We also delete the MODULE_LICENSE tag etc. since all that information
>>> is already contained at the top of the file in the comments.
>>>
>>> Cc: Masahiro Yamada 
>>> Cc: Rob Herring 
>>> Cc: Arnd Bergmann 
>>> Cc: Olof Johansson 
>>> Cc: linux-arm-ker...@lists.infradead.org
>>> Signed-off-by: Paul Gortmaker 



I assume commit 326ea45aa827 ("bus: uniphier: allow only built-in driver")
is a temporary fix.

I'd like to revive the tristate for this driver
by hook or by crook.


I've sent the following to fix the build error.
http://www.thefreedictionary.com/

I want to see how it goes.


So, please hold back yours for now.




-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular

[Masahiro Yamada]

Hi Olof,

Sorry my misunderstanding.


2016-01-05 8:15 GMT+09:00 Masahiro Yamada :
> Hi Paul, Olof,
>
> 2016-01-05 4:22 GMT+09:00 Paul Gortmaker :
>> The Kconfig currently controlling compilation of this code is:
>>
>> drivers/bus/Kconfig:config UNIPHIER_SYSTEM_BUS
>> drivers/bus/Kconfig:bool "UniPhier System Bus driver"
>>
>> ...meaning that it currently is not being built as a module by anyone.
>>
>> Lets remove the modular code that is essentially orphaned, so that
>> when reading the driver there is no doubt it is builtin-only.
>>
>> Since module_platform_driver() uses the same init level priority as
>> builtin_platform_driver() the init ordering remains unchanged with
>> this commit.
>>
>> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>>
>> We also delete the MODULE_LICENSE tag etc. since all that information
>> is already contained at the top of the file in the comments.
>>
>> Cc: Masahiro Yamada 
>> Cc: Rob Herring 
>> Cc: Arnd Bergmann 
>> Cc: Olof Johansson 
>> Cc: linux-arm-ker...@lists.infradead.org
>> Signed-off-by: Paul Gortmaker 
>
>
> This driver can be modular.
>
> I wrote "tristate" in my original patch.
>
> See this one:
> https://patchwork.kernel.org/patch/7805091/
>
>
>
> But when I look at linux-next, it is "bool".
>
>
>
> Now, I realized what happened.
>
> Olof Johansson only said "Thanks, applied to next/drivers."
> But, he silently modified my patch,
> changing "tristate" into "bool".
>
>
> Olof,
>
> Why did you do that?
>
>
> I want this driver tristate.


My bad - Olof had applied it as it is.

It was changed from "tristate" to "bool" by

commit 326ea45aa827da6686c78b5907f9839f91ef5782
Author: Arnd Bergmann 
Date:   Mon Dec 28 11:05:18 2015 +0100

bus: uniphier: allow only built-in driver



I did not notice this.





-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular

[Masahiro Yamada]

Hi Paul, Olof,

2016-01-05 4:22 GMT+09:00 Paul Gortmaker :
> The Kconfig currently controlling compilation of this code is:
>
> drivers/bus/Kconfig:config UNIPHIER_SYSTEM_BUS
> drivers/bus/Kconfig:bool "UniPhier System Bus driver"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Masahiro Yamada 
> Cc: Rob Herring 
> Cc: Arnd Bergmann 
> Cc: Olof Johansson 
> Cc: linux-arm-ker...@lists.infradead.org
> Signed-off-by: Paul Gortmaker 


This driver can be modular.

I wrote "tristate" in my original patch.

See this one:
https://patchwork.kernel.org/patch/7805091/



But when I look at linux-next, it is "bool".



Now, I realized what happened.

Olof Johansson only said "Thanks, applied to next/drivers."
But, he silently modified my patch,
changing "tristate" into "bool".


Olof,

Why did you do that?


I want this driver tristate.



-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular

[Masahiro Yamada]

Hi Paul, Olof,

2016-01-05 4:22 GMT+09:00 Paul Gortmaker :
> The Kconfig currently controlling compilation of this code is:
>
> drivers/bus/Kconfig:config UNIPHIER_SYSTEM_BUS
> drivers/bus/Kconfig:bool "UniPhier System Bus driver"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Masahiro Yamada 
> Cc: Rob Herring 
> Cc: Arnd Bergmann 
> Cc: Olof Johansson 
> Cc: linux-arm-ker...@lists.infradead.org
> Signed-off-by: Paul Gortmaker 


This driver can be modular.

I wrote "tristate" in my original patch.

See this one:
https://patchwork.kernel.org/patch/7805091/



But when I look at linux-next, it is "bool".



Now, I realized what happened.

Olof Johansson only said "Thanks, applied to next/drivers."
But, he silently modified my patch,
changing "tristate" into "bool".


Olof,

Why did you do that?


I want this driver tristate.



-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular

[Masahiro Yamada]

2016-01-05 11:26 GMT+09:00 Masahiro Yamada :
> Hi Paul,
>
>
> 2016-01-05 8:24 GMT+09:00 Masahiro Yamada :
>> Hi Olof,
>>
>> Sorry my misunderstanding.
>>
>>
>> 2016-01-05 8:15 GMT+09:00 Masahiro Yamada :
>>> Hi Paul, Olof,
>>>
>>> 2016-01-05 4:22 GMT+09:00 Paul Gortmaker :
 The Kconfig currently controlling compilation of this code is:

 drivers/bus/Kconfig:config UNIPHIER_SYSTEM_BUS
 drivers/bus/Kconfig:bool "UniPhier System Bus driver"

 ...meaning that it currently is not being built as a module by anyone.

 Lets remove the modular code that is essentially orphaned, so that
 when reading the driver there is no doubt it is builtin-only.

 Since module_platform_driver() uses the same init level priority as
 builtin_platform_driver() the init ordering remains unchanged with
 this commit.

 Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

 We also delete the MODULE_LICENSE tag etc. since all that information
 is already contained at the top of the file in the comments.

 Cc: Masahiro Yamada 
 Cc: Rob Herring 
 Cc: Arnd Bergmann 
 Cc: Olof Johansson 
 Cc: linux-arm-ker...@lists.infradead.org
 Signed-off-by: Paul Gortmaker 
>
>
>
> I assume commit 326ea45aa827 ("bus: uniphier: allow only built-in driver")
> is a temporary fix.
>
> I'd like to revive the tristate for this driver
> by hook or by crook.
>
>
> I've sent the following to fix the build error.
> http://www.thefreedictionary.com/

Sorry, I mean this one:
https://patchwork.kernel.org/patch/7952361/



-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular

[Masahiro Yamada]

Hi Paul,


2016-01-05 8:24 GMT+09:00 Masahiro Yamada :
> Hi Olof,
>
> Sorry my misunderstanding.
>
>
> 2016-01-05 8:15 GMT+09:00 Masahiro Yamada :
>> Hi Paul, Olof,
>>
>> 2016-01-05 4:22 GMT+09:00 Paul Gortmaker :
>>> The Kconfig currently controlling compilation of this code is:
>>>
>>> drivers/bus/Kconfig:config UNIPHIER_SYSTEM_BUS
>>> drivers/bus/Kconfig:bool "UniPhier System Bus driver"
>>>
>>> ...meaning that it currently is not being built as a module by anyone.
>>>
>>> Lets remove the modular code that is essentially orphaned, so that
>>> when reading the driver there is no doubt it is builtin-only.
>>>
>>> Since module_platform_driver() uses the same init level priority as
>>> builtin_platform_driver() the init ordering remains unchanged with
>>> this commit.
>>>
>>> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>>>
>>> We also delete the MODULE_LICENSE tag etc. since all that information
>>> is already contained at the top of the file in the comments.
>>>
>>> Cc: Masahiro Yamada 
>>> Cc: Rob Herring 
>>> Cc: Arnd Bergmann 
>>> Cc: Olof Johansson 
>>> Cc: linux-arm-ker...@lists.infradead.org
>>> Signed-off-by: Paul Gortmaker 



I assume commit 326ea45aa827 ("bus: uniphier: allow only built-in driver")
is a temporary fix.

I'd like to revive the tristate for this driver
by hook or by crook.


I've sent the following to fix the build error.
http://www.thefreedictionary.com/

I want to see how it goes.


So, please hold back yours for now.




-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular

[Masahiro Yamada]

Hi Olof,

Sorry my misunderstanding.


2016-01-05 8:15 GMT+09:00 Masahiro Yamada :
> Hi Paul, Olof,
>
> 2016-01-05 4:22 GMT+09:00 Paul Gortmaker :
>> The Kconfig currently controlling compilation of this code is:
>>
>> drivers/bus/Kconfig:config UNIPHIER_SYSTEM_BUS
>> drivers/bus/Kconfig:bool "UniPhier System Bus driver"
>>
>> ...meaning that it currently is not being built as a module by anyone.
>>
>> Lets remove the modular code that is essentially orphaned, so that
>> when reading the driver there is no doubt it is builtin-only.
>>
>> Since module_platform_driver() uses the same init level priority as
>> builtin_platform_driver() the init ordering remains unchanged with
>> this commit.
>>
>> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>>
>> We also delete the MODULE_LICENSE tag etc. since all that information
>> is already contained at the top of the file in the comments.
>>
>> Cc: Masahiro Yamada 
>> Cc: Rob Herring 
>> Cc: Arnd Bergmann 
>> Cc: Olof Johansson 
>> Cc: linux-arm-ker...@lists.infradead.org
>> Signed-off-by: Paul Gortmaker 
>
>
> This driver can be modular.
>
> I wrote "tristate" in my original patch.
>
> See this one:
> https://patchwork.kernel.org/patch/7805091/
>
>
>
> But when I look at linux-next, it is "bool".
>
>
>
> Now, I realized what happened.
>
> Olof Johansson only said "Thanks, applied to next/drivers."
> But, he silently modified my patch,
> changing "tristate" into "bool".
>
>
> Olof,
>
> Why did you do that?
>
>
> I want this driver tristate.


My bad - Olof had applied it as it is.

It was changed from "tristate" to "bool" by

commit 326ea45aa827da6686c78b5907f9839f91ef5782
Author: Arnd Bergmann 
Date:   Mon Dec 28 11:05:18 2015 +0100

bus: uniphier: allow only built-in driver



I did not notice this.





-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/