Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information
Joe Perches writes: > Hello Robert. > > The return value of that dbg_show_requester_chan function > was incorrect and the increment of pos was an example of > why the seq_printf return value was changed to void. > > It was a pretty common error and easy to understand given > the expectation that seq_printf should work like printf. Sure. > It's a pity it bit you. but this type of patch collision > should be a bit more difficult to reoccur in the future. I got what I deserved. I knew it was coming, I've seen it in other drivers of mine, but my left brain didn't tell the other half to crosscheck in this patch. Anyway, it's not a big fixup, so everything is fine now. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information
On Fri, 2015-05-29 at 11:29 +0200, robert.jarz...@free.fr wrote: > - Mail original - > De: "Vinod Koul" > On Wed, May 27, 2015 at 11:23:40PM +0200, Robert Jarzmik wrote: > > This fixes the following error: [] > And with a a bit closer look check this commit, especially the date : > commit 0bac33653b06a5f80a5c04e275eb33db9493b85a > Author: Joe Perches > Date: Sat May 23 12:00:38 2015 +1000 > > fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void Hello Robert. The return value of that dbg_show_requester_chan function was incorrect and the increment of pos was an example of why the seq_printf return value was changed to void. It was a pretty common error and easy to understand given the expectation that seq_printf should work like printf. It's a pity it bit you. but this type of patch collision should be a bit more difficult to reoccur in the future. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information
- Mail original - De: "Vinod Koul" À: "Robert Jarzmik" On Wed, May 27, 2015 at 11:23:40PM +0200, Robert Jarzmik wrote: > This fixes the following error: > drivers/dma/pxa_dma.c: In function ‘dbg_show_requester_chan’: > drivers/dma/pxa_dma.c:192:2: error: void value not ignored as it ought to be > pos += seq_printf(s, "DMA channel %d requester :\n", phy->idx); > Applied now. Thanks. > but not pleased that you sent broken code. Sending stuff that > compiles is basic step You should know me better by now. I told you I compiled *and* tested. And with a a bit closer look check this commit, especially the date : commit 0bac33653b06a5f80a5c04e275eb33db9493b85a Author: Joe Perches Date: Sat May 23 12:00:38 2015 +1000 fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information
On Wed, May 27, 2015 at 11:23:40PM +0200, Robert Jarzmik wrote: > This fixes the following error: > drivers/dma/pxa_dma.c: In function ‘dbg_show_requester_chan’: > drivers/dma/pxa_dma.c:192:2: error: void value not ignored as it ought to be > pos += seq_printf(s, "DMA channel %d requester :\n", phy->idx); > ^ > drivers/dma/pxa_dma.c:197:8: error: void value not ignored as it ought to be > !!(drcmr & DRCMR_MAPVLD)); > ^ > scripts/Makefile.build:258: recipe for target 'drivers/dma/pxa_dma.o' failed Applied now, but not pleased that you sent broken code. Sending stuff that compiles is basic step -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information
On Wednesday 27 May 2015 23:23:40 Robert Jarzmik wrote: > This fixes the following error: > drivers/dma/pxa_dma.c: In function ‘dbg_show_requester_chan’: > drivers/dma/pxa_dma.c:192:2: error: void value not ignored as it ought to be > pos += seq_printf(s, "DMA channel %d requester :\n", phy->idx); > ^ > drivers/dma/pxa_dma.c:197:8: error: void value not ignored as it ought to be > !!(drcmr & DRCMR_MAPVLD)); > ^ > scripts/Makefile.build:258: recipe for target 'drivers/dma/pxa_dma.o' failed > > Signed-off-by: Robert Jarzmik > Acked-by: Arnd Bergmann I ran into the problem yesterday and came up with the same fix, but you submitted it first, thanks! Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/